Commit d72277b6c37db66b ("dma-buf: nuke DMA_FENCE_TRACE macros v2") in v5.16 removed all users of DMA_FENCE_TRACE on the premise that the Kconfig symbol did not exist. Apparently one failed to notice the symbol did exist since almost five years before: it was renamed from FENCE_TRACE to DMA_FENCE_TRACE in commit f54d1867005c3323 ("dma-buf: Rename struct fence to dma_fence") in v4.10.
Time passed by, so remove the Kconfig symbol, as no one seems to have missed the functionality.
Signed-off-by: Geert Uytterhoeven geert@linux-m68k.org --- drivers/base/Kconfig | 9 --------- 1 file changed, 9 deletions(-)
diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig index f7d385cbd3ba4b2b..43f20ca95a2a6ba9 100644 --- a/drivers/base/Kconfig +++ b/drivers/base/Kconfig @@ -222,15 +222,6 @@ config DMA_SHARED_BUFFER APIs extension; the file's descriptor can then be passed on to other driver.
-config DMA_FENCE_TRACE - bool "Enable verbose DMA_FENCE_TRACE messages" - depends on DMA_SHARED_BUFFER - help - Enable the DMA_FENCE_TRACE printks. This will add extra - spam to the console log, but will make it easier to diagnose - lockup related problems for dma-buffers shared across multiple - devices. - config GENERIC_ARCH_TOPOLOGY bool help
On 6/19/26 12:03, Geert Uytterhoeven wrote:
Commit d72277b6c37db66b ("dma-buf: nuke DMA_FENCE_TRACE macros v2") in v5.16 removed all users of DMA_FENCE_TRACE on the premise that the Kconfig symbol did not exist. Apparently one failed to notice the symbol did exist since almost five years before: it was renamed from FENCE_TRACE to DMA_FENCE_TRACE in commit f54d1867005c3323 ("dma-buf: Rename struct fence to dma_fence") in v4.10.
Time passed by, so remove the Kconfig symbol, as no one seems to have missed the functionality.
Yeah that functionality should be fully covered by trace points.
Signed-off-by: Geert Uytterhoeven geert@linux-m68k.org
Reviewed-by: Christian König christian.koenig@amd.com
Do you have commit right to drm-misc-next to push this?
Thanks, Christian.
drivers/base/Kconfig | 9 --------- 1 file changed, 9 deletions(-)
diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig index f7d385cbd3ba4b2b..43f20ca95a2a6ba9 100644 --- a/drivers/base/Kconfig +++ b/drivers/base/Kconfig @@ -222,15 +222,6 @@ config DMA_SHARED_BUFFER APIs extension; the file's descriptor can then be passed on to other driver. -config DMA_FENCE_TRACE
- bool "Enable verbose DMA_FENCE_TRACE messages"
- depends on DMA_SHARED_BUFFER
- help
Enable the DMA_FENCE_TRACE printks. This will add extraspam to the console log, but will make it easier to diagnoselockup related problems for dma-buffers shared across multipledevices.config GENERIC_ARCH_TOPOLOGY bool help
Hi Christian,
On Fri, 19 Jun 2026 at 12:39, Christian König christian.koenig@amd.com wrote:
On 6/19/26 12:03, Geert Uytterhoeven wrote:
Commit d72277b6c37db66b ("dma-buf: nuke DMA_FENCE_TRACE macros v2") in v5.16 removed all users of DMA_FENCE_TRACE on the premise that the Kconfig symbol did not exist. Apparently one failed to notice the symbol did exist since almost five years before: it was renamed from FENCE_TRACE to DMA_FENCE_TRACE in commit f54d1867005c3323 ("dma-buf: Rename struct fence to dma_fence") in v4.10.
Time passed by, so remove the Kconfig symbol, as no one seems to have missed the functionality.
Yeah that functionality should be fully covered by trace points.
Signed-off-by: Geert Uytterhoeven geert@linux-m68k.org
Reviewed-by: Christian König christian.koenig@amd.com
Thanks!
Do you have commit right to drm-misc-next to push this?
No, I have not.
Gr{oetje,eeting}s,
Geert
linaro-mm-sig@lists.linaro.org
-
Christian König -
Geert Uytterhoeven