From: Rob Clark robdclark@chromium.org
drive-by cleanup
Signed-off-by: Rob Clark robdclark@chromium.org --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index 319936f91ac5..667841780514 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c @@ -73,11 +73,6 @@ static void fence_set_priority(struct dma_fence *fence, rcu_read_unlock(); }
-static inline bool __dma_fence_is_chain(const struct dma_fence *fence) -{ - return fence->ops == &dma_fence_chain_ops; -} - void i915_gem_fence_wait_priority(struct dma_fence *fence, const struct i915_sched_attr *attr) { @@ -93,7 +88,7 @@ void i915_gem_fence_wait_priority(struct dma_fence *fence,
for (i = 0; i < array->num_fences; i++) fence_set_priority(array->fences[i], attr); - } else if (__dma_fence_is_chain(fence)) { + } else if (dma_fence_is_chain(fence)) { struct dma_fence *iter;
/* The chain is ordered; if we boost the last, we boost all */
On 6/29/22 01:35, Rob Clark wrote:
From: Rob Clark robdclark@chromium.org
drive-by cleanup
Signed-off-by: Rob Clark robdclark@chromium.org
Reviewed-by: Thomas Hellström thomas.hellstrom@linux.intel.com
drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index 319936f91ac5..667841780514 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c @@ -73,11 +73,6 @@ static void fence_set_priority(struct dma_fence *fence, rcu_read_unlock(); } -static inline bool __dma_fence_is_chain(const struct dma_fence *fence) -{
- return fence->ops == &dma_fence_chain_ops;
-}
- void i915_gem_fence_wait_priority(struct dma_fence *fence, const struct i915_sched_attr *attr) {
@@ -93,7 +88,7 @@ void i915_gem_fence_wait_priority(struct dma_fence *fence, for (i = 0; i < array->num_fences; i++) fence_set_priority(array->fences[i], attr);
- } else if (__dma_fence_is_chain(fence)) {
- } else if (dma_fence_is_chain(fence)) { struct dma_fence *iter;
/* The chain is ordered; if we boost the last, we boost all */
Am 29.06.22 um 01:35 schrieb Rob Clark:
From: Rob Clark robdclark@chromium.org
drive-by cleanup
Signed-off-by: Rob Clark robdclark@chromium.org
We should probably completely remove that dependency and rather use dma_fence_unwrap instead.
But that's probably for another patch Reviewed-by: Christian König christian.koenig@amd.com.
Christian.
drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index 319936f91ac5..667841780514 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c @@ -73,11 +73,6 @@ static void fence_set_priority(struct dma_fence *fence, rcu_read_unlock(); } -static inline bool __dma_fence_is_chain(const struct dma_fence *fence) -{
- return fence->ops == &dma_fence_chain_ops;
-}
- void i915_gem_fence_wait_priority(struct dma_fence *fence, const struct i915_sched_attr *attr) {
@@ -93,7 +88,7 @@ void i915_gem_fence_wait_priority(struct dma_fence *fence, for (i = 0; i < array->num_fences; i++) fence_set_priority(array->fences[i], attr);
- } else if (__dma_fence_is_chain(fence)) {
- } else if (dma_fence_is_chain(fence)) { struct dma_fence *iter;
/* The chain is ordered; if we boost the last, we boost all */
On 29.06.2022 01:35, Rob Clark wrote:
From: Rob Clark robdclark@chromium.org
drive-by cleanup
Signed-off-by: Rob Clark robdclark@chromium.org
Reviewed-by: Andrzej Hajda andrzej.hajda@intel.com
Regards Andrzej
drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index 319936f91ac5..667841780514 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c @@ -73,11 +73,6 @@ static void fence_set_priority(struct dma_fence *fence, rcu_read_unlock(); } -static inline bool __dma_fence_is_chain(const struct dma_fence *fence) -{
- return fence->ops == &dma_fence_chain_ops;
-}
- void i915_gem_fence_wait_priority(struct dma_fence *fence, const struct i915_sched_attr *attr) {
@@ -93,7 +88,7 @@ void i915_gem_fence_wait_priority(struct dma_fence *fence, for (i = 0; i < array->num_fences; i++) fence_set_priority(array->fences[i], attr);
- } else if (__dma_fence_is_chain(fence)) {
- } else if (dma_fence_is_chain(fence)) { struct dma_fence *iter;
/* The chain is ordered; if we boost the last, we boost all */
linaro-mm-sig@lists.linaro.org
-
Andrzej Hajda -
Christian König -
Rob Clark -
Thomas Hellström (Intel)