Thanks for reply.

On 2022/1/4 02:45, John Stultz wrote:

On Tue, Dec 28, 2021 at 11:09 PM Weizhao Ouyang o451686892@gmail.com wrote:

...

Fix cma_heap_buffer mutex lock area to protect vmap_cnt and vaddr. And move struct dma_heap_attachment to dma-heap.h so that vendor dma heaps can use it, the same behaviour as struct dma_buf_attachment.

Hey! Thanks for submitting this patch! Apologies for the slow reply (was out for the holidays).

This patch is combining two changes in one patch, so they need to be split up. The locking change looks sane, but moving the dma_heap_attachment may need some extra justification as changing upstream code just to support out of tree code isn't usually done (if there was some benefit to the in-tree code, that would be fine though).

I'd also be eager to try to get the vendor heap to be merged, assuming we can also merge an upstream user for it.

Yeap moving the dma_heap_attachment need more sufficient reason, and it should add a private area to adapt vendor heap change if we move it to in-tree code. So just drop the idea now :)

I will send a new patch to clarify the locking change later.

Thanks, Weizhao