On 09/04/2024 15:42, Alexandre Mergnat wrote:

Add audio codec support of MT6357 PMIC. Update the file header.

Why?

Signed-off-by: Alexandre Mergnat amergnat@baylibre.com

arch/arm64/boot/dts/mediatek/mt6357.dtsi | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt6357.dtsi b/arch/arm64/boot/dts/mediatek/mt6357.dtsi index 3330a03c2f74..ade410851524 100644 --- a/arch/arm64/boot/dts/mediatek/mt6357.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt6357.dtsi @@ -1,7 +1,7 @@ // SPDX-License-Identifier: (GPL-2.0 OR MIT) /*

• Copyright (c) 2020 MediaTek Inc.

• • Copyright (c) 2023 BayLibre Inc.

• • Copyright (c) 2024 BayLibre Inc.

That's not a reasonable change. The file was published on 2023, wasn't it? If this is not correct, please explain why/how and make it separate patch.

*/ #include <dt-bindings/input/input.h> @@ -10,6 +10,9 @@ &pwrap { mt6357_pmic: pmic { compatible = "mediatek,mt6357";

• mt6357_codec: codec {
  

• };
  

There is no single point of having empty nodes.

NAK.

Best regards, Krzysztof