On 12/1/22 03:55, zys.zljxml@gmail.com wrote:

From: Yushan Zhou katrinzhou@tencent.com

Fix the following coccicheck warning: ./drivers/gpu/host1x/fence.c:97:2-7: WARNING: NULL check before some freeing functions is not needed.

Signed-off-by: Yushan Zhou katrinzhou@tencent.com

drivers/gpu/host1x/fence.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/host1x/fence.c b/drivers/gpu/host1x/fence.c index ecab72882192..05b36bfc8b74 100644 --- a/drivers/gpu/host1x/fence.c +++ b/drivers/gpu/host1x/fence.c @@ -93,8 +93,7 @@ static void host1x_syncpt_fence_release(struct dma_fence *f) { struct host1x_syncpt_fence *sf = to_host1x_fence(f);

• if (sf->waiter)

• kfree(sf->waiter);
  

• kfree(sf->waiter);

dma_fence_free(f); }

I disagree with this coccinelle rule; I think it obfuscates from the reader the fact that the pointer could be NULL.

Mikko