On 11/18/26 2:52 PM, Antoni Pokusinski wrote:
Both functions omap_i2c_{receive|transmit}_data() have unused arguments is_{r|x}dr which can be deleted.
Signed-off-by: Antoni Pokusinski apokusinski01@gmail.com
I sent this same patch a few months ago..
https://patchwork.ozlabs.org/project/linux-i2c/patch/20260908154223.116074-3...
drivers/i2c/busses/i2c-omap.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index f02d294db42a..3f7060d57a86 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -996,8 +996,7 @@ static int errata_omap3_i462(struct omap_i2c_dev *omap) return 0; } -static void omap_i2c_receive_data(struct omap_i2c_dev *omap, u8 num_bytes,
bool is_rdr)+static void omap_i2c_receive_data(struct omap_i2c_dev *omap, u8 num_bytes) { u16 w; @@ -1017,8 +1016,7 @@ static void omap_i2c_receive_data(struct omap_i2c_dev *omap, u8 num_bytes, } } -static int omap_i2c_transmit_data(struct omap_i2c_dev *omap, u8 num_bytes,
bool is_xdr)+static int omap_i2c_transmit_data(struct omap_i2c_dev *omap, u8 num_bytes) { u16 w; @@ -1122,7 +1120,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *omap) OMAP_I2C_BUFSTAT_REG) >> 8) & 0x3F; }
omap_i2c_receive_data(omap, num_bytes, true);
}omap_i2c_receive_data(omap, num_bytes); omap_i2c_ack_stat(omap, OMAP_I2C_STAT_RDR); continue;@@ -1133,7 +1131,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *omap) if (omap->threshold) num_bytes = omap->threshold;
omap_i2c_receive_data(omap, num_bytes, false);
}omap_i2c_receive_data(omap, num_bytes); omap_i2c_ack_stat(omap, OMAP_I2C_STAT_RRDY); continue;@@ -1145,7 +1143,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *omap) if (omap->fifo_size) num_bytes = omap->buf_len;
ret = omap_i2c_transmit_data(omap, num_bytes, true);
ret = omap_i2c_transmit_data(omap, num_bytes); if (ret < 0) break;@@ -1160,7 +1158,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *omap) if (omap->threshold) num_bytes = omap->threshold;
ret = omap_i2c_transmit_data(omap, num_bytes, false);
ret = omap_i2c_transmit_data(omap, num_bytes); if (ret < 0) break;
linaro-mm-sig@lists.linaro.org