On Thu, Mar 28, 2024 at 12:06:56PM +0000, Naveen Mamindlapalli wrote:

...

diff --git a/drivers/net/ethernet/ti/k3-cppi-desc-pool.c b/drivers/net/ethernet/ti/k3- cppi-desc-pool.c index 05cc7aab1ec8..fe8203c05731 100644 --- a/drivers/net/ethernet/ti/k3-cppi-desc-pool.c +++ b/drivers/net/ethernet/ti/k3-cppi-desc-pool.c @@ -132,5 +132,17 @@ size_t k3_cppi_desc_pool_avail(struct k3_cppi_desc_pool *pool) } EXPORT_SYMBOL_GPL(k3_cppi_desc_pool_avail);

+size_t k3_cppi_desc_pool_desc_size(struct k3_cppi_desc_pool *pool) {

• return pool->desc_size;

Don't you need to add NULL check on pool ptr since this function is exported?

What bearing does exporting a function have on whether it should check for NULL?

Given that this function returns size_t, it can't return an error number. So what value would it return if "pool" were NULL? It can only return a positive integer or zero.

Also, the argument should be const as the function doesn't modify the contents of "pool".