CoreSight

coresight@lists.linaro.org

3 participants
2708 discussions

Re: [PATCH 1/1] coresight: tmc-etr: Sync the trace buffer for the device

by Leo Yan

On Wed, Sep 16, 2026 at 11:04:20AM +0800, Jie Gan wrote: [...] > > From: Min Chen <min.chen(a)siengine.com> > > > > The flat ETR buffer comes from dma_alloc_noncoherent(), which zeroes it > > with CPU stores. The DMA API requires the caller to sync the buffer for > > the device before the device writes into it, but the TMC driver only > > ever syncs for the CPU afterwards. On a non-coherent sink the zero fill > > is therefore still dirty in cache when the ETR starts writing, and its > > write-back lands on top of the trace data. Good catch! I'm curious how you observed the dirty cache lines overwriting trace data in DDR and causing corruption. > Agree, without the sync, the dirty data may overwrites the trace data. > > Add a sync_for_device() buffer operation and call it from > > __tmc_etr_enable_hw() just before the TMC is enabled. I don't think __tmc_etr_enable_hw() is the best place for the sync, as it can be called frequently when an event is enabled, e.g. when a task is scheduled in or migrated between CPUs. We should be able to sync once after dma_alloc_noncoherent() instead. The issue is not limited to buffer init. The driver also injects barrier packets into the bounce buffer, which can race with the sink. Even worse, the barrier packet write may collide with trace data when they share a cache line. I think we should consider writing barrier packets directly into the AUX buffer. This would avoid stale cache data from barrier packet writes and simplify the flow without additional sync operations. Would you mind if I pick up this patch (keeping you as the author) and add a second patch to address the barrier packet issue? That part may need some several rounds refactoring so can have better shape, I think it would be easier to consolidate the fixes on my side. Thanks, Leo P.s. Please CC me on future CoreSight patches. If you're using the mainline ./scripts/get_maintainer.pl, it should add me automatically. I didn't receive this patch directly, which is why I'm replying to Jie's email (also thanks Jie's review).

1 month, 3 weeks

[PATCH 00/14] perf cs-etm: Per-thread mode fixes and snapshot wrap support

by James Clark

Fix a few issues with per-thread mode: - With TRBE, thread migrations hit a queue without a decoder assert - On nVHE, everything looks like guest trace instead of host - Tracing multiple threads didn't really work After adding a tests for those, it turns out there were some snapshot bugs not picked up by the other snapshot tests. That showed that the different snapshot searches for Intel BTS and Arm SPE were inconsistent and I think all tracers can benefit from using the same pointer fixup logic, so that gets refactored into the common auxtrace.c. Then SPE can just share the Intel BTS search as it was obviously copied from it originally. IntelPT keeps the more advanced duplicate data search, but in the future that could probably be made the common one and all tracers would benefit from using it (except maybe BTS if it always has a very small buffer, but I doubt the overhead of the duplicate search would be an issue). For now this is more of a refactor rather than behavioral change so don't do that yet. Signed-off-by: James Clark <james.clark(a)linaro.org> --- James Clark (14): perf cs-etm: Fix nVHE per-thread decoding perf cs-etm: Warn for invalid timestamp option perf cs-etm: Turn on context packet timestamps in per-thread mode perf cs-etm: Use per-CPU queues for per-thread mode perf cs-etm: Increase default timestamp generation period perf auxtrace: Turn Intel BTS snapshot search into a generic one perf arm-spe: Use generic snapshot search perf auxtrace: intel-pt: Use new snapshot_has_wrapped callback perf cs-etm: Queue partial AUX records perf cs-etm: Don't print missing buffers in snapshot mode perf auxtrace: cs-etm: Capture wrapped snapshots perf test: Allow infinite named_thread loops perf test: Add test for per-thread mode perf cs-etm: Test multiple per-thread threads Documentation/userspace-api/perf_ring_buffer.rst | 6 +- tools/perf/Documentation/perf-test.txt | 2 +- tools/perf/arch/arm/util/cs-etm.c | 30 ++++- tools/perf/arch/arm64/util/arm-spe.c | 147 +-------------------- tools/perf/arch/x86/util/intel-bts.c | 115 +--------------- tools/perf/arch/x86/util/intel-pt.c | 58 +++----- .../perf/tests/shell/coresight/per-thread-multi.sh | 78 +++++++++++ tools/perf/tests/shell/coresight/per-thread.sh | 48 +++++++ .../perf/tests/shell/coresight/raw_dump_stress.sh | 5 - tools/perf/tests/workloads/named_threads.c | 7 +- tools/perf/util/auxtrace.c | 136 +++++++++++++++++-- tools/perf/util/auxtrace.h | 20 ++- tools/perf/util/cs-etm.c | 98 ++++++++++---- 13 files changed, 382 insertions(+), 368 deletions(-) --- base-commit: bf10e6ee2ac3034c9068e03eed418fd16961984e change-id: 20260605-james-cs-unformatted-per-thread-fix-50e723aa7f0e Best regards, -- James Clark <james.clark(a)linaro.org>

1 month, 3 weeks

Re: [PATCH v10 3/5] coresight: cti: add Qualcomm extended CTI identification and quirks

by Mike Leach

On 6/15/26 13:32, Yingchao Deng wrote: > Qualcomm implements an extended variant of the ARM CoreSight CTI with a > different register layout and vendor-specific behavior. While the > programming model remains largely compatible, the register offsets differ > from the standard ARM CTI and require explicit handling. > > Detect Qualcomm CTIs via the DEVARCH register and record this in the CTI > driver data. Introduce a small mapping layer to translate standard CTI > register offsets to Qualcomm-specific offsets, allowing the rest of the > driver to use a common register access path. > > Additionally, handle a Qualcomm-specific quirk where the hardware does > not implement the CoreSight Claim tag protocol. Instead of clearing the > CLAIMSET register at probe time, bypass the claim/disclaim operations > entirely for Qualcomm CTIs by wrapping coresight_claim_device(), > coresight_disclaim_device_unlocked() and coresight_clear_self_claim_tag() > in thin helpers that early-return when is_qcom_cti is set. > > No functional change is intended for standard ARM CTI devices. > > Co-developed-by: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com> > Signed-off-by: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com> > Signed-off-by: Yingchao Deng <yingchao.deng(a)oss.qualcomm.com> > --- > drivers/hwtracing/coresight/coresight-cti-core.c | 47 +++++++++++++++-- > drivers/hwtracing/coresight/coresight-cti.h | 64 +++++++++++++++++++++++- > 2 files changed, 105 insertions(+), 6 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-cti-core.c b/drivers/hwtracing/coresight/coresight-cti-core.c > index fa758c535ccb..5b83dd4e603b 100644 > --- a/drivers/hwtracing/coresight/coresight-cti-core.c > +++ b/drivers/hwtracing/coresight/coresight-cti-core.c > @@ -73,6 +73,35 @@ void cti_write_all_hw_regs(struct cti_drvdata *drvdata) > CS_LOCK(drvdata->base); > } > > +/* > + * Qualcomm CTIs do not implement the CoreSight Claim tag protocol, so > + * bypass coresight_clear_self_claim_tag() for them. > + */ > +static void cti_clear_self_claim_tag(struct cti_drvdata *drvdata, > + struct csdev_access *csa) > +{ > + if (drvdata->is_qcom_cti) > + return; > + > + coresight_clear_self_claim_tag(csa); > +} > + > +static int cti_claim_device(struct cti_drvdata *drvdata) > +{ > + if (drvdata->is_qcom_cti) > + return 0; > + > + return coresight_claim_device(drvdata->csdev); > +} > + > +static void cti_unclaim_device_unlocked(struct cti_drvdata *drvdata) > +{ > + if (drvdata->is_qcom_cti) > + return; > + > + coresight_disclaim_device_unlocked(drvdata->csdev); > +} > + > /* write regs to hardware and enable */ > static int cti_enable_hw(struct cti_drvdata *drvdata) > { > @@ -86,7 +115,7 @@ static int cti_enable_hw(struct cti_drvdata *drvdata) > goto cti_state_unchanged; > > /* claim the device */ > - rc = coresight_claim_device(drvdata->csdev); > + rc = cti_claim_device(drvdata); > if (rc) > return rc; > > @@ -101,7 +130,6 @@ static int cti_enable_hw(struct cti_drvdata *drvdata) > static int cti_disable_hw(struct cti_drvdata *drvdata) > { > struct cti_config *config = &drvdata->config; > - struct coresight_device *csdev = drvdata->csdev; > > guard(raw_spinlock_irqsave)(&drvdata->spinlock); > > @@ -118,7 +146,7 @@ static int cti_disable_hw(struct cti_drvdata *drvdata) > /* disable CTI */ > writel_relaxed(0, drvdata->base + CTICONTROL); > > - coresight_disclaim_device_unlocked(csdev); > + cti_unclaim_device_unlocked(drvdata); > CS_LOCK(drvdata->base); > return 0; > } > @@ -144,6 +172,9 @@ void cti_write_intack(struct device *dev, u32 ackval) > /* DEVID[19:16] - number of CTM channels */ > #define CTI_DEVID_CTMCHANNELS(devid_val) ((int) BMVAL(devid_val, 16, 19)) > > +/* DEVARCH[31:21] - ARCHITECT */ > +#define CTI_DEVARCH_ARCHITECT(devarch_val) ((int)BMVAL(devarch_val, 21, 31)) > + > static int cti_set_default_config(struct device *dev, > struct cti_drvdata *drvdata) > { > @@ -684,6 +715,7 @@ static int cti_probe(struct amba_device *adev, const struct amba_id *id) > struct coresight_desc cti_desc = { 0 }; > struct coresight_platform_data *pdata = NULL; > struct resource *res = &adev->res; > + u32 devarch; > > /* driver data*/ > drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); > @@ -708,6 +740,10 @@ static int cti_probe(struct amba_device *adev, const struct amba_id *id) > > raw_spin_lock_init(&drvdata->spinlock); > > + devarch = readl_relaxed(drvdata->base + CORESIGHT_DEVARCH); > + if (CTI_DEVARCH_ARCHITECT(devarch) == QCOM_ARCHITECT) > + drvdata->is_qcom_cti = true; > + > /* initialise CTI driver config values */ > ret = cti_set_default_config(dev, drvdata); > if (ret) > @@ -753,7 +789,7 @@ static int cti_probe(struct amba_device *adev, const struct amba_id *id) > cti_desc.groups = drvdata->ctidev.con_groups; > cti_desc.dev = dev; > > - coresight_clear_self_claim_tag(&cti_desc.access); > + cti_clear_self_claim_tag(drvdata, &cti_desc.access); > drvdata->csdev = coresight_register(&cti_desc); > if (IS_ERR(drvdata->csdev)) > return PTR_ERR(drvdata->csdev); > @@ -767,7 +803,8 @@ static int cti_probe(struct amba_device *adev, const struct amba_id *id) > > /* all done - dec pm refcount */ > pm_runtime_put(&adev->dev); > - dev_info(&drvdata->csdev->dev, "CTI initialized\n"); > + dev_info(&drvdata->csdev->dev, > + "%sCTI initialized\n", drvdata->is_qcom_cti ? "QCOM " : ""); > return 0; > } > > diff --git a/drivers/hwtracing/coresight/coresight-cti.h b/drivers/hwtracing/coresight/coresight-cti.h > index 634bdce5cdfd..4b6fd6b55114 100644 > --- a/drivers/hwtracing/coresight/coresight-cti.h > +++ b/drivers/hwtracing/coresight/coresight-cti.h > @@ -54,10 +54,36 @@ struct fwnode_handle; > /* > * CTI CSSoc 600 has a max of 32 trigger signals per direction. > * CTI CSSoc 400 has 8 IO triggers - other CTIs can be impl def. > + * QCOM CTI support up to 128 trigger signals per direction. > * Max of in and out defined in the DEVID register. > * - pick up actual number used from .dts parameters if present. I haven't seen anything in these patches that actually does check for max CTIINOUT values in .dts. Would it not be better to have a QCOM_CTIINOUTENMAX and set the max value in config based on the is_qcom_cti flag? Otherwise it appears that the standard arm CTIs are going to create a whole lot of unneeded/unused registers Regards Mike > */ > -#define CTIINOUTEN_MAX 32 > +#define CTIINOUTEN_MAX 128 > + > +/* QCOM CTI extension */ > +#define QCOM_ARCHITECT 0x477 > + > +#define QCOM_CTIINTACK 0x020 > +#define QCOM_CTIAPPSET 0x004 > +#define QCOM_CTIAPPCLEAR 0x008 > +#define QCOM_CTIAPPPULSE 0x00C > +#define QCOM_CTIINEN 0x400 > +#define QCOM_CTIOUTEN 0x800 > +#define QCOM_CTITRIGINSTATUS 0x040 > +#define QCOM_CTITRIGOUTSTATUS 0x060 > +#define QCOM_CTICHINSTATUS 0x080 > +#define QCOM_CTICHOUTSTATUS 0x084 > +#define QCOM_CTIGATE 0x088 > +#define QCOM_ASICCTL 0x08C > +/* Integration test registers */ > +#define QCOM_ITCHINACK 0xE70 > +#define QCOM_ITTRIGINACK 0xE80 > +#define QCOM_ITCHOUT 0xE74 > +#define QCOM_ITTRIGOUT 0xEA0 > +#define QCOM_ITCHOUTACK 0xE78 > +#define QCOM_ITTRIGOUTACK 0xEC0 > +#define QCOM_ITCHIN 0xE7C > +#define QCOM_ITTRIGIN 0xEE0 > > /** > * Group of related trigger signals > @@ -168,6 +194,9 @@ struct cti_config { > * @spinlock: Control data access to one at a time. > * @config: Configuration data for this CTI device. > * @node: List entry of this device in the list of CTI devices. > + * @is_qcom_cti: True if this CTI is a Qualcomm vendor-specific > + * variant that requires register offset translation > + * via cti_qcom_reg_off(). > */ > struct cti_drvdata { > void __iomem *base; > @@ -176,6 +205,7 @@ struct cti_drvdata { > raw_spinlock_t spinlock; > struct cti_config config; > struct list_head node; > + bool is_qcom_cti; > }; > > /* > @@ -229,9 +259,41 @@ struct coresight_platform_data * > coresight_cti_get_platform_data(struct device *dev); > const char *cti_plat_get_node_name(struct fwnode_handle *fwnode); > > +static inline u32 cti_qcom_reg_off(u32 offset) > +{ > + switch (offset) { > + case CTIINTACK: return QCOM_CTIINTACK; > + case CTIAPPSET: return QCOM_CTIAPPSET; > + case CTIAPPCLEAR: return QCOM_CTIAPPCLEAR; > + case CTIAPPPULSE: return QCOM_CTIAPPPULSE; > + case CTIINEN: return QCOM_CTIINEN; > + case CTIOUTEN: return QCOM_CTIOUTEN; > + case CTITRIGINSTATUS: return QCOM_CTITRIGINSTATUS; > + case CTITRIGOUTSTATUS: return QCOM_CTITRIGOUTSTATUS; > + case CTICHINSTATUS: return QCOM_CTICHINSTATUS; > + case CTICHOUTSTATUS: return QCOM_CTICHOUTSTATUS; > + case CTIGATE: return QCOM_CTIGATE; > + case ASICCTL: return QCOM_ASICCTL; > + case ITCHINACK: return QCOM_ITCHINACK; > + case ITTRIGINACK: return QCOM_ITTRIGINACK; > + case ITCHOUT: return QCOM_ITCHOUT; > + case ITTRIGOUT: return QCOM_ITTRIGOUT; > + case ITCHOUTACK: return QCOM_ITCHOUTACK; > + case ITTRIGOUTACK: return QCOM_ITTRIGOUTACK; > + case ITCHIN: return QCOM_ITCHIN; > + case ITTRIGIN: return QCOM_ITTRIGIN; > + > + default: > + return offset; > + } > +} > + > static inline void __iomem *__reg_addr(struct cti_drvdata *drvdata, > u32 off, u32 index) > { > + if (unlikely(drvdata->is_qcom_cti)) > + off = cti_qcom_reg_off(off); > + > return drvdata->base + off + index * sizeof(u32); > } > >

1 month, 3 weeks

Re: [PATCH v10 1/5] coresight: cti: Convert trigger usage fields to dynamic

by Mike Leach

Reviewed-by: Mike Leach <mike.leach(a)arm.com> On 6/15/26 13:32, Yingchao Deng wrote: > Replace the fixed-size u32 fields in the cti_config and cti_trig_grp > structure with dynamically allocated bitmaps and arrays. This allows > memory to be allocated based on the actual number of triggers during probe > time, reducing memory footprint and improving scalability for platforms > with varying trigger counts. > > Also add a bounds check in cti_allocate_trig_con() to ensure the caller > does not pass in/out signal counts larger than nr_trig_max. > > Reviewed-by: Leo Yan <leo.yan(a)arm.com> > Signed-off-by: Yingchao Deng <yingchao.deng(a)oss.qualcomm.com> > --- > drivers/hwtracing/coresight/coresight-cti-core.c | 70 +++++++++++++++++----- > .../hwtracing/coresight/coresight-cti-platform.c | 26 +++++--- > drivers/hwtracing/coresight/coresight-cti-sysfs.c | 14 ++--- > drivers/hwtracing/coresight/coresight-cti.h | 12 ++-- > 4 files changed, 87 insertions(+), 35 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-cti-core.c b/drivers/hwtracing/coresight/coresight-cti-core.c > index b2c9a4db13b4..572798ab504c 100644 > --- a/drivers/hwtracing/coresight/coresight-cti-core.c > +++ b/drivers/hwtracing/coresight/coresight-cti-core.c > @@ -161,8 +161,8 @@ void cti_write_intack(struct device *dev, u32 ackval) > /* DEVID[19:16] - number of CTM channels */ > #define CTI_DEVID_CTMCHANNELS(devid_val) ((int) BMVAL(devid_val, 16, 19)) > > -static void cti_set_default_config(struct device *dev, > - struct cti_drvdata *drvdata) > +static int cti_set_default_config(struct device *dev, > + struct cti_drvdata *drvdata) > { > struct cti_config *config = &drvdata->config; > u32 devid; > @@ -181,6 +181,31 @@ static void cti_set_default_config(struct device *dev, > config->nr_trig_max = CTIINOUTEN_MAX; > } > > + config->trig_in_use = devm_bitmap_zalloc(dev, config->nr_trig_max, > + GFP_KERNEL); > + if (!config->trig_in_use) > + return -ENOMEM; > + > + config->trig_out_use = devm_bitmap_zalloc(dev, config->nr_trig_max, > + GFP_KERNEL); > + if (!config->trig_out_use) > + return -ENOMEM; > + > + config->trig_out_filter = devm_bitmap_zalloc(dev, config->nr_trig_max, > + GFP_KERNEL); > + if (!config->trig_out_filter) > + return -ENOMEM; > + > + config->ctiinen = devm_kcalloc(dev, config->nr_trig_max, sizeof(u32), > + GFP_KERNEL); > + if (!config->ctiinen) > + return -ENOMEM; > + > + config->ctiouten = devm_kcalloc(dev, config->nr_trig_max, sizeof(u32), > + GFP_KERNEL); > + if (!config->ctiouten) > + return -ENOMEM; > + > config->nr_ctm_channels = CTI_DEVID_CTMCHANNELS(devid); > > /* Most regs default to 0 as zalloc'ed except...*/ > @@ -189,6 +214,7 @@ static void cti_set_default_config(struct device *dev, > config->enable_req_count = 0; > > config->asicctl_impl = !!FIELD_GET(GENMASK(4, 0), devid); > + return 0; > } > > /* > @@ -219,8 +245,10 @@ int cti_add_connection_entry(struct device *dev, struct cti_drvdata *drvdata, > cti_dev->nr_trig_con++; > > /* add connection usage bit info to overall info */ > - drvdata->config.trig_in_use |= tc->con_in->used_mask; > - drvdata->config.trig_out_use |= tc->con_out->used_mask; > + bitmap_or(drvdata->config.trig_in_use, drvdata->config.trig_in_use, > + tc->con_in->used_mask, drvdata->config.nr_trig_max); > + bitmap_or(drvdata->config.trig_out_use, drvdata->config.trig_out_use, > + tc->con_out->used_mask, drvdata->config.nr_trig_max); > > return 0; > } > @@ -231,6 +259,14 @@ struct cti_trig_con *cti_allocate_trig_con(struct device *dev, int in_sigs, > { > struct cti_trig_con *tc = NULL; > struct cti_trig_grp *in = NULL, *out = NULL; > + struct cti_drvdata *drvdata = dev_get_drvdata(dev); > + int n_trigs = drvdata->config.nr_trig_max; > + > + if (in_sigs > n_trigs || out_sigs > n_trigs) { > + dev_err(dev, "trigger signal is out of range: in=%d out=%d nr_max=%d\n", > + in_sigs, out_sigs, n_trigs); > + return NULL; > + } > > tc = devm_kzalloc(dev, sizeof(struct cti_trig_con), GFP_KERNEL); > if (!tc) > @@ -242,12 +278,20 @@ struct cti_trig_con *cti_allocate_trig_con(struct device *dev, int in_sigs, > if (!in) > return NULL; > > + in->used_mask = devm_bitmap_zalloc(dev, n_trigs, GFP_KERNEL); > + if (!in->used_mask) > + return NULL; > + > out = devm_kzalloc(dev, > offsetof(struct cti_trig_grp, sig_types[out_sigs]), > GFP_KERNEL); > if (!out) > return NULL; > > + out->used_mask = devm_bitmap_zalloc(dev, n_trigs, GFP_KERNEL); > + if (!out->used_mask) > + return NULL; > + > tc->con_in = in; > tc->con_out = out; > tc->con_in->nr_sigs = in_sigs; > @@ -263,7 +307,6 @@ int cti_add_default_connection(struct device *dev, struct cti_drvdata *drvdata) > { > int ret = 0; > int n_trigs = drvdata->config.nr_trig_max; > - u32 n_trig_mask = GENMASK(n_trigs - 1, 0); > struct cti_trig_con *tc = NULL; > > /* > @@ -274,8 +317,8 @@ int cti_add_default_connection(struct device *dev, struct cti_drvdata *drvdata) > if (!tc) > return -ENOMEM; > > - tc->con_in->used_mask = n_trig_mask; > - tc->con_out->used_mask = n_trig_mask; > + bitmap_fill(tc->con_in->used_mask, n_trigs); > + bitmap_fill(tc->con_out->used_mask, n_trigs); > ret = cti_add_connection_entry(dev, drvdata, tc, NULL, "default"); > return ret; > } > @@ -288,7 +331,6 @@ int cti_channel_trig_op(struct device *dev, enum cti_chan_op op, > { > struct cti_drvdata *drvdata = dev_get_drvdata(dev->parent); > struct cti_config *config = &drvdata->config; > - u32 trig_bitmask; > u32 chan_bitmask; > u32 reg_value; > int reg_offset; > @@ -298,18 +340,16 @@ int cti_channel_trig_op(struct device *dev, enum cti_chan_op op, > (trigger_idx >= config->nr_trig_max)) > return -EINVAL; > > - trig_bitmask = BIT(trigger_idx); > - > /* ensure registered triggers and not out filtered */ > if (direction == CTI_TRIG_IN) { > - if (!(trig_bitmask & config->trig_in_use)) > + if (!(test_bit(trigger_idx, config->trig_in_use))) > return -EINVAL; > } else { > - if (!(trig_bitmask & config->trig_out_use)) > + if (!(test_bit(trigger_idx, config->trig_out_use))) > return -EINVAL; > > if ((config->trig_filter_enable) && > - (config->trig_out_filter & trig_bitmask)) > + test_bit(trigger_idx, config->trig_out_filter)) > return -EINVAL; > } > > @@ -687,7 +727,9 @@ static int cti_probe(struct amba_device *adev, const struct amba_id *id) > raw_spin_lock_init(&drvdata->spinlock); > > /* initialise CTI driver config values */ > - cti_set_default_config(dev, drvdata); > + ret = cti_set_default_config(dev, drvdata); > + if (ret) > + return ret; > > pdata = coresight_cti_get_platform_data(dev); > if (IS_ERR(pdata)) { > diff --git a/drivers/hwtracing/coresight/coresight-cti-platform.c b/drivers/hwtracing/coresight/coresight-cti-platform.c > index d6d5388705c3..ba5a7e4b6bff 100644 > --- a/drivers/hwtracing/coresight/coresight-cti-platform.c > +++ b/drivers/hwtracing/coresight/coresight-cti-platform.c > @@ -136,8 +136,8 @@ static int cti_plat_create_v8_etm_connection(struct device *dev, > goto create_v8_etm_out; > > /* build connection data */ > - tc->con_in->used_mask = 0xF0; /* sigs <4,5,6,7> */ > - tc->con_out->used_mask = 0xF0; /* sigs <4,5,6,7> */ > + bitmap_set(tc->con_in->used_mask, 4, 4); /* sigs <4,5,6,7> */ > + bitmap_set(tc->con_out->used_mask, 4, 4); /* sigs <4,5,6,7> */ > > /* > * The EXTOUT type signals from the ETM are connected to a set of input > @@ -194,10 +194,10 @@ static int cti_plat_create_v8_connections(struct device *dev, > goto of_create_v8_out; > > /* Set the v8 PE CTI connection data */ > - tc->con_in->used_mask = 0x3; /* sigs <0 1> */ > + bitmap_set(tc->con_in->used_mask, 0, 2); /* sigs <0 1> */ > tc->con_in->sig_types[0] = PE_DBGTRIGGER; > tc->con_in->sig_types[1] = PE_PMUIRQ; > - tc->con_out->used_mask = 0x7; /* sigs <0 1 2 > */ > + bitmap_set(tc->con_out->used_mask, 0, 3); /* sigs <0 1 2 > */ > tc->con_out->sig_types[0] = PE_EDBGREQ; > tc->con_out->sig_types[1] = PE_DBGRESTART; > tc->con_out->sig_types[2] = PE_CTIIRQ; > @@ -213,7 +213,7 @@ static int cti_plat_create_v8_connections(struct device *dev, > goto of_create_v8_out; > > /* filter pe_edbgreq - PE trigout sig <0> */ > - drvdata->config.trig_out_filter |= 0x1; > + set_bit(0, drvdata->config.trig_out_filter); > > of_create_v8_out: > return ret; > @@ -257,7 +257,7 @@ static int cti_plat_read_trig_group(struct cti_trig_grp *tgrp, > if (!err) { > /* set the signal usage mask */ > for (idx = 0; idx < tgrp->nr_sigs; idx++) > - tgrp->used_mask |= BIT(values[idx]); > + set_bit(values[idx], tgrp->used_mask); > } > > kfree(values); > @@ -316,24 +316,34 @@ static int cti_plat_process_filter_sigs(struct cti_drvdata *drvdata, > { > struct cti_trig_grp *tg = NULL; > int err = 0, nr_filter_sigs; > + int nr_trigs = drvdata->config.nr_trig_max; > > nr_filter_sigs = cti_plat_count_sig_elements(fwnode, > CTI_DT_FILTER_OUT_SIGS); > if (nr_filter_sigs == 0) > return 0; > > - if (nr_filter_sigs > drvdata->config.nr_trig_max) > + if (nr_filter_sigs > nr_trigs) > return -EINVAL; > > tg = kzalloc_obj(*tg); > if (!tg) > return -ENOMEM; > > + tg->used_mask = bitmap_zalloc(nr_trigs, GFP_KERNEL); > + if (!tg->used_mask) { > + kfree(tg); > + return -ENOMEM; > + } > + > tg->nr_sigs = nr_filter_sigs; > err = cti_plat_read_trig_group(tg, fwnode, CTI_DT_FILTER_OUT_SIGS); > if (!err) > - drvdata->config.trig_out_filter |= tg->used_mask; > + bitmap_or(drvdata->config.trig_out_filter, > + drvdata->config.trig_out_filter, > + tg->used_mask, nr_trigs); > > + bitmap_free(tg->used_mask); > kfree(tg); > return err; > } > diff --git a/drivers/hwtracing/coresight/coresight-cti-sysfs.c b/drivers/hwtracing/coresight/coresight-cti-sysfs.c > index 3fe2c916d228..2bbfa405cb6b 100644 > --- a/drivers/hwtracing/coresight/coresight-cti-sysfs.c > +++ b/drivers/hwtracing/coresight/coresight-cti-sysfs.c > @@ -719,12 +719,12 @@ static ssize_t trigout_filtered_show(struct device *dev, > struct cti_drvdata *drvdata = dev_get_drvdata(dev->parent); > struct cti_config *cfg = &drvdata->config; > int nr_trig_max = cfg->nr_trig_max; > - unsigned long mask = cfg->trig_out_filter; > + unsigned long *mask = cfg->trig_out_filter; > > - if (mask == 0) > + if (bitmap_empty(mask, nr_trig_max)) > return 0; > > - return sysfs_emit(buf, "%*pbl\n", nr_trig_max, &mask); > + return sysfs_emit(buf, "%*pbl\n", nr_trig_max, mask); > } > static DEVICE_ATTR_RO(trigout_filtered); > > @@ -931,9 +931,9 @@ static ssize_t trigin_sig_show(struct device *dev, > struct cti_trig_con *con = (struct cti_trig_con *)ext_attr->var; > struct cti_drvdata *drvdata = dev_get_drvdata(dev->parent); > struct cti_config *cfg = &drvdata->config; > - unsigned long mask = con->con_in->used_mask; > + unsigned long *mask = con->con_in->used_mask; > > - return sysfs_emit(buf, "%*pbl\n", cfg->nr_trig_max, &mask); > + return sysfs_emit(buf, "%*pbl\n", cfg->nr_trig_max, mask); > } > > static ssize_t trigout_sig_show(struct device *dev, > @@ -945,9 +945,9 @@ static ssize_t trigout_sig_show(struct device *dev, > struct cti_trig_con *con = (struct cti_trig_con *)ext_attr->var; > struct cti_drvdata *drvdata = dev_get_drvdata(dev->parent); > struct cti_config *cfg = &drvdata->config; > - unsigned long mask = con->con_out->used_mask; > + unsigned long *mask = con->con_out->used_mask; > > - return sysfs_emit(buf, "%*pbl\n", cfg->nr_trig_max, &mask); > + return sysfs_emit(buf, "%*pbl\n", cfg->nr_trig_max, mask); > } > > /* convert a sig type id to a name */ > diff --git a/drivers/hwtracing/coresight/coresight-cti.h b/drivers/hwtracing/coresight/coresight-cti.h > index c5f9e79fabc6..ef079fc18b72 100644 > --- a/drivers/hwtracing/coresight/coresight-cti.h > +++ b/drivers/hwtracing/coresight/coresight-cti.h > @@ -68,7 +68,7 @@ struct fwnode_handle; > */ > struct cti_trig_grp { > int nr_sigs; > - u32 used_mask; > + unsigned long *used_mask; > int sig_types[]; > }; > > @@ -145,17 +145,17 @@ struct cti_config { > int enable_req_count; > > /* registered triggers and filtering */ > - u32 trig_in_use; > - u32 trig_out_use; > - u32 trig_out_filter; > + unsigned long *trig_in_use; > + unsigned long *trig_out_use; > + unsigned long *trig_out_filter; > bool trig_filter_enable; > u8 xtrig_rchan_sel; > > /* cti cross trig programmable regs */ > u32 ctiappset; > u8 ctiinout_sel; > - u32 ctiinen[CTIINOUTEN_MAX]; > - u32 ctiouten[CTIINOUTEN_MAX]; > + u32 *ctiinen; > + u32 *ctiouten; > u32 ctigate; > u32 asicctl; > }; >

1 month, 3 weeks

Re: [PATCH v10 5/5] coresight: cti: document banked and missing base CTI sysfs registers

by Mike Leach

Reviewed-by: Mike Leach <mike.leach(a)arm.com> On 6/15/26 13:32, Yingchao Deng wrote: > Document the new sysfs entries triginstatus[1-3], trigoutstatus[1-3], > ittrigin[1-3], ittrigout[1-3], ittrigoutack[1-3] and ittriginack[1-3] > in the coresight-cti ABI documentation. > > Also document the previously undocumented base integration test > registers itctrl, itchin, itchinack, ittrigin, ittriginack, itchout, > itchoutack, ittrigout and ittrigoutack, which were introduced in > kernel version 5.7. > > Signed-off-by: Yingchao Deng <yingchao.deng(a)oss.qualcomm.com> > --- > .../ABI/testing/sysfs-bus-coresight-devices-cti | 90 ++++++++++++++++++++++ > 1 file changed, 90 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-cti b/Documentation/ABI/testing/sysfs-bus-coresight-devices-cti > index a2aef7f5a6d7..9d7831ac455b 100644 > --- a/Documentation/ABI/testing/sysfs-bus-coresight-devices-cti > +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-cti > @@ -128,12 +128,102 @@ KernelVersion: 5.7 > Contact: Mike Leach or Mathieu Poirier > Description: (Read) read current status of input trigger signals > > +What: /sys/bus/coresight/devices/<cti-name>/regs/triginstatus[1-3] > +Date: June 2026 > +KernelVersion: 7.3 > +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com> > +Description: (Read) read current status of QCOM extended input trigger signals. > + > What: /sys/bus/coresight/devices/<cti-name>/regs/trigoutstatus > Date: March 2020 > KernelVersion: 5.7 > Contact: Mike Leach or Mathieu Poirier > Description: (Read) read current status of output trigger signals. > > +What: /sys/bus/coresight/devices/<cti-name>/regs/trigoutstatus[1-3] > +Date: June 2026 > +KernelVersion: 7.3 > +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com> > +Description: (Read) read current status of QCOM extended output trigger signals. > + > +What: /sys/bus/coresight/devices/<cti-name>/regs/itctrl > +Date: March 2020 > +KernelVersion: 5.7 > +Contact: coresight(a)lists.linaro.org > +Description: (RW) Control integration mode. > + > +What: /sys/bus/coresight/devices/<cti-name>/regs/itchin > +Date: March 2020 > +KernelVersion: 5.7 > +Contact: coresight(a)lists.linaro.org > +Description: (Read) Read the values of the CTCHIN inputs. > + > +What: /sys/bus/coresight/devices/<cti-name>/regs/itchinack > +Date: March 2020 > +KernelVersion: 5.7 > +Contact: coresight(a)lists.linaro.org > +Description: (Write) Write the value of the CTCHINACK input. > + > +What: /sys/bus/coresight/devices/<cti-name>/regs/ittrigin > +Date: March 2020 > +KernelVersion: 5.7 > +Contact: coresight(a)lists.linaro.org > +Description: (Read) Read the values of the CTTRIGIN inputs. > + > +What: /sys/bus/coresight/devices/<cti-name>/regs/ittrigin[1-3] > +Date: June 2026 > +KernelVersion: 7.3 > +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com> > +Description: (Read) Read the values of the QCOM extended CTTRIGIN inputs. > + > +What: /sys/bus/coresight/devices/<cti-name>/regs/ittriginack > +Date: March 2020 > +KernelVersion: 5.7 > +Contact: coresight(a)lists.linaro.org > +Description: (Write) Write the value of the CTTRIGINACK input. > + > +What: /sys/bus/coresight/devices/<cti-name>/regs/ittriginack[1-3] > +Date: June 2026 > +KernelVersion: 7.3 > +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com> > +Description: (Write) Write the value of the QCOM extended CTTRIGINACK input. > + > +What: /sys/bus/coresight/devices/<cti-name>/regs/itchout > +Date: March 2020 > +KernelVersion: 5.7 > +Contact: coresight(a)lists.linaro.org > +Description: (RW) Read or write the value of the CTCHOUT outputs. > + > +What: /sys/bus/coresight/devices/<cti-name>/regs/itchoutack > +Date: March 2020 > +KernelVersion: 5.7 > +Contact: coresight(a)lists.linaro.org > +Description: (Read) Read the value of the CTCHOUTACK input. > + > +What: /sys/bus/coresight/devices/<cti-name>/regs/ittrigout > +Date: March 2020 > +KernelVersion: 5.7 > +Contact: coresight(a)lists.linaro.org > +Description: (RW) Read or write the value of the CTTRIGOUT outputs. > + > +What: /sys/bus/coresight/devices/<cti-name>/regs/ittrigout[1-3] > +Date: June 2026 > +KernelVersion: 7.3 > +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com> > +Description: (RW) Read or write the value of the QCOM extended CTTRIGOUT outputs. > + > +What: /sys/bus/coresight/devices/<cti-name>/regs/ittrigoutack > +Date: March 2020 > +KernelVersion: 5.7 > +Contact: coresight(a)lists.linaro.org > +Description: (Read) Read the value of the CTTRIGOUTACK input. > + > +What: /sys/bus/coresight/devices/<cti-name>/regs/ittrigoutack[1-3] > +Date: June 2026 > +KernelVersion: 7.3 > +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com> > +Description: (Read) Read the value of the QCOM extended CTTRIGOUTACK input. > + > What: /sys/bus/coresight/devices/<cti-name>/channels/trigin_attach > Date: March 2020 > KernelVersion: 5.7 >

1 month, 3 weeks

[PATCH v4 0/1] coresight: fix issue with insufficient claim tags

by Mike Leach

All CoreSight compliant components have an implementation defined number of 0 to 8 claim tag bits in the claim tag registers. These are used to claim the CoreSight resources by system agents. ARM recommends implementions have 4 claim tag bits, though a valid implementation can have 0 claim tags bits. The CoreSight drivers implement a 2 claim tag bit protocol to allow self hosted and external debug agents to manage access to the hardware. However, if there are less than 2 claim tags available the protocol incorrectly returns an error on device claim, as no checks are made. If insufficient claim tags are present in a component then the protocol must return success on claim / disclaim to allow components to be used normally. Add initialisation to read the CLAIMSET bits to establish the number of available claim tag bits, and adjust the claim returns accordingly. Cache the claimtag protocol availablity in the coresight_device to reduce reads for the main claim/disclaim api. changes since v3: 1) removed unneeded bool casts (Leo) 2) rebased to kernel 7.2 on coresight/next changes since v2: 1) consolidated API to remove the API calls using just cs_access, which were used purely to clear down stale self claim tags, replace with a normal coresight_device API for initialisation, to match the claim/disclaim API. This does both the check on availability and the stale tag clearance. Updated all drivers to use the new init functionality 2) Added option for drivers to skip claim tag checking completely for devices with no-compliant hardware, that do not implement registers at the claim tag location, or do not operate correctly to indicate the correct number of claim tags for the device. changes since v1: 1) Added claim tag availability cache into coresight_device when using the main coresight_claim_device() / coresight_disclaim_device() API. Applies to coresight/next Mike Leach (1): coresight: fix issue where coresight component has no claimtags drivers/hwtracing/coresight/coresight-catu.c | 6 +- drivers/hwtracing/coresight/coresight-core.c | 139 ++++++++++++++++-- .../hwtracing/coresight/coresight-cti-core.c | 7 +- drivers/hwtracing/coresight/coresight-etb10.c | 9 +- .../coresight/coresight-etm3x-core.c | 8 +- .../coresight/coresight-etm4x-core.c | 8 +- .../hwtracing/coresight/coresight-funnel.c | 7 +- drivers/hwtracing/coresight/coresight-priv.h | 7 + .../coresight/coresight-replicator.c | 9 +- .../hwtracing/coresight/coresight-tmc-core.c | 7 +- include/linux/coresight.h | 23 ++- 11 files changed, 205 insertions(+), 25 deletions(-) -- 2.43.0

1 month, 3 weeks

Re: [PATCH] coresight: syscfg: fix deadlock on device registration failure

by Leo Yan

On Wed, Sep 09, 2026 at 09:34:07AM +0800, yingchao deng wrote: [...] > I'll send v2 with your suggested change. Thanks a lot!

1 month, 4 weeks

Re: [PATCH] coresight: Fix clock refcount imbalance on platform probe failure

by Leo Yan

Hi Jie, Thanks for fixing! It is shame that my single patch caused issues both in driver's probe and remove - I have to admit that I don't understand runtime PM's state machine. TBC, this patch only fixes probe. The driver's remove is fixed in: https://lore.kernel.org/linux-arm-kernel/20260710-fix-clock-refcount-unbala… The series above and this patch should be picked up together so can have complete fix. > The probe wrapper then unconditionally calls pm_runtime_put() > regardless of whether the inner probe succeeded, so on failure this > also fires runtime_suspend() and disables the same clocks a first > time. pm_runtime_put() can be used for success case, but for the failure case, we should disable the runtime PM but not release reference: https://docs.kernel.org/power/runtime_pm.html#runtime-pm-initialization-dev… > @@ -632,11 +632,14 @@ static int catu_platform_probe(struct platform_device *pdev) > pm_runtime_enable(&pdev->dev); > > ret = __catu_probe(&pdev->dev, res); > - pm_runtime_put(&pdev->dev); > - if (ret) > + if (ret) { > + pm_runtime_put_noidle(&pdev->dev); > pm_runtime_disable(&pdev->dev); Nitpick: please reverse the sequence between pm_runtime_put_noidle() and pm_runtime_disable(). As we need to first disable runtime PM for the device, then release usage reference. Since the driver core will reset device's active state, AI told me that calling pm_runtime_set_suspended() is redundant. It is still good to explicitly call it for bookkeeping. This can be aligned with the change in driver remove. Thus, please update the flow: pm_runtime_disable(&pdev->dev); pm_runtime_set_suspended(dev); pm_runtime_put_noidle(&pdev->dev); With the update: Reviewed-by: Leo Yan <leo.yan(a)arm.com>

1 month, 4 weeks

Re: [PATCH] coresight: tpdm: initialize spinlock before exposing sysfs

by Leo Yan

On Tue, Aug 25, 2026 at 10:06:47AM +0800, yingchao wrote: > From: Yingchao Deng <dengyingchao(a)kylinsec.com.cn> > > tpdm_probe() initializes drvdata->spinlock after coresight_register(), but > the sysfs attributes registered by coresight_register() use the spinlock. > This exposes a window where a concurrent sysfs write can lock an > uninitialized spinlock. > > Initialize the spinlock before coresight_register(). > > Fixes: b3c71626a933 ("Coresight: Add coresight TPDM source driver") > Signed-off-by: Yingchao Deng <dengyingchao(a)kylinsec.com.cn> Reviewed-by: Leo Yan <leo.yan(a)arm.com>

1 month, 4 weeks

Re: [PATCH] coresight: syscfg: fix deadlock on device registration failure

by Leo Yan

On Tue, Aug 25, 2026 at 09:47:17AM +0800, yingchao wrote: > diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c > index 2bfdd7b45e49..d0e7e4720e46 100644 > --- a/drivers/hwtracing/coresight/coresight-syscfg.c > +++ b/drivers/hwtracing/coresight/coresight-syscfg.c > @@ -1210,8 +1210,14 @@ static int cscfg_create_device(void) > dev->init_name = "cs_system_cfg"; > > err = device_register(dev); > - if (err) > + if (err) { > + /* put_device() triggers cscfg_dev_release() which takes > + * cscfg_mutex, so drop the lock first to avoid deadlocking. > + */ > + mutex_unlock(&cscfg_mutex); > put_device(dev); > + return err; > + } As module init and exit are serialized by the kernel, I don't think we need the mutex to protect the allocation and freeing of cscfg_mgr. The mutex should only be used for exclusively access cscfg_mgr. So how about the change below? ---8<--- diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c index 2bfdd7b45e49..2dd0b29f44e4 100644 --- a/drivers/hwtracing/coresight/coresight-syscfg.c +++ b/drivers/hwtracing/coresight/coresight-syscfg.c @@ -1173,27 +1173,21 @@ struct device *cscfg_device(void) /* Must have a release function or the kernel will complain on module unload */ static void cscfg_dev_release(struct device *dev) { - mutex_lock(&cscfg_mutex); kfree(cscfg_mgr); cscfg_mgr = NULL; - mutex_unlock(&cscfg_mutex); } /* a device is needed to "own" some kernel elements such as sysfs entries. */ static int cscfg_create_device(void) { struct device *dev; - int err = -ENOMEM; - - mutex_lock(&cscfg_mutex); - if (cscfg_mgr) { - err = -EINVAL; - goto create_dev_exit_unlock; - } + int err; cscfg_mgr = kzalloc_obj(struct cscfg_manager); if (!cscfg_mgr) - goto create_dev_exit_unlock; + return -ENOMEM; + + mutex_lock(&cscfg_mutex); /* initialise the cscfg_mgr structure */ INIT_LIST_HEAD(&cscfg_mgr->csdev_desc_list); @@ -1204,6 +1198,8 @@ static int cscfg_create_device(void) cscfg_mgr->load_state = CSCFG_NONE; raw_spin_lock_init(&cscfg_mgr->sysfs_store_lock); + mutex_unlock(&cscfg_mutex); + /* setup the device */ dev = cscfg_device(); dev->release = cscfg_dev_release; @@ -1213,8 +1209,6 @@ static int cscfg_create_device(void) if (err) put_device(dev); -create_dev_exit_unlock: - mutex_unlock(&cscfg_mutex); return err; }

1 month, 4 weeks

← Newer
1
...
6
7
8
9
10
11
12
...
271
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

CoreSight