Hi Neil,
Thanks for your response. I prepared the mksh test and ran them. There were 5 failures (out of the 436 tests) as follows. Right now, I don't know if these are failures due to klibc implementation or due to problems with the way I have build mksh itself. To some extent I suspect mksh as well because (i) I could not get mksh_44 (from this link: dget http://ftp.de.debian.org/debian/pool/main/m/mksh/mksh_44-1.dsc , the link seems to be broken) but I used whatever I got ( mksh_44.orig.tar.gz , this may be missing some patches, how to get that.. ).(ii) While building mksh, encountered some compiler errors (e.g. conftest.c) but the building seemed to go fine despite these errors, so I went ahead with testing and ended up with 5 failures out of which mksh ignores 4 and didn't expect 1 as it reports.
So, do you have any idea if I am doing the right thing..? Should I worry about getting mksh build without any compiler error or warning first before attempting to use the tests..? ---------------------------------------------------------------------------------------------------------------- root@genericarmv8:~/anilss/AArch64/mksh# ./mksh test.sh -p $PWD/mksh Testing mksh for conformance: # $MirOS: src/bin/mksh/check.t,v 1.599 2013/02/24 14:22:41 tg Exp $ @(#)MIRBSD KSH R44 2013/02/24 This shell is actually: @(#)MIRBSD KSH R44 2013/02/24 test.sh built for mksh R44 2013/02/24 Trying Perl interpreter 'perl5'... test.sh[70]: perl5: not found Errorlevel 127, running on '' => not using Trying Perl interpreter 'perl'... Errorlevel 0, running on 'linux, Perl version 5.014003' => using it + perl ./check.pl -p /home/root/anilss/AArch64/mksh/mksh -C shell:legacy-no,int:32 -v -s ./check.t pass ./check.t:KSH_VERSION pass ./check.t:selftest-1 pass ./check.t:selftest-2 . . . pass ./check.t:cd-history *FAIL ./check.t:cd-pe (ignored)* Description: Check package for cd -Pe unexpected stdout - first difference: line 2, char 5 (wanted 'n', got 'l' wanted: 0=0 1=0,noread/target 2=0,noread/target/subdir now with -e: 0=0 1=0,noread/target 2=1,noread/target/subdir got: 0=0 1=0,link/target 2=0,link/target/subdir now with -e: 0=0 1=0,link/target 2=1,link/target/subdir pass ./check.t:env-prompt pass ./check.t:expand-ugly . . . pass ./check.t:glob-bad-1 *FAIL ./check.t:glob-bad-2* Description: Check that symbolic links aren't stat()'d unexpected stdout - first difference: line 2, char 2 (wanted 'i', got '*' wanted: dir/abc dir/abc got: dir/abc d*/abc pass ./check.t:glob-range-1 pass ./check.t:glob-range-2 . . . pass ./check.t:history-subst-4 pass ./check.t:history-subst-5 *FAIL ./check.t:history-ed-1 (ignored)* Description: Basic (ed) editing works (assumes you have generic ed editor that prints no prompts). This is for newish ed(1) and stderr. unexpected exit status 32512 (exit-code 127), expected 0 unexpected stdout - got too little output wanted: abc def FOOBAR def got: abc def unexpected stderr - wanted pattern: /^X*13\n16\necho FOOBAR def\nX*$/ got: XX/home/root/anilss/AArch64/mksh/mksh: /bin/ed: not found X/home/root/anilss/AArch64/mksh/mksh: <stdin>[3]: s/abc/FOOBAR/: not found X/home/root/anilss/AArch64/mksh/mksh: <stdin>[4]: w: not found X/home/root/anilss/AArch64/mksh/mksh: <stdin>[5]: q: not found X [incomplete last line] *FAIL ./check.t:history-ed-2 (ignored)* Description: Correct command is edited when number given unexpected exit status 32512 (exit-code 127), expected 0 unexpected stdout - got too little output wanted: line 1 line 2 is here line 3 line 4 line 2 is changed got: line 1 line 2 is here line 3 line 4 unexpected stderr - wanted pattern: /^X*20\n23\necho line 2 is changed\nX*$/ got: XXXXX/home/root/anilss/AArch64/mksh/mksh: /bin/ed: not found X/home/root/anilss/AArch64/mksh/mksh: <stdin>[6]: s/is: not found X/home/root/anilss/AArch64/mksh/mksh: <stdin>[7]: w: not found X/home/root/anilss/AArch64/mksh/mksh: <stdin>[8]: q: not found X [incomplete last line] *FAIL ./check.t:history-ed-3 (ignored)* Description: Newly created multi line commands show up as single command in history. unexpected stdout - first difference: line 2, char 1 (wanted 'F', got 'a' wanted: abc def FOOBAR def a new line 1 echo abc def 2 echo FOOBAR def 3 echo a new line got: abc def a new line 1 echo abc def 2 fc echo 3 s/abc/FOOBAR/ 4 $a 5 echo a new line 6 . 7 w 8 q unexpected stderr - wanted pattern: /^X*13\n32\necho FOOBAR def\necho a new line\nX*$/ got: XX/home/root/anilss/AArch64/mksh/mksh: /bin/ed: not found X/home/root/anilss/AArch64/mksh/mksh: <stdin>[3]: s/abc/FOOBAR/: not found XXX/home/root/anilss/AArch64/mksh/mksh: <stdin>[6]: .: missing argument X/home/root/anilss/AArch64/mksh/mksh: <stdin>[7]: w: not found X/home/root/anilss/AArch64/mksh/mksh: <stdin>[8]: q: not found XX [incomplete last line] pass ./check.t:IFS-space-1 pass ./check.t:IFS-colon-1 . . . pass ./check.t:command-shift pass ./check.t:duffs-device Total failed: 5 (4 ignored) (1 unexpected) Total passed: 431 root@genericarmv8:~/anilss/AArch64/mksh# --------------------------------------------------------------------------------------------------------------------------------------------
Best Regards, Anil
On 6 October 2013 02:31, Neil Williams neil.williams@linaro.org wrote:
On 5 October 2013 08:13, Anil Singhar anil.singhar@linaro.org wrote:
Hi Neil / Riku / Peter,
Thanks for your help.
Now that I have some confidence that the changes are working fine
Well done!
, is it possible for one of you to review the code..? Or could you suggest
someone
who could do that for me. The code is available at: ( git clone git://git.linaro.org/people/anil.singhar/klibc-aarch64.git )
Have you been able to run the mksh tests? Do you have results available somewhere? I never got to that stage.
I would like to implement review feedback and make it available for upstreaming this week.
Upstream will insist on seeing the test results, I'm afraid. (So rather than using the linaro.org pastebin, it would be best to put the results in your public_html directory on people.linaro.org)
--
Neil Williams
neil.williams@linaro.org http://www.linux.codehelp.co.uk/