Hey all,
After my chat with Leif chat on Thurs, one thing I thought about was
bash completion for uefi-build.sh.
Turns out it's quite easy! I just pushed this commit to
uefi-tools.git [1]. It's quite dumb in that you can autocomplete
"DEBUG" or "RELEASE" even without the "-b" parameter, but hey, it
makes my life easier :-)
Cheers,
Ryan.
commit dc3ba99d46ecb87c529a475d5ff6b840cd2f7c8d
Author: Ryan Harkin <ryan.harkin(a)linaro.org>
Date: Tue Jun 11 13:00:12 2013 +0100
uefi-build: add bash completion script
Copy this script into the bash completion directory to easy entering
parameters:
$ sudo cp uefi-build.sh.bash_completion \
/etc/bash_completion.d/uefi-build.sh
Signed-off-by: Ryan Harkin <ryan.harkin(a)linaro.org>
diff --git a/uefi-build.sh.bash_completion b/uefi-build.sh.bash_completion
new file mode 100644
index 0000000..f0a5305
--- /dev/null
+++ b/uefi-build.sh.bash_completion
@@ -0,0 +1,24 @@
+# bash completion for uefi-build.sh
+# copy this file to /etc/bash_completion.d/uefi-build.s
+
+have uefi-build.sh &&
+_uefi-build.sh()
+{
+ local cur prev
+
+ COMPREPLY=()
+ _get_comp_words_by_ref -n = cur
+
+ _expand || return 0
+
+ COMPREPLY=( $( compgen -W '--help -b --build RELEASE DEBUG a5 a9
tc1 tc2 panda origen arndale rtsm_a9x4 rtsm_a15x1 rtsm_a15mpcore
rtsm_aarch6
+} &&
+complete -F _uefi-build.sh uefi-build.sh
+
+# Local variables:
+# mode: shell-script
+# sh-basic-offset: 4
+# sh-indent-comment: t
+# indent-tabs-mode: nil
+# End:
+# ex: ts=4 sw=4 et filetype=sh
[1] http://git.linaro.org/gitweb?p=arm/uefi/uefi-tools.git;a=summary
[PATCH 1/2] TC1: Fix TC1 build for latest upstream changes
[PATCH 2/2] VEA5: Fix A5 build for latest upstream changes
The two platforms are relatively simple to fix because they follow the
TC2 and A9 BSPs very closely. Perhaps close enough to some more code
to be moved to common areas ;-)
These examples will show you the simple steps you will need to take to
get your BSP working.
However, your BSP may be using old functionality that my BSPs were not.
The main change to watch out for is the deletion of the macro
IS_PRIMARY_CORE() which has been replaced with a function that the BSP
must provide. The change came about with this commit:
--------------------------------------------------------------------------------
commit bebda7ceec3d3024c76b3c2ed0c9b4e502a13d61
Author: oliviermartin <oliviermartin@6f19259b-4bc3-4df7-8a09-765794883524>
Date: Fri May 10 12:41:27 2013 +0000
ArmPlatformPkg/ArmPlatformLib: Added support for ArmPlatformIsPrimaryCore()
Checking if a core if the primary/boot core used to be done with the macro
IS_PRIMARY_CORE().
Some platforms exposes configuration registers to change the primary core.
Replacing the macro IS_PRIMARY_CORE() by ArmPlatformIsPrimaryCore() allows
some flexibility in the way to check the primary core.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin(a)arm.com>
Reviewed-by: Leif Lindholm <leif.lindholm(a)linaro.org>
Acked-by: Ryan Harkin <ryan.harkin(a)linaro.org>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14344 6f19259b-4bc3-4df7-8a09-765794883524
--------------------------------------------------------------------------------
My examples provide this function in a way that works for them, however,
your platforms may use different mechanisms. I have no specific code
that was using the IS_PRIMARY_CORE() macro, so these patches will not
give an example of how you deal with those changes, but Olivier's
original patch should help a lot there.
Regards,
Ryan.
[1] https://git.linaro.org/gitweb?p=arm/uefi/uefi-next.git;a=summary
Hello UEFI folks,
I spent the day with Leif going through maintainer stuff and together
we produced the 2013.06 iteration of the Linaro UEFI tree [1].
Highlights include:
- A5, TC1, Panda, Origen and Arndale no longer build
(I will be fixing A5 and TC1 as part of -rc2, unless something
else urgent comes in and needs an -rc2)
- The -menu and -local-fdt topics have been merged into one -bds topic
to simplify upstreaming, reviewing and merging
- All topics are rebased to the latest Tianocore upstream code
- Some of our patches have made it upstream - yay! - and thus have
been removed from our topic branches
- There are more patches that we think are ready to go upstream now.
I'll start this after -rc2
Regards,
Ryan.
[1] https://git.linaro.org/gitweb?p=arm/uefi/uefi-next.git;a=summary
Hi Ryan,
Thanks for the patch system and I will follow the
same methodology.
BR,
Steve
On 4 June 2013 10:50, Ryan Harkin <ryan.harkin(a)linaro.org> wrote:
> Hi Steve,
>
> Further to our phone call, I pushed out my patch system git repo:
>
> ssh://
> linaro-private.git.linaro.org/srv/linaro-private.git.linaro.org/uefi/patche…
>
> Hope it helps!
>
> Cheers,
> Ryan.
>
> On 3 June 2013 16:23, Steven Kinney <steven.kinney(a)linaro.org> wrote:
> > Hi Ryan,
> >
> > I am focusing on maintainer tasks today and tomorrow;
> > before I start on 64-bit SCT integration. I talked to Grant on my
> one-on-one
> > Friday and he suggested applying the patches within a local repository,
> > maybe within my git.linaro.org folder, and working with you regarding
> > merging and other GIT tasks. Of course, if you have ant suggestions to
> > start getting me up so that I can be more of use to you, please let me
> know.
> > Also, Grant wanted me to start giving suggestions regarding the coding,
> and
> > I see some areas that can be commented on, but I would like to make sure
> we
> > are in sync before I start yammering on commented out code blocks and
> such.
> >
> > Anyway, I look forward to learning about this area and
> > will ping you from time to time over the next few days to get some
> specific
> > advice. Thanks for you patience and help!
> >
> > BR,
> >
> > Steve
>