- boot-architecture - lists.linaro.org

Re: [edk2] ARM UEFI BIOS & Trusted firmware (SMM / Trustzone similitudes)

by Andrew fish

Eugene and I usually attend, and it is Andrew Sloss running it on the ARM side. Sent from my iPhone > On Dec 6, 2013, at 2:14 PM, "Pant, Alok" <Alok.Pant(a)amd.com> wrote: > > >>. But as suggested Eugene, a discussion can be started in the UEFI Forum working groups. ABST (ARM Binding Sub-Team) might be a good place to get the initial feedbacks. > Hi Olivier, > Thanks. Would you be able to bring this to ABST? Or what do you suggest the next steps? > > From: Olivier Martin [mailto:olivier.martin@arm.com] > Sent: Friday, December 06, 2013 2:05 PM > To: Pant, Alok; Cohen, Eugene; 'Tim Lewis'; edk2-devel(a)lists.sourceforge.net > Cc: boot-architecture(a)lists.linaro.org > Subject: RE: ARM UEFI BIOS & Trusted firmware (SMM / Trustzone similitudes) > > I have not necessary got the background and the full picture of the industry in term of production firmware compare to some of you. But I have tried to give some answers to your questions. > > # Alok, two directions for Secure Monitor implementation? > The ARM recommendation is everything concerning secure world (EL3, Secure-EL1, Secure-EL0) should be implemented as part of the Trusted Firmware project. > ArmPlatformPkg/Sec has been ported to AArch64 as a temporary solution while waiting for an appropriate Trusted Firmware implementation. There is no plan to have a Secure Monitor implementation (BL31) in Tianocore project. > And I will not accept any patch that implements such feature in Tianocore. The reason is I do not think it is good thing to duplicate code between both projects supported by ARM. And the Trusted Firmware project is a better place for such features. > > # Alok, some implementation starts the Trusted Firmware (in EL3) that launches SEC in El1/2 mode > ArmPlatformPkg/Sec should not run in EL2/EL1. As I said earlier, this is only a temporary solution that should be replaced by the Trusted Firmware project on most ARMv8 platforms. > The Trusted Firmware should launch UEFI that starts with either ArmPlatformPkg/PrePeiCore (if the UEFI firmware in XIP ROM) or ArmPlatformPkg/PrePi (if the UEFI firmware is started from DRAM). > > # Alok, Should secure monitor (bl31) be launched before or during SEC phase? > Secure Monitor (BL31) is one of the first components loaded by the Trusted Firmware. The Secure Monitor will be available before the UEFI firmware starts. > > # Alok/Eugene, Extending the PI SMM specification (Volume 4) for Trustzone > I had a look at the SMM PI spec. I can see a lot of similitude to the UEFI spec (an architecture and implementation agnostic interface). > I can also see some similitude between SMM and Trustzone technology (based on the ARM Secure Extension). And I am sure some SMM drivers will be ported to ARM Secure components (eg: authentification variable for secure boot). > > One notable difference between SMM and ‘Trustzone’ is the initialization. SMM seems to be initialized during the DXE phase while the ARM Secure/Trusted environment is initialized prior to start the Non Secure/Non Trusted environment (including UEFI, u-boot bootloaders). And I do not see this initialization phase to be changed for the reason that the secure environment (Trusted Firmware, Trusted OS, SiP/ODM/OEM secure components) will setup the appropriate hardware privileges and initialize their environment prior to switch to the Non-Secure environment. > > The concept of ‘extending the PI SMM spec to Trustzone’ or 'some form of SMM foundation glue code' is interesting. But it might be difficult to implement in the current situation (most of the solutions seem to be highly integrated without much interoperability). The level of standardization of the Secure/Trusted environment has not reached the API yet. > Obviously, to create a standard an initiative has to be started. I am probably not the best person (due to my limited knowledge of SMM and their real use cases) to start this initiative. But as suggested Eugene, a discussion can be started in the UEFI Forum working groups. ABST (ARM Binding Sub-Team) might be a good place to get the initial feedbacks. > > # Tim, What happens when the secure OS is performing a secure task, but the other OS asks for a shutdown? > As you know PSCI (Power State Coordination Interface) is recommended by ARM for OS Power Management (OSPM). In this case, the Secure world is aware of the shutdown. > But the PSCI spec says 'a Trusted OS must not rely on the use of any notification, and must be resistant to any sudden loss of context'. > Trusted OS vendors are expected to provide a Rich OS driver to invoke their services. There are probably ways to signal a Rich OS shutdown to the Trusted OS using this driver. > > Thanks, > Olivier > > > From: Pant, Alok [mailto:Alok.Pant@amd.com] > Sent: 05 December 2013 18:08 > To: edk2-devel(a)lists.sourceforge.net; Olivier Martin > Subject: RE: ARM UEFI BIOS & Trusted firmware > > Hi Tim & Eugene, > Thanks for the response. I agree current SMM foundation code gas some IA specific and there are various gotchas around SMM entry/exit (sync core , save restore etc, base protocol), however most of SMM foundation is generic and it provides a nice framework of independent driver and interaction via protocol and use common services; granted the DXE SMMipl role of launching and building initial SMM environment does not mesh well on ARM. In parallel there is separate work on ARM trusted firmware and seems there is no common ground between two. I am very must interested to hear how others are attempting to address such feature porting issue and the direction from industry toward runtime EL3 support (single monolithic TF binary+some proprietary form of RTOS “vs.” attempt to integrate UEFI SMM with trusted fw core). I am sure I am not the first one stumbling on this question and seeking how others attempted to solve the above and if this a broader issue that need to be further discussed in this forum. > > Thanks > -Alok > > > > From: Tim Lewis [mailto:tim.lewis@insyde.com] > Sent: Thursday, December 05, 2013 11:39 AM > To: edk2-devel(a)lists.sourceforge.net; olivier.martin(a)arm.com > Subject: Re: [edk2] ARM UEFI BIOS & Trusted firmware > > Eugene – > > One of the issues for the SMM specification and TZ is the single-threaded nature. While most of ARM’s TrustZone infrastructure can be mapped easily to SMM, the possibility of having cores in TZ and out of TZ simultaneously, or more than one core in TZ at the same time raises some interesting issues (resource contention, etc.) > > Tim > > From: Cohen, Eugene [mailto:eugene@hp.com] > Sent: Thursday, December 05, 2013 9:29 AM > To: edk2-devel(a)lists.sourceforge.net; olivier.martin(a)arm.com > Subject: Re: [edk2] ARM UEFI BIOS & Trusted firmware > > Alok, > > I agree -- there is value in the modular nature of the PI component approach extending to the ARM trusted firmware environment. > > For SMM this is supported in the PI spec’s SMM core interface specification and in edk2 by the PiSmmCore module and accompanying libraries. Unlike DXE and PEI, the SMM core, at least in name, is IA-specific as it refers to SMM, SMIs, SMRAM, etc. When you look past the names though you can see that the functions it is providing is really architecture independent -- IO protocols, secure memory allocation, protocol management, and handler registration. Given the current IA-specific naming, it would be difficult to recommend that ARM should simply adopt the “SMM” core architecture for the TZ/EL3/SecureMonitor implementation. > > Perhaps this should be raised in the PI working group, specifically “is the SMM core interface spec really an IA-specific concept or something that should become architecture agnostic?” > > Eugene > > From: Pant, Alok [mailto:Alok.Pant@amd.com] > Sent: Thursday, December 05, 2013 8:42 AM > To: edk2-devel(a)lists.sourceforge.net; olivier.martin(a)arm.com > Subject: [edk2] ARM UEFI BIOS & Trusted firmware > > Changing topic.. > > Hi Oliver, Thanks. I also I have few separate questions wrt to Trusted firmware & UEFI ARM code and hope you/others can help answer > > · It seems there are two direction for SecureMonitor implementation. In one implementation the SEC code (ArmPlatformPkg\Sec\Sec.c) install the secure monitor ( when SEC start in El3) ; In other implementation the Trusted firmware start first install secure monitor (bl31) and launch SEC in El1/2 mode. My question is what is the preferred direction when both are possible? Should secure monitor (bl31) be launched before or during SEC phase? > · Historically in x86 implementation the SMM mode hosts various runtime platform BIOS driver for feature such as authentication variable (for secure boot), platform runtime handing handling etc. EDKII has a good framework for SMM kernel and loading various independent SMM driver and interaction among those driver via protocol etc. In ARM based UEFI/Trusted firmware implementation what may be preferred way to deal with such need. Should all those UEFI SMM driver be ported to Trusted firmware which "today" is in primitive framework compare to SMM EDKII foundation code, or some form of SMM foundation can gel with trusted firmware design to allow independent platform el3 code be developed at independent driver. Curious how others have attempted to solve this problem and if there can be standard way for all of us to adopt here. Before creating yet another method I was hoping to hear from experts on any common ground for such feature implementation > > Thanks again for all your help and comments > -Alok > > -----Original Message----- > From: Olivier Martin [mailto:olivier.martin@arm.com] > Sent: Wednesday, December 04, 2013 7:40 AM > To: TigerLiu(a)viatech.com.cn; edk2-devel(a)lists.sourceforge.net > Subject: Re: [edk2] SEC code support big.LITTLE tech? > > Hi Tiger, > > The ARM recommendation to manage secondary CPUs (the primary CPU is the CPU that runs UEFI and starts your OS kernel) is to use PSCI (Power State Coordination Interface - http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.den0022b/index.h > tml). > PSCI uses SMCs (Secure Memory Calls) to bring up secondary CPUs (CPU_UP / CPU_DOWN). This code runs in Secure World while UEFI runs in Non-Secure World. > > For the story... I started to implement PSCI support in Tianocore source code (in ArmPlatformPkg/Sec). But the EDK2 framework (PCD/Library/INF/FDF > etc) had made the code quite hard to maintain. > So, I wrote a new secure firmware framework project to handle this support. > This firmware is not Open Source (available in binary format for TC2 only). > A new project has been started by ARM Ltd last month. It is an Open Source implementation of the Trusted/Secure Firmware: > https://github.com/ARM-software/arm-trusted-firmware > Unfortunately at this stage, 32bit is not supported (only AArch64 is supported). And as far as I know there is no plan to add 32bit support by ARM Ltd in the short term. > > The current ArmPlatformPkg/Sec has support to hold the secondary cores in WFI. But it does not support PSCI. The current support might be sufficient enough for you at this stage. > > Thanks, > Olivier > > > -----Original Message----- > > From: TigerLiu(a)viatech.com.cn [mailto:TigerLiu@viatech.com.cn] > > Sent: 04 December 2013 01:51 > > To: edk2-devel(a)lists.sourceforge.net > > Cc: Olivier Martin > > Subject: [edk2] SEC code support big.LITTLE tech? > > > > Hi, Oliver: > > Does current ArmPlatformPackage's sec code support big.LITTLE tech? > > Such as : > > An ARM SOC --- with 4 Cores Cortex-A15, 4 Cores Cortex-A7 > > > > So, if sec code support big.LITTLE tech, how does it let one core as > > boot strap cpu, others go into wfe(or other sleeping state)? > > > > Best wishes, > > > > > > ------------------------------------------------------------------------------ > Sponsored by Intel(R) XDK > Develop, test and display web and hybrid apps with a single code base. > Download it for free now! > http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk > _______________________________________________ > edk2-devel mailing list > edk2-devel(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel > > > ------------------------------------------------------------------------------ > Sponsored by Intel(R) XDK > Develop, test and display web and hybrid apps with a single code base. > Download it for free now! > http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk > _______________________________________________ > edk2-devel mailing list > edk2-devel(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel

12 years, 1 month

1
0
0 0

RE: ARM UEFI BIOS & Trusted firmware (SMM / Trustzone similitudes)

by Olivier Martin

I have not necessary got the background and the full picture of the industry in term of production firmware compare to some of you. But I have tried to give some answers to your questions. # Alok, two directions for Secure Monitor implementation? The ARM recommendation is everything concerning secure world (EL3, Secure-EL1, Secure-EL0) should be implemented as part of the Trusted Firmware project. ArmPlatformPkg/Sec has been ported to AArch64 as a temporary solution while waiting for an appropriate Trusted Firmware implementation. There is no plan to have a Secure Monitor implementation (BL31) in Tianocore project. And I will not accept any patch that implements such feature in Tianocore. The reason is I do not think it is good thing to duplicate code between both projects supported by ARM. And the Trusted Firmware project is a better place for such features. # Alok, some implementation starts the Trusted Firmware (in EL3) that launches SEC in El1/2 mode ArmPlatformPkg/Sec should not run in EL2/EL1. As I said earlier, this is only a temporary solution that should be replaced by the Trusted Firmware project on most ARMv8 platforms. The Trusted Firmware should launch UEFI that starts with either ArmPlatformPkg/PrePeiCore (if the UEFI firmware in XIP ROM) or ArmPlatformPkg/PrePi (if the UEFI firmware is started from DRAM). # Alok, Should secure monitor (bl31) be launched before or during SEC phase? Secure Monitor (BL31) is one of the first components loaded by the Trusted Firmware. The Secure Monitor will be available before the UEFI firmware starts. # Alok/Eugene, Extending the PI SMM specification (Volume 4) for Trustzone I had a look at the SMM PI spec. I can see a lot of similitude to the UEFI spec (an architecture and implementation agnostic interface). I can also see some similitude between SMM and Trustzone technology (based on the ARM Secure Extension). And I am sure some SMM drivers will be ported to ARM Secure components (eg: authentification variable for secure boot). One notable difference between SMM and 'Trustzone' is the initialization. SMM seems to be initialized during the DXE phase while the ARM Secure/Trusted environment is initialized prior to start the Non Secure/Non Trusted environment (including UEFI, u-boot bootloaders). And I do not see this initialization phase to be changed for the reason that the secure environment (Trusted Firmware, Trusted OS, SiP/ODM/OEM secure components) will setup the appropriate hardware privileges and initialize their environment prior to switch to the Non-Secure environment. The concept of 'extending the PI SMM spec to Trustzone' or 'some form of SMM foundation glue code' is interesting. But it might be difficult to implement in the current situation (most of the solutions seem to be highly integrated without much interoperability). The level of standardization of the Secure/Trusted environment has not reached the API yet. Obviously, to create a standard an initiative has to be started. I am probably not the best person (due to my limited knowledge of SMM and their real use cases) to start this initiative. But as suggested Eugene, a discussion can be started in the UEFI Forum working groups. ABST (ARM Binding Sub-Team) might be a good place to get the initial feedbacks. # Tim, What happens when the secure OS is performing a secure task, but the other OS asks for a shutdown? As you know PSCI (Power State Coordination Interface) is recommended by ARM for OS Power Management (OSPM). In this case, the Secure world is aware of the shutdown. But the PSCI spec says 'a Trusted OS must not rely on the use of any notification, and must be resistant to any sudden loss of context'. Trusted OS vendors are expected to provide a Rich OS driver to invoke their services. There are probably ways to signal a Rich OS shutdown to the Trusted OS using this driver. Thanks, Olivier From: Pant, Alok [mailto:Alok.Pant@amd.com] Sent: 05 December 2013 18:08 To: edk2-devel(a)lists.sourceforge.net; Olivier Martin Subject: RE: ARM UEFI BIOS & Trusted firmware Hi Tim & Eugene, Thanks for the response. I agree current SMM foundation code gas some IA specific and there are various gotchas around SMM entry/exit (sync core , save restore etc, base protocol), however most of SMM foundation is generic and it provides a nice framework of independent driver and interaction via protocol and use common services; granted the DXE SMMipl role of launching and building initial SMM environment does not mesh well on ARM. In parallel there is separate work on ARM trusted firmware and seems there is no common ground between two. I am very must interested to hear how others are attempting to address such feature porting issue and the direction from industry toward runtime EL3 support (single monolithic TF binary+some proprietary form of RTOS "vs." attempt to integrate UEFI SMM with trusted fw core). I am sure I am not the first one stumbling on this question and seeking how others attempted to solve the above and if this a broader issue that need to be further discussed in this forum. Thanks -Alok From: Tim Lewis [mailto:tim.lewis@insyde.com] Sent: Thursday, December 05, 2013 11:39 AM To: edk2-devel(a)lists.sourceforge.net; olivier.martin(a)arm.com Subject: Re: [edk2] ARM UEFI BIOS & Trusted firmware Eugene - One of the issues for the SMM specification and TZ is the single-threaded nature. While most of ARM's TrustZone infrastructure can be mapped easily to SMM, the possibility of having cores in TZ and out of TZ simultaneously, or more than one core in TZ at the same time raises some interesting issues (resource contention, etc.) Tim From: Cohen, Eugene [mailto:eugene@hp.com] Sent: Thursday, December 05, 2013 9:29 AM To: edk2-devel(a)lists.sourceforge.net; olivier.martin(a)arm.com Subject: Re: [edk2] ARM UEFI BIOS & Trusted firmware Alok, I agree -- there is value in the modular nature of the PI component approach extending to the ARM trusted firmware environment. For SMM this is supported in the PI spec's SMM core interface specification and in edk2 by the PiSmmCore module and accompanying libraries. Unlike DXE and PEI, the SMM core, at least in name, is IA-specific as it refers to SMM, SMIs, SMRAM, etc. When you look past the names though you can see that the functions it is providing is really architecture independent -- IO protocols, secure memory allocation, protocol management, and handler registration. Given the current IA-specific naming, it would be difficult to recommend that ARM should simply adopt the "SMM" core architecture for the TZ/EL3/SecureMonitor implementation. Perhaps this should be raised in the PI working group, specifically "is the SMM core interface spec really an IA-specific concept or something that should become architecture agnostic?" Eugene From: Pant, Alok [mailto:Alok.Pant@amd.com] Sent: Thursday, December 05, 2013 8:42 AM To: edk2-devel(a)lists.sourceforge.net; olivier.martin(a)arm.com Subject: [edk2] ARM UEFI BIOS & Trusted firmware Changing topic.. Hi Oliver, Thanks. I also I have few separate questions wrt to Trusted firmware & UEFI ARM code and hope you/others can help answer . It seems there are two direction for SecureMonitor implementation. In one implementation the SEC code (ArmPlatformPkg\Sec\Sec.c) install the secure monitor ( when SEC start in El3) ; In other implementation the Trusted firmware start first install secure monitor (bl31) and launch SEC in El1/2 mode. My question is what is the preferred direction when both are possible? Should secure monitor (bl31) be launched before or during SEC phase? . Historically in x86 implementation the SMM mode hosts various runtime platform BIOS driver for feature such as authentication variable (for secure boot), platform runtime handing handling etc. EDKII has a good framework for SMM kernel and loading various independent SMM driver and interaction among those driver via protocol etc. In ARM based UEFI/Trusted firmware implementation what may be preferred way to deal with such need. Should all those UEFI SMM driver be ported to Trusted firmware which "today" is in primitive framework compare to SMM EDKII foundation code, or some form of SMM foundation can gel with trusted firmware design to allow independent platform el3 code be developed at independent driver. Curious how others have attempted to solve this problem and if there can be standard way for all of us to adopt here. Before creating yet another method I was hoping to hear from experts on any common ground for such feature implementation Thanks again for all your help and comments -Alok -----Original Message----- From: Olivier Martin [mailto:olivier.martin@arm.com] Sent: Wednesday, December 04, 2013 7:40 AM To: TigerLiu(a)viatech.com.cn; edk2-devel(a)lists.sourceforge.net Subject: Re: [edk2] SEC code support big.LITTLE tech? Hi Tiger, The ARM recommendation to manage secondary CPUs (the primary CPU is the CPU that runs UEFI and starts your OS kernel) is to use PSCI (Power State Coordination Interface - http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.den0022b/index.h tml). PSCI uses SMCs (Secure Memory Calls) to bring up secondary CPUs (CPU_UP / CPU_DOWN). This code runs in Secure World while UEFI runs in Non-Secure World. For the story... I started to implement PSCI support in Tianocore source code (in ArmPlatformPkg/Sec). But the EDK2 framework (PCD/Library/INF/FDF etc) had made the code quite hard to maintain. So, I wrote a new secure firmware framework project to handle this support. This firmware is not Open Source (available in binary format for TC2 only). A new project has been started by ARM Ltd last month. It is an Open Source implementation of the Trusted/Secure Firmware: https://github.com/ARM-software/arm-trusted-firmware Unfortunately at this stage, 32bit is not supported (only AArch64 is supported). And as far as I know there is no plan to add 32bit support by ARM Ltd in the short term. The current ArmPlatformPkg/Sec has support to hold the secondary cores in WFI. But it does not support PSCI. The current support might be sufficient enough for you at this stage. Thanks, Olivier > -----Original Message----- > From: TigerLiu(a)viatech.com.cn [mailto:TigerLiu@viatech.com.cn] > Sent: 04 December 2013 01:51 > To: edk2-devel(a)lists.sourceforge.net > Cc: Olivier Martin > Subject: [edk2] SEC code support big.LITTLE tech? > > Hi, Oliver: > Does current ArmPlatformPackage's sec code support big.LITTLE tech? > Such as : > An ARM SOC --- with 4 Cores Cortex-A15, 4 Cores Cortex-A7 > > So, if sec code support big.LITTLE tech, how does it let one core as > boot strap cpu, others go into wfe(or other sleeping state)? > > Best wishes, ---------------------------------------------------------------------------- -- Sponsored by Intel(R) XDK Develop, test and display web and hybrid apps with a single code base. Download it for free now! http://pubads.g.doubleclick.net/gampad/clk?id=111408631 <http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktr k> &iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel(a)lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel

12 years, 1 month

1
0
0 0

Re: ARM/BDS: skip initrd if not found

by Ryan Harkin

On 26 November 2013 11:43, Olivier Martin <olivier.martin(a)arm.com> wrote: > Hi Ryan/Leif, > > > > I was initially happy enough with the solution #4 and wanted to push your > change to SVN. And yes, I can only be agree on the fact the EFI stub is the > way we want to go to boot Linux kernel on a UEFI system. > > But I am not sure how the EFI stub will solve your problem. > > Even with the EFI stub, you will still need to change you Continuous > Integration Infrastructure to start the Linux kernel with different > parameters for Android/Ubuntu/OpenEmbedded > > > > So, it looks the only solution is #1. > > I do not mind to push your patch, but that will not help you in the future > neither. > I don't think ARM/BDS (and this patch) will be at all related to how the boards are booted by whatever LEG use in the future. I think the intention is that LEG provide something to *replace* ARM/BDS, not something that uses it. So I guess my patch is only relevant for those who use ARM/BDS. > > > Thanks, > > Olivier > > > > > > From: Ryan Harkin [mailto:ryan.harkin@linaro.org] > Sent: 19 November 2013 11:23 > To: Leif Lindholm > Cc: boot-architecture(a)lists.linaro.org; edk2-devel(a)lists.sourceforge.net; > Olivier Martin; Steven Kinney > Subject: Re: ARM/BDS: skip initrd if not found > > > > > > > > On 19 November 2013 10:34, Leif Lindholm <leif.lindholm(a)linaro.org> wrote: > > Hi Ryan, > > > On Tue, Nov 19, 2013 at 08:30:25AM +0000, Ryan Harkin wrote: > > Hi Olivier/Steve/Leif/whoever is interested, > > > > I have a problem I'm trying to solve and I don't think there is a proper > > solution using the current ARM BDS. > > > > > Basically, some of Linaro's releases are failing to boot "out of the > > box" due to incorrect default BDS config. The default assumes that > the > > > image has an initrd. > > > > Android (the main focus of our releases) and Ubuntu images use an initrd. > > OpenEmbedded images do not. > > > > I'd like a single UEFI binary that can work on all three without > > reconfiguration. > > > > The obvious solutions are: > > 1) there is no default config that always works and the user should > configure > > the board > > themselves each time they want to boot a different image type. > > Our LAVA automated test environment and people like myself who boot > test > > many images > > daily don't favour this option. > > > > 2) change OpenEmbedded to use an initrd > > It's not my image to change and the owners don't want to do that > because > > it's also wrong. > > > > 3) Have different UEFI binaries for each image type > > This isn't ideal because I (and LAVA) would be forever reflashing > UEFI. > > > > 4) Make BDS continue if it can't load the initrd > > This isn't ideal because if there is no initrd, it could be for a bad > > reason. By continuing, we > > aren't giving the user the change to immediately correct the config. > > However, the likelihood of the initrd being completely missing, whilst > a > > valid kernel and FDT > > is provided seems slim. If it is missing, it's most likely on > purpose. > > > > Of the options above, I prefer #4 and have provided a patch below for > > discussion. I suspect that if it's not going to cause other problems, it > could > > be like my other BDS hacks, fixes and improvements and only live in the > Linaro > > tree, which would be fine with me too. > > > > Opinions on a way forward and/or this patch? > > Medium-term, I would say that the correct thing to do will be to simply > use the UEFI stub loader version of the kernel image. But you may not > want to take on the tediousness of having to sync this not-yet-upstream > patchset across the various kernel branches things will build from for > each new release until this code does go upstream? > > > > I agree, moving to a proper boot solution is the end goal. But a lot of > that end-goal is out of my control/domain, so I'm hacking what I have to > make it more usable until the cool stuff hits mainline. > > > > I would say that the solution your patch introduces is wrong, but it is > less wrong than the current situation - so I have no fundamental > objection. > > > > I agree, it's not ideal, but as you say, it's less wrong. > > > > If we wanted to keep the built-in Linux loader, I would say that the > correct fix would be to add a "has initrd" property, or a NULL string > chack for the path. But we don't, so we shouldn't spend time trying to > to improve a way too old stop-gap solution. > > > > The initrd can be configured out in the default config, so UEFI does not > attempt to even load it. However, in that case, a single UEFI binary's > default config will fail to load an Android or Ubuntu image, because they > need an initrd. > > Really, I'm working around the fact that we cannot provide a config to BDS; > the config either has to be initialised by the UEFI binary or hand edited > by > the user. If we had that feature, each image (Android, Ubuntu, OE) could > provide a config that it knew would work. > > > > > / > Leif > > p.s. > The built-in Linux loader delenda est! > > > > Yes please :-) > > > _______________________________________________ > boot-architecture mailing list > boot-architecture(a)lists.linaro.org > http://lists.linaro.org/mailman/listinfo/boot-architecture >

12 years, 1 month

2
2
0 0

ARM/BDS: skip initrd if not found

by Ryan Harkin

Hi Olivier/Steve/Leif/whoever is interested, I have a problem I'm trying to solve and I don't think there is a proper solution using the current ARM BDS. Basically, some of Linaro's releases are failing to boot "out of the box" due to incorrect default BDS config. The default assumes that the image has an initrd. Android (the main focus of our releases) and Ubuntu images use an initrd. OpenEmbedded images do not. I'd like a single UEFI binary that can work on all three without reconfiguration. The obvious solutions are: 1) there is no default config that always works and the user should configure the board themselves each time they want to boot a different image type. Our LAVA automated test environment and people like myself who boot test many images daily don't favour this option. 2) change OpenEmbedded to use an initrd It's not my image to change and the owners don't want to do that because it's also wrong. 3) Have different UEFI binaries for each image type This isn't ideal because I (and LAVA) would be forever reflashing UEFI. 4) Make BDS continue if it can't load the initrd This isn't ideal because if there is no initrd, it could be for a bad reason. By continuing, we aren't giving the user the change to immediately correct the config. However, the likelihood of the initrd being completely missing, whilst a valid kernel and FDT is provided seems slim. If it is missing, it's most likely on purpose. Of the options above, I prefer #4 and have provided a patch below for discussion. I suspect that if it's not going to cause other problems, it could be like my other BDS hacks, fixes and improvements and only live in the Linaro tree, which would be fine with me too. Opinions on a way forward and/or this patch? Regards, Ryan. note: the patch looks a little larger than it should because I had to indent the section beginning with the comment "// Check if the initrd is a uInitrd", although that section is unmodified otherwise. >From aaec8cb3f386a9a128f57a2d0fcbb4396a101ec4 Mon Sep 17 00:00:00 2001 From: Ryan Harkin <ryan.harkin(a)linaro.org> Date: Tue, 19 Nov 2013 08:10:00 +0000 Subject: [PATCH] ARM/BDS: skip initrd if not found When loading a Linux image, if the initrd is not found, we will display an error, but attempt to load the kernel anyway. Previous behaviour dropped the user back to the menu, thus allowing them to update the config. However, this does not suit booting in automated environments where test images may or may not have an initrd. Example, Ubuntu and Android images require an initrd; OpenEmbedded images do not. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ryan Harkin <ryan.harkin(a)linaro.org> --- ArmPkg/Library/BdsLib/Arm/BdsLinuxLoader.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/ArmPkg/Library/BdsLib/Arm/BdsLinuxLoader.c b/ArmPkg/Library/BdsLib/Arm/BdsLinuxLoader.c index d0eb075..d2a161a 100644 --- a/ArmPkg/Library/BdsLib/Arm/BdsLinuxLoader.c +++ b/ArmPkg/Library/BdsLib/Arm/BdsLinuxLoader.c @@ -258,19 +258,20 @@ BdsBootLinuxFdt ( Status = BdsLoadImage (InitrdDevicePath, AllocateAnyPages, &InitrdImageBase, &InitrdImageBaseSize); } if (EFI_ERROR(Status)) { - Print (L"ERROR: Did not find initrd image.\n"); - goto EXIT_FREE_LINUX; - } - - // Check if the initrd is a uInitrd - if (*(UINT32*)((UINTN)InitrdImageBase) == LINUX_UIMAGE_SIGNATURE) { - // Skip the 64-byte image header - InitrdImage = (EFI_PHYSICAL_ADDRESS)((UINTN)InitrdImageBase + 64); - InitrdImageSize = InitrdImageBaseSize - 64; - } else { - InitrdImage = InitrdImageBase; - InitrdImageSize = InitrdImageBaseSize; + Print (L"ERROR: Did not find initrd image, you may need to update your config. Attempting to continue without it.\n"); + InitrdImageBase = 0; } + else { + // Check if the initrd is a uInitrd + if (*(UINT32*)((UINTN)InitrdImageBase) == LINUX_UIMAGE_SIGNATURE) { + // Skip the 64-byte image header + InitrdImage = (EFI_PHYSICAL_ADDRESS)((UINTN)InitrdImageBase + 64); + InitrdImageSize = InitrdImageBaseSize - 64; + } else { + InitrdImage = InitrdImageBase; + InitrdImageSize = InitrdImageBaseSize; + } + } } // Load the FDT binary from a device path. The FDT will be reloaded later to a more appropriate location for the Linux kernel. @@ -299,7 +300,6 @@ EXIT_FREE_INITRD: gBS->FreePages (InitrdImageBase, EFI_SIZE_TO_PAGES (InitrdImageBaseSize)); } -EXIT_FREE_LINUX: gBS->FreePages (LinuxImage, EFI_SIZE_TO_PAGES (LinuxImageSize)); return Status; -- 1.7.9.5

12 years, 1 month

3
3
0 0

SerialPrint not working in DxeServicesLib.c

by Bhupesh Sharma

Hi List, I am experiencing a Data Abort inside function 'GetSectionFromAnyFv' in file 'DxeServicesLib.c' on my ARMv7 UEFI platform. To debug the same I added some print messages like: /* Added for debugging */ CHAR8 Buffer1[100]; UINTN CharCount; CharCount = AsciiSPrint (Buffer1,sizeof (Buffer1),"Inside Func\n\r"); SerialPortWrite ((UINT8 *) Buffer1, CharCount); And also something like: SerialPrint ("Inside Func\n\r"); I have included: #include <Library/PrintLib.h> #include <Library/SerialPortLib.h> and defined: #define SerialPrint(txt) SerialPortWrite ((UINT8*)(txt), AsciiStrLen(txt)+1); I still cannot see any debug prints on the UART (placed right after the entry point of 'GetSectionFromAnyFv' function). Debugger (DS-5) suggests that the crash is inside 'GetSectionFromAnyFv' itself. I get the UEFI firmware <version xx built at xx on xx) and Data Abort Exception PC at xx prints on the console, but no prints from 'DxeServicesLib.c' Any pointers to what I may be missing here. Regards, Bhupesh

12 years, 1 month

2
1
0 0

UEFI SCT few queries

by Prabhakar Kushwaha

Hi List, I am new to UEFI and exploring about SCT. I have very basic question regarding SCT. 1) In order to use SCT in an organization, do we require any special license? 2) Looks like SCT compliance testing is only internal to an organization. We don't require to publish its details outside of the organization? 3) If anyone want to contribute to SCT test cases. Which forum/list he/she can be used? Please guide me. Regards, Prabhakar

12 years, 2 months

1
0
0 0

Re: [edk2] Debugging Sec and PI phases {Source symbols}

by Prabhakar Kushwaha

Hi Oliver, at very early stage UEFI firmware is present in DRAM. with DDR mapped from 0x90000000 size 512MB. while running source Z:\....\cmd_load_symbols.py -f (0x90001000,0x20000000) -a -v, I am getting following error Add symbols of /home/<...>/edk2/MyBuild/Board/DEBUG_ARMGCC/ARM/ArmPlatformPkg/PrePi/PeiUniCore/DEBUG/ArmPlatformPrePiUniCore.dll at 0x90001180 Warning: not possible to load symbols from /home/..../edk2/Build/MyBoard/DEBUG_ARMGCC/ARM/ArmPlatformPkg/PrePi/PeiUniCore/DEBUG/ArmPlatformPrePiUniCore.dll at 0x90001180 Note: no symbols have been found in System Memory (possible cause: the UEFI permanent memory has been installed yet) Also FDF file has following entries [FD.MyBoard_EFI] BaseAddress = 0x90001000|gArmTokenSpaceGuid.PcdFdBaseAddress #The base address of the DDR Device. Size = 0x20000000|gArmTokenSpaceGuid.PcdFdSize #The size in bytes of the DDR Device ErasePolarity = 1 BlockSize = 0x00001000 NumBlocks = 0x20000 Regards, Prabhakar On 10/23/2013 03:22 PM, Olivier Martin wrote: > To parse your FV file (embedded in your FD file), you can use > './BaseTools/BinWrappers/PosixLike/VolInfo <location of your FV file>' > > If you want to debug the early stage of your UEFI boot process, you can only > use (you do not need -m (...,...)): > source edk2/ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py -f (..,...) -a -v > > At the early stage of the boot, the UEFI firmware has not loaded its > binaries into DRAM yet. > The UEFI System Table will not be found in System Memory. > > Where your UEFI firmware lives when started? In DRAM or in Flash/ROM memory? > >> -----Original Message----- >> From: Sharma Bhupesh-B45370 [mailto:B45370@freescale.com] >> Sent: 23 October 2013 06:33 >> To: Olivier Martin; edk2-devel(a)lists.sourceforge.net; 'Andrew Fish' >> Cc: 'Kim Phillips'; boot-architecture(a)lists.linaro.org; Kushwaha >> Prabhakar-B32579 >> Subject: RE: [edk2] Debugging Sec and PI phases {Source symbols} >> >> Hi Olivier, >> >> I tried to use the DS-5 scripts, but landed in some issues, like: >> "System table not found in System Memory". >> >> It seems there is some issue with the .FD gets generated for my >> BoardPkg. >> >> I am also now trying to understand if there is some documentation/tool >> available that >> can parse my .FD and .FV files and can tell me about the sections in >> this particular output >> file. For e.g. something like 'readelf -a XXX.ELF' produces as an >> output. >> >> Also I am using the following method to build the .FD to allow >> debugging of the source >> using the DS5 scripts: >> - export EDK2_DSC, EDK2_TOOLCHAIN, EDK2_ARCH, EDK2_BUILD. >> >> - Run 'make -f ArmPlatformPkg/Scripts/Makefile' >> >> - This will generate a .FD specific to my Board Pkg in >> 'Build/Board_Pkg_Name/DEBUG_ARMGCC/..' >> >> - Load this .FD using the DS5 and then try to load source symbols >> using: >> source edk2/ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py -f (..,...) >> -m (..,...) -a >> >> - This gives me an error: >> "System table not found in System Memory". >> >> Any pointers on the above two points.. >> >> Regards, >> Bhupesh >> >>> -----Original Message----- >>> From: boot-architecture-bounces(a)lists.linaro.org [mailto:boot- >>> architecture-bounces(a)lists.linaro.org] On Behalf Of Olivier Martin >>> Sent: Tuesday, October 22, 2013 2:27 PM >>> To: edk2-devel(a)lists.sourceforge.net; 'Andrew Fish' >>> Cc: 'Kim Phillips'; boot-architecture(a)lists.linaro.org; Kushwaha >>> Prabhakar-B32579 >>> Subject: RE: [edk2] Debugging Sec and PI phases {Source symbols} >>> >>> Hi Bhupesh, >>> Yes, if you are using ARM DS-5, this is the wikipage to look at to >> setup >>> your environment to debug UEFI. Let me know if you have issue. >>> Regards, >>> Olivier >>> >>>> -----Original Message----- >>>> From: Sharma Bhupesh-B45370 [mailto:B45370@freescale.com] >>>> Sent: 22 October 2013 07:56 >>>> To: 'Andrew Fish'; 'edk2-devel(a)lists.sourceforge.net' >>>> Cc: 'Kim Phillips'; 'boot-architecture(a)lists.linaro.org'; Kushwaha >>>> Prabhakar-B32579 >>>> Subject: Re: [edk2] Debugging Sec and PI phases {Source symbols} >>>> >>>> >>>>> -----Original Message----- >>>>> From: boot-architecture-bounces(a)lists.linaro.org [mailto:boot- >>>>> architecture-bounces(a)lists.linaro.org] On Behalf Of Andrew Fish >>>>> Sent: Tuesday, October 22, 2013 2:07 AM >>>>> To: edk2-devel(a)lists.sourceforge.net >>>>> Cc: 'Kim Phillips'; 'boot-architecture(a)lists.linaro.org'; >> Kushwaha >>>>> Prabhakar-B32579 >>>>> Subject: Re: [edk2] Debugging Sec and PI phases {Source symbols} >>>>> >>>>> >>>>> >>>>> On Oct 21, 2013, at 11:38 AM, Sharma Bhupesh-B45370 >>>>> <B45370(a)freescale.com> wrote: >>>>> >>>>>> [Resending as I got a 'You must be subscribed to post messages >> to >>>> this >>>>>> mailing list' message from edk2 list] >>>>>> >>>>>> Hi List, >>>>>> >>>>>> I am new to UEFI and am trying to debug my UEFI ported code >> (from >>>> u- >>>>> boot) on a ARMv7 based SoC. >>>>>> I am able to do some basic debugging of the ARM CPU init code >>>>>> using >>>> a >>>>> DS-5 debugger attached to the board. >>>>>> I see that the ported code crashes somewhere while making a >>>> transition >>>>> from Sec to PI phase. >>>>>> However, I can only verify this by seeing instruction level >>>>>> disassembly. I cannot figure out a way to load the source code >>>> using >>>>> the DS-5 debugger. >>>>>> I am used to seeing ELF files which have the debug information >> and >>>>> which can be loaded via the debugger. >>>>>> Using the 'file' command I cannot find any ELF file in the >> output >>>>>> directory 'Build/..'. The FV and FD files don't seem to be ELF >>>> files as >>>>> well. >>>>> FD is short for Flash Device. So it is usually the layout of the >> ROM. >>>> You >>>>> could have multiple ROMs, but the most common thing is to just >> have >>>>> a single FD. >>>>> FV is a Firmware Volume. Basically a simple Flash Filesystem that >>>> allows >>>>> files, named by GUIDs to be discovered. >>>>> >>>>> EFI is a collection of relocatable PE/COFF images, and in general >> an >>>> INF >>>>> file (no for a library) in your project maps to a PE/COFF file >>>> getting >>>>> generated. >>>>> >>>>> It can vary by compiler, but it is common for the *.dll file to >> be >>>> the >>>>> native image with the debug info. So that is the file you want to >>>> load >>>>> symbols for. >>>>> >>>>> There are various schemes on how to do this. Some platforms print >>>>> out debug messages that map into the commands you need to load >>> symbols. >>>> Some >>>>> platforms have scripts that can load symbols. >>>>> >>>>> Sorry I don't remember the latest recommendation on which scheme >> to >>>> use >>>>> for your platform? Try looking at the *.Fv.map file as I think it >>>>> has info about how to load symbols. You would need a script to >>>>> convert >>>> this >>>>> into some format the DS-5 understands. >>>>> >>>>> Maybe the scripts in >>>>> >> https://svn.code.sf.net/p/edk2/code/trunk/edk2/ArmPlatformPkg/Scripts/ >>>> D >>>> s5 >>>>> / are what you are looking for? >>>> Many thanks Andrew. It seems the DS5 scripts will work for me. I >> found >>>> the wiki for the same here: >>>> >> http://sourceforge.net/apps/mediawiki/tianocore/index.php?title=ArmPkg >>>> / >>>> Ds5 >>>> >>>> I will try to debug the target using these scripts and get back >> with >>>> my results. >>>> >>>> Regards, >>>> Bhupesh >>>> >>>>> Thanks, >>>>> >>>>> Andrew Fish >>>>> >>>>>> Any pointers to which ELF file is generated while compiling a >> UEFI >>>>>> BoardPkg and how it can be loaded via the debugger. >>>>>> >>>>>> Thanks for your help. >>>>>> Regards, >>>>>> Bhupesh >>>>>> >>>>>> >>>>>> --------------------------------------------------------------- >> --- >>>>>> - >>>> --- >>>>>> -------- October Webinars: Code for Performance Free Intel >>>>>> webinars can help you accelerate application performance. >>>>>> Explore tips for MPI, OpenMP, advanced profiling, and more. Get >>>>>> the most from the latest Intel processors and coprocessors. See >>>> abstracts >>>>>> and register > >>>>>> >> http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.c >>>>>> lktrk _______________________________________________ >>>>>> edk2-devel mailing list >>>>>> edk2-devel(a)lists.sourceforge.net >>>>>> https://lists.sourceforge.net/lists/listinfo/edk2-devel >>>>> >>>>> _______________________________________________ >>>>> boot-architecture mailing list >>>>> boot-architecture(a)lists.linaro.org >>>>> http://lists.linaro.org/mailman/listinfo/boot-architecture >>>> >>>> >>>> ------------------------------------------------------------------- >> --- >>>> - >>>> ------- >>>> October Webinars: Code for Performance Free Intel webinars can help >>>> you accelerate application performance. >>>> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the >>>> most from the latest Intel processors and coprocessors. See >> abstracts >>>> and register > >>>> >> http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.c >>>> l >>>> ktrk >>>> _______________________________________________ >>>> edk2-devel mailing list >>>> edk2-devel(a)lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/edk2-devel >>> >>> >>> >>> >>> _______________________________________________ >>> boot-architecture mailing list >>> boot-architecture(a)lists.linaro.org >>> http://lists.linaro.org/mailman/listinfo/boot-architecture >> > > > >

12 years, 2 months

2
1
0 0

RE: [edk2] Debugging Sec and PI phases {Source symbols}

by Olivier Martin

To parse your FV file (embedded in your FD file), you can use './BaseTools/BinWrappers/PosixLike/VolInfo <location of your FV file>' If you want to debug the early stage of your UEFI boot process, you can only use (you do not need -m (...,...)): source edk2/ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py -f (..,...) -a -v At the early stage of the boot, the UEFI firmware has not loaded its binaries into DRAM yet. The UEFI System Table will not be found in System Memory. Where your UEFI firmware lives when started? In DRAM or in Flash/ROM memory? > -----Original Message----- > From: Sharma Bhupesh-B45370 [mailto:B45370@freescale.com] > Sent: 23 October 2013 06:33 > To: Olivier Martin; edk2-devel(a)lists.sourceforge.net; 'Andrew Fish' > Cc: 'Kim Phillips'; boot-architecture(a)lists.linaro.org; Kushwaha > Prabhakar-B32579 > Subject: RE: [edk2] Debugging Sec and PI phases {Source symbols} > > Hi Olivier, > > I tried to use the DS-5 scripts, but landed in some issues, like: > "System table not found in System Memory". > > It seems there is some issue with the .FD gets generated for my > BoardPkg. > > I am also now trying to understand if there is some documentation/tool > available that > can parse my .FD and .FV files and can tell me about the sections in > this particular output > file. For e.g. something like 'readelf -a XXX.ELF' produces as an > output. > > Also I am using the following method to build the .FD to allow > debugging of the source > using the DS5 scripts: > - export EDK2_DSC, EDK2_TOOLCHAIN, EDK2_ARCH, EDK2_BUILD. > > - Run 'make -f ArmPlatformPkg/Scripts/Makefile' > > - This will generate a .FD specific to my Board Pkg in > 'Build/Board_Pkg_Name/DEBUG_ARMGCC/..' > > - Load this .FD using the DS5 and then try to load source symbols > using: > source edk2/ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py -f (..,...) > -m (..,...) -a > > - This gives me an error: > "System table not found in System Memory". > > Any pointers on the above two points.. > > Regards, > Bhupesh > > > -----Original Message----- > > From: boot-architecture-bounces(a)lists.linaro.org [mailto:boot- > > architecture-bounces(a)lists.linaro.org] On Behalf Of Olivier Martin > > Sent: Tuesday, October 22, 2013 2:27 PM > > To: edk2-devel(a)lists.sourceforge.net; 'Andrew Fish' > > Cc: 'Kim Phillips'; boot-architecture(a)lists.linaro.org; Kushwaha > > Prabhakar-B32579 > > Subject: RE: [edk2] Debugging Sec and PI phases {Source symbols} > > > > Hi Bhupesh, > > Yes, if you are using ARM DS-5, this is the wikipage to look at to > setup > > your environment to debug UEFI. Let me know if you have issue. > > Regards, > > Olivier > > > > > -----Original Message----- > > > From: Sharma Bhupesh-B45370 [mailto:B45370@freescale.com] > > > Sent: 22 October 2013 07:56 > > > To: 'Andrew Fish'; 'edk2-devel(a)lists.sourceforge.net' > > > Cc: 'Kim Phillips'; 'boot-architecture(a)lists.linaro.org'; Kushwaha > > > Prabhakar-B32579 > > > Subject: Re: [edk2] Debugging Sec and PI phases {Source symbols} > > > > > > > > > > -----Original Message----- > > > > From: boot-architecture-bounces(a)lists.linaro.org [mailto:boot- > > > > architecture-bounces(a)lists.linaro.org] On Behalf Of Andrew Fish > > > > Sent: Tuesday, October 22, 2013 2:07 AM > > > > To: edk2-devel(a)lists.sourceforge.net > > > > Cc: 'Kim Phillips'; 'boot-architecture(a)lists.linaro.org'; > Kushwaha > > > > Prabhakar-B32579 > > > > Subject: Re: [edk2] Debugging Sec and PI phases {Source symbols} > > > > > > > > > > > > > > > > On Oct 21, 2013, at 11:38 AM, Sharma Bhupesh-B45370 > > > > <B45370(a)freescale.com> wrote: > > > > > > > > > [Resending as I got a 'You must be subscribed to post messages > to > > > this > > > > > mailing list' message from edk2 list] > > > > > > > > > > Hi List, > > > > > > > > > > I am new to UEFI and am trying to debug my UEFI ported code > (from > > > u- > > > > boot) on a ARMv7 based SoC. > > > > > I am able to do some basic debugging of the ARM CPU init code > > > > > using > > > a > > > > DS-5 debugger attached to the board. > > > > > > > > > > I see that the ported code crashes somewhere while making a > > > transition > > > > from Sec to PI phase. > > > > > However, I can only verify this by seeing instruction level > > > > > disassembly. I cannot figure out a way to load the source code > > > using > > > > the DS-5 debugger. > > > > > > > > > > I am used to seeing ELF files which have the debug information > and > > > > which can be loaded via the debugger. > > > > > Using the 'file' command I cannot find any ELF file in the > output > > > > > directory 'Build/..'. The FV and FD files don't seem to be ELF > > > files as > > > > well. > > > > > > > > > > > > > FD is short for Flash Device. So it is usually the layout of the > ROM. > > > You > > > > could have multiple ROMs, but the most common thing is to just > have > > > > a single FD. > > > > FV is a Firmware Volume. Basically a simple Flash Filesystem that > > > allows > > > > files, named by GUIDs to be discovered. > > > > > > > > EFI is a collection of relocatable PE/COFF images, and in general > an > > > INF > > > > file (no for a library) in your project maps to a PE/COFF file > > > getting > > > > generated. > > > > > > > > It can vary by compiler, but it is common for the *.dll file to > be > > > the > > > > native image with the debug info. So that is the file you want to > > > load > > > > symbols for. > > > > > > > > There are various schemes on how to do this. Some platforms print > > > > out debug messages that map into the commands you need to load > > symbols. > > > Some > > > > platforms have scripts that can load symbols. > > > > > > > > Sorry I don't remember the latest recommendation on which scheme > to > > > use > > > > for your platform? Try looking at the *.Fv.map file as I think it > > > > has info about how to load symbols. You would need a script to > > > > convert > > > this > > > > into some format the DS-5 understands. > > > > > > > > Maybe the scripts in > > > > > > > > https://svn.code.sf.net/p/edk2/code/trunk/edk2/ArmPlatformPkg/Scripts/ > > > D > > > s5 > > > > / are what you are looking for? > > > > > > Many thanks Andrew. It seems the DS5 scripts will work for me. I > found > > > the wiki for the same here: > > > > http://sourceforge.net/apps/mediawiki/tianocore/index.php?title=ArmPkg > > > / > > > Ds5 > > > > > > I will try to debug the target using these scripts and get back > with > > > my results. > > > > > > Regards, > > > Bhupesh > > > > > > > Thanks, > > > > > > > > Andrew Fish > > > > > > > > > Any pointers to which ELF file is generated while compiling a > UEFI > > > > > BoardPkg and how it can be loaded via the debugger. > > > > > > > > > > Thanks for your help. > > > > > Regards, > > > > > Bhupesh > > > > > > > > > > > > > > > --------------------------------------------------------------- > --- > > > > > - > > > --- > > > > > -------- October Webinars: Code for Performance Free Intel > > > > > webinars can help you accelerate application performance. > > > > > Explore tips for MPI, OpenMP, advanced profiling, and more. Get > > > > > the most from the latest Intel processors and coprocessors. See > > > abstracts > > > > > and register > > > > > > > > > > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.c > > > > > lktrk _______________________________________________ > > > > > edk2-devel mailing list > > > > > edk2-devel(a)lists.sourceforge.net > > > > > https://lists.sourceforge.net/lists/listinfo/edk2-devel > > > > > > > > > > > > _______________________________________________ > > > > boot-architecture mailing list > > > > boot-architecture(a)lists.linaro.org > > > > http://lists.linaro.org/mailman/listinfo/boot-architecture > > > > > > > > > > > > ------------------------------------------------------------------- > --- > > > - > > > ------- > > > October Webinars: Code for Performance Free Intel webinars can help > > > you accelerate application performance. > > > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the > > > most from the latest Intel processors and coprocessors. See > abstracts > > > and register > > > > > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.c > > > l > > > ktrk > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel(a)lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/edk2-devel > > > > > > > > > > > > _______________________________________________ > > boot-architecture mailing list > > boot-architecture(a)lists.linaro.org > > http://lists.linaro.org/mailman/listinfo/boot-architecture > >

12 years, 2 months

1
0
0 0

RE: [edk2] Debugging Sec and PI phases {Source symbols}

by Olivier Martin

Hi Bhupesh, Yes, if you are using ARM DS-5, this is the wikipage to look at to setup your environment to debug UEFI. Let me know if you have issue. Regards, Olivier > -----Original Message----- > From: Sharma Bhupesh-B45370 [mailto:B45370@freescale.com] > Sent: 22 October 2013 07:56 > To: 'Andrew Fish'; 'edk2-devel(a)lists.sourceforge.net' > Cc: 'Kim Phillips'; 'boot-architecture(a)lists.linaro.org'; Kushwaha > Prabhakar-B32579 > Subject: Re: [edk2] Debugging Sec and PI phases {Source symbols} > > > > -----Original Message----- > > From: boot-architecture-bounces(a)lists.linaro.org [mailto:boot- > > architecture-bounces(a)lists.linaro.org] On Behalf Of Andrew Fish > > Sent: Tuesday, October 22, 2013 2:07 AM > > To: edk2-devel(a)lists.sourceforge.net > > Cc: 'Kim Phillips'; 'boot-architecture(a)lists.linaro.org'; Kushwaha > > Prabhakar-B32579 > > Subject: Re: [edk2] Debugging Sec and PI phases {Source symbols} > > > > > > > > On Oct 21, 2013, at 11:38 AM, Sharma Bhupesh-B45370 > > <B45370(a)freescale.com> wrote: > > > > > [Resending as I got a 'You must be subscribed to post messages to > this > > > mailing list' message from edk2 list] > > > > > > Hi List, > > > > > > I am new to UEFI and am trying to debug my UEFI ported code (from > u- > > boot) on a ARMv7 based SoC. > > > I am able to do some basic debugging of the ARM CPU init code using > a > > DS-5 debugger attached to the board. > > > > > > I see that the ported code crashes somewhere while making a > transition > > from Sec to PI phase. > > > However, I can only verify this by seeing instruction level > > > disassembly. I cannot figure out a way to load the source code > using > > the DS-5 debugger. > > > > > > I am used to seeing ELF files which have the debug information and > > which can be loaded via the debugger. > > > Using the 'file' command I cannot find any ELF file in the output > > > directory 'Build/..'. The FV and FD files don't seem to be ELF > files as > > well. > > > > > > > FD is short for Flash Device. So it is usually the layout of the ROM. > You > > could have multiple ROMs, but the most common thing is to just have a > > single FD. > > FV is a Firmware Volume. Basically a simple Flash Filesystem that > allows > > files, named by GUIDs to be discovered. > > > > EFI is a collection of relocatable PE/COFF images, and in general an > INF > > file (no for a library) in your project maps to a PE/COFF file > getting > > generated. > > > > It can vary by compiler, but it is common for the *.dll file to be > the > > native image with the debug info. So that is the file you want to > load > > symbols for. > > > > There are various schemes on how to do this. Some platforms print out > > debug messages that map into the commands you need to load symbols. > Some > > platforms have scripts that can load symbols. > > > > Sorry I don't remember the latest recommendation on which scheme to > use > > for your platform? Try looking at the *.Fv.map file as I think it has > > info about how to load symbols. You would need a script to convert > this > > into some format the DS-5 understands. > > > > Maybe the scripts in > > > https://svn.code.sf.net/p/edk2/code/trunk/edk2/ArmPlatformPkg/Scripts/D > s5 > > / are what you are looking for? > > Many thanks Andrew. It seems the DS5 scripts will work for me. I found > the wiki > for the same here: > http://sourceforge.net/apps/mediawiki/tianocore/index.php?title=ArmPkg/ > Ds5 > > I will try to debug the target using these scripts and get back with my > results. > > Regards, > Bhupesh > > > Thanks, > > > > Andrew Fish > > > > > Any pointers to which ELF file is generated while compiling a UEFI > > > BoardPkg and how it can be loaded via the debugger. > > > > > > Thanks for your help. > > > Regards, > > > Bhupesh > > > > > > > > > ------------------------------------------------------------------- > --- > > > -------- October Webinars: Code for Performance Free Intel webinars > > > can help you accelerate application performance. > > > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the > > > most from the latest Intel processors and coprocessors. See > abstracts > > > and register > > > > > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.c > > > lktrk _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel(a)lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/edk2-devel > > > > > > _______________________________________________ > > boot-architecture mailing list > > boot-architecture(a)lists.linaro.org > > http://lists.linaro.org/mailman/listinfo/boot-architecture > > > > ----------------------------------------------------------------------- > ------- > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the > most from > the latest Intel processors and coprocessors. See abstracts and > register > > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.cl > ktrk > _______________________________________________ > edk2-devel mailing list > edk2-devel(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel

12 years, 2 months

1
0
0 0

Re: [edk2] Debugging Sec and PI phases {Source symbols}

by Andrew Fish

On Oct 21, 2013, at 11:38 AM, Sharma Bhupesh-B45370 <B45370(a)freescale.com> wrote: > [Resending as I got a 'You must be subscribed to post messages to this mailing list' message from edk2 list] > > Hi List, > > I am new to UEFI and am trying to debug my UEFI ported code (from u-boot) on a ARMv7 based SoC. > I am able to do some basic debugging of the ARM CPU init code using a DS-5 debugger attached to the board. > > I see that the ported code crashes somewhere while making a transition from Sec to PI phase. > However, I can only verify this by seeing instruction level disassembly. I cannot figure out a way to load > the source code using the DS-5 debugger. > > I am used to seeing ELF files which have the debug information and which can be loaded via the debugger. > Using the 'file' command I cannot find any ELF file in the output directory 'Build/..'. The FV and FD > files don't seem to be ELF files as well. > FD is short for Flash Device. So it is usually the layout of the ROM. You could have multiple ROMs, but the most common thing is to just have a single FD. FV is a Firmware Volume. Basically a simple Flash Filesystem that allows files, named by GUIDs to be discovered. EFI is a collection of relocatable PE/COFF images, and in general an INF file (no for a library) in your project maps to a PE/COFF file getting generated. It can vary by compiler, but it is common for the *.dll file to be the native image with the debug info. So that is the file you want to load symbols for. There are various schemes on how to do this. Some platforms print out debug messages that map into the commands you need to load symbols. Some platforms have scripts that can load symbols. Sorry I don't remember the latest recommendation on which scheme to use for your platform? Try looking at the *.Fv.map file as I think it has info about how to load symbols. You would need a script to convert this into some format the DS-5 understands. Maybe the scripts in https://svn.code.sf.net/p/edk2/code/trunk/edk2/ArmPlatformPkg/Scripts/Ds5/ are what you are looking for? Thanks, Andrew Fish > Any pointers to which ELF file is generated while compiling a UEFI BoardPkg and how it can be loaded > via the debugger. > > Thanks for your help. > Regards, > Bhupesh > > > ------------------------------------------------------------------------------ > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from > the latest Intel processors and coprocessors. See abstracts and register > > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk > _______________________________________________ > edk2-devel mailing list > edk2-devel(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel

12 years, 2 months

1
0
0 0

Aarch64 patches for uefi-next.git

by Ryan Harkin

Hi Steven, Please find attached two patches used for aarch64 work. Each patch goes into a different topic branch in the end, not in the linaro-topic-fvp branch as we discussed earlier. Still, they are quite simple, so shouldn't cause much of a problem. 0001-tools_def-AARCH64-use-CROSS_COMPILE-variable.patch The above patch goes into linaro-topic-misc. 0002-FVP-Add-support-for-EDK2_USE_ANDROID_CONFIG-build-pa.patch The above patch goes into linaro-topic-fvp. Please let me know if these cause you any problems, but it would be good to get them into uefi.git for the -rc4 and the -03 release respin. You can also pull both patches/branches from my tree: https://git.linaro.org/gitweb?p=people/ryanharkin/uefi-next.git;a=summary Thanks, Ryan.

12 years, 2 months

1
2
0 0

Re: uefi stub + grub

by Leif Lindholm

On Mon, Sep 30, 2013 at 10:28:49PM +0100, Grant Likely wrote: > > > load image protocol. In that case the sub should override the setting in > the > > > FDT if the initrd argument is present. > > > > Hmm, well, it's slightly worse than that - it will have one; only it > > will be GRUB's command line. > > > > The way that can be resolved is: > > - FDT present? > > - Commandline present in FDT chosen node? > > - Yes > > - Use that. > > - No > > - EFI_LOADED_IMAGE command line present? > > - Yes > > - Use that. > > - No > > - Fail miserably. > That doesn't handle the case where firmware provides the fdt, but the kernel is > loaded via the UEFI shell or gummiboot. In that case the stub must process both > the loaded image arguments. Well, unless the firmware-provided device tree contains a kernel command line, that should work fine? If you mean that there are two command lines to parse for the EFI_LOADED_IMAGE (one for shell/gummiboot), surely there is a handle in there to identify the "current" one. / Leif

12 years, 3 months

1
0
0 0

Re: uefi stub + grub

by Leif Lindholm

On Mon, Sep 30, 2013 at 09:05:04PM +0100, Grant Likely wrote: > > Handling the 2 cases is not a problem. I just don't want to handle > > 'mixed' cases where > > a command line and an FDT are passed to the stub, and information from > > both is used. > > > > As I understand it, the two cases are: > > > > FDT_GUID present == GRUB case > > * GRUB loads initrd if present > > * GRUB provides complete FDT to stub (includes command line, hardware > > description, initrd entry, etc.) > > * EFI stub loads FDT using FDT_GUID, adds memory map and system table > > pointer to FDT, starts kernel. > > * (any command line present in EFI_LOADED_IMAGE is ignored.) > > > > FDT_GUID absent == current case > > * stub loads FDT and initrd from system partition > > * stub adds command line from EFI_LOADED_IMAGE to FDT > > * stub adds initrd entry to FDT > > * stub adds memory map and system table pointer to FDT, starts kernel. > > > > In the case of UEFI owning the FDT, and providing it to the stub, > > where does the initrd come from? I think this adds > > another case to handle... > The stub will still need to process a command line if it is given one via the > load image protocol. In that case the sub should override the setting in the > FDT if the initrd argument is present. Hmm, well, it's slightly worse than that - it will have one; only it will be GRUB's command line. The way that can be resolved is: - FDT present? - Commandline present in FDT chosen node? - Yes - Use that. - No - EFI_LOADED_IMAGE command line present? - Yes - Use that. - No - Fail miserably. / Leif

12 years, 3 months

1
0
0 0

Re: uefi stub + grub

by Roy Franz

On Mon, Sep 30, 2013 at 11:27 AM, Grant Likely <grant.likely(a)linaro.org> wrote: > On Mon, Sep 30, 2013 at 5:46 PM, Leif Lindholm <leif.lindholm(a)linaro.org> wrote: >> On Mon, Sep 30, 2013 at 08:05:59AM -0700, Roy Franz wrote: >>> > I was thinking that the stub would want to use the FDT passed by grub >>> > if one is passed, but I hadn't thought about the case where grub wants >>> > to pass information to the stub, but the stub still loads the FDT. The >>> > easiest thing would be to straight out say that if GRUB is loading the >>> > initrd, then it is mandatory for GRUB to also load the FDT. That >>> > eliminates the corner case and I can't think of any situation where >>> > we'd want GRUB loading the initrd, but use the stub to load the FDT. >>> >>> I'd also like to avoid having the stub merge FDT contents from different trees. >>> >>> If we add this table, then it seems this would be the right way to >>> handle passing >>> the FDT to the EFI stub, even without GRUB involved. Is there a reason not to >>> move to this method in general? >> >> Not really. >> So ... I guess that would modify the stub behaviour to: >> - Look for an FDT_GUID configuration table. >> - If there, use it. >> - If not there, require one to be loaded based on command line. > > Create a mostly empty one for passing freeform data to the kernel > proper; this is what it will look like on ACPI systems. So for ACPI systems the stub will package the ACPI data into the FDT? What would the stub be putting into the FDT that an ACPI/UEFI aware kernel couldn't get itself at runtime from UEFI? > >> And the GRUB behaviour to: >> - If no FDT_GUID, require FDT if initrd. >> - If FDT_GUID, copy FDT + add initrd information. >> >> The x86 code uses bootparam to pass the kernel command line. >> Could we use the FDT exists) for the kernel command line >> too? This would make more code shared between x86 and ARM*, since >> otherwise we would need to explicitly implement (UCS?) command line >> passing to stub? > > Yes, I think that makes sense. That also means GRUB will need to > always create an FDT, even if it is empty. I'm not following something here - why would GRUB create an empty FDT? Is GRUB going to be responsible for the complete FDT, or just passing the initrd and/or command line in an FDT? > > The other option would be to pass the command line via the LoadOptions > from the EFI_LOADED_IMAGE protocol. I believe that is what Roy's > patches currently rely on for getting a command line. Yes, both my implementation and the x86 implementation get the command line from the EFI_LOADED_IMAGE protocol, and do conversion from UCS-2 (I think) to ASCII/UTF-8 to pass to the kernel. The format of the command line does not seem to be specified by UEFI. > > g.

12 years, 3 months

2
2
0 0

Re: uefi stub + grub

by Leif Lindholm

On Mon, Sep 30, 2013 at 07:27:58PM +0100, Grant Likely wrote: > > So ... I guess that would modify the stub behaviour to: > > - Look for an FDT_GUID configuration table. > > - If there, use it. > > - If not there, require one to be loaded based on command line. > > Create a mostly empty one for passing freeform data to the kernel > proper; this is what it will look like on ACPI systems. OK. So we push the actual error condition of missing tree down to stub? Makes sense. > > The x86 code uses bootparam to pass the kernel command line. > > Could we use the FDT exists) for the kernel command line > > too? This would make more code shared between x86 and ARM*, since > > otherwise we would need to explicitly implement (UCS?) command line > > passing to stub? > > Yes, I think that makes sense. That also means GRUB will need to > always create an FDT, even if it is empty. Yes. This would be my preference. > The other option would be to pass the command line via the LoadOptions > from the EFI_LOADED_IMAGE protocol. I believe that is what Roy's > patches currently rely on for getting a command line. Since the current code doesn't UEFI-wise "load" the stub image, we'd effectively need to reverse-reconstruct GRUB's runtime environment, which I really wouldn't like. / Leif

12 years, 3 months

1
0
0 0

Re: uefi stub + grub

by Roy Franz

On Mon, Sep 30, 2013 at 7:51 AM, Grant Likely <grant.likely(a)linaro.org> wrote: > On Mon, Sep 30, 2013 at 2:59 PM, Leif Lindholm <leif.lindholm(a)linaro.org> wrote: >> Hi guys, >> >> I've been looking at the patches Matthew Garrett wrote for loading a >> UEFI stub kernel through GRUB, and noticed one thing that may require >> updates to the stub code: it uses GRUB to load the initrd. >> Doing this of course means the initrd does not need to go into the EFI >> System Partition, which is a lot nicer from the distros' position. >> >> Now, in x86 land GRUB just passes the stub a bootparam structure, and >> I assume it just keeps filling the same structure in before passing it >> on to the kernel . >> >> On ARM*, we would need to get this information over "some other way", >> where the obvious candidate would be FDT. >> >> GRUB could register an empty devicetree, with only the initrd >> information in it, as a UEFI configuration table. (Getting a UUID for >> this was discussed in New Orleans.) > > Right. It would be a trivial feature to have a UUID in the system > table pointing to an allocated block of memory containing an FDT. It > would also be nice to give the FDT some extra space when loaded so > that the libfdt functions can work in-place... but I digress; the flat > tree structure already contains enough information to do that. > >> Or, on systems using FDT for hardware description, once firmware >> becomes mature enough to do this themselves - add this information to >> the system-provided one. >> >> The stub would then need to look for this devicetree, and if present, >> copy the initrd nodes across into the one it loads itself. > > I was thinking that the stub would want to use the FDT passed by grub > if one is passed, but I hadn't thought about the case where grub wants > to pass information to the stub, but the stub still loads the FDT. The > easiest thing would be to straight out say that if GRUB is loading the > initrd, then it is mandatory for GRUB to also load the FDT. That > eliminates the corner case and I can't think of any situation where > we'd want GRUB loading the initrd, but use the stub to load the FDT. I'd also like to avoid having the stub merge FDT contents from different trees. If we add this table, then it seems this would be the right way to handle passing the FDT to the EFI stub, even without GRUB involved. Is there a reason not to move to this method in general? > >> Alternatively, we could define a special protocol for passing >> additional parameters to the stubbed kernel ... or a special protocol >> to pass a special FDT but I'm not sure we want yet another interface. > > Indeed. I definitely don't want to do this. Agreed... > > g.

12 years, 3 months

2
1
0 0

uefi stub + grub

by Leif Lindholm

Hi guys, I've been looking at the patches Matthew Garrett wrote for loading a UEFI stub kernel through GRUB, and noticed one thing that may require updates to the stub code: it uses GRUB to load the initrd. Doing this of course means the initrd does not need to go into the EFI System Partition, which is a lot nicer from the distros' position. Now, in x86 land GRUB just passes the stub a bootparam structure, and I assume it just keeps filling the same structure in before passing it on to the kernel . On ARM*, we would need to get this information over "some other way", where the obvious candidate would be FDT. GRUB could register an empty devicetree, with only the initrd information in it, as a UEFI configuration table. (Getting a UUID for this was discussed in New Orleans.) Or, on systems using FDT for hardware description, once firmware becomes mature enough to do this themselves - add this information to the system-provided one. The stub would then need to look for this devicetree, and if present, copy the initrd nodes across into the one it loads itself. Alternatively, we could define a special protocol for passing additional parameters to the stubbed kernel ... or a special protocol to pass a special FDT but I'm not sure we want yet another interface. Thoughts? / Leif

12 years, 3 months

1
0
0 0

Re: [linaro-uefi-internal] [PATCH] ARMVE:SMBIOS: Enable smbios support on all ARMVE platform

by Steven Kinney

Hi Yi, One comment regarding the patch and non-existing files (*dsc) and the like, targeted by this patch, relative to the current tianocore-edk2 and resulting uefi-next codebase. I don't think patches targeting future file(s) benefit us prior to their inclusion within either tianocore-edk2 or direct addition into uefi-next via topic branch patch. There are a number of ways this could create undue stress, in the future, when the patch has a sane codebase. IMHO, we should only create patches for current source in either existing uefi-next or tianocore-edk2 source code, not future source code that may change significantly between patch generation and its eventual application. I am using you previous patch, which does not include the future source code, not present in the current tianocore-edk2. I see no value in creating patches based on a possible source code revision; to many permutations possible prior to the patches application. Thanks, Steve On 12 September 2013 10:09, Yi Li <yi.li(a)linaro.org> wrote: > From: liyi <yi.li(a)linaro.org> > > Enable the smbios support for all ARMVE platforms. > > SMBIOS driver will fill real h/w informations into UEFI image,and > report them to OS,like x86 system. > > Signed-off-by: liyi <yi.li(a)linaro.org> > --- > ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.c | 841 > ++++++++++++++++++++ > ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.h | 53 ++ > ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.inf | 64 ++ > .../ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc | 6 + > .../ArmVExpressPkg/ArmVExpress-CTA15-A7.fdf | 6 + > .../ArmVExpressPkg/ArmVExpress-CTA15x2.dsc | 6 + > .../ArmVExpressPkg/ArmVExpress-CTA15x2.fdf | 6 + > .../ArmVExpressPkg/ArmVExpress-CTA5s.dsc | 6 + > .../ArmVExpressPkg/ArmVExpress-CTA5s.fdf | 6 + > .../ArmVExpressPkg/ArmVExpress-CTA9x4.dsc | 6 + > .../ArmVExpressPkg/ArmVExpress-CTA9x4.fdf | 6 + > .../ArmVExpressPkg/ArmVExpress-RTSM-A15.dsc | 6 + > .../ArmVExpressPkg/ArmVExpress-RTSM-A15.fdf | 6 + > .../ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.dsc | 8 +- > .../ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.fdf | 6 + > .../ArmVExpressPkg/ArmVExpress-RTSM-A9x4.dsc | 6 + > .../ArmVExpressPkg/ArmVExpress-RTSM-A9x4.fdf | 6 + > 17 files changed, 1043 insertions(+), 1 deletion(-) > create mode 100644 ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.c > create mode 100644 ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.h > create mode 100644 ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.inf > > diff --git a/ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.c > b/ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.c > new file mode 100644 > index 0000000..84a8acd > --- /dev/null > +++ b/ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.c > @@ -0,0 +1,841 @@ > +/** @file > + This code responsible for constructing and updating SMBIOS table into > system table. > +Copyright (c) 2009 - 2013, Intel Corporation. All rights reserved.<BR> > +This program and the accompanying materials > +are licensed and made available under the terms and conditions of the BSD > License > +which accompanies this distribution. The full text of the license may be > found at > +http://opensource.org/licenses/bsd-license.php > + > +THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > + > +SMBIOS Driver. > + > +yi.li(a)linaro.org > +Copyright (c) 2013 Linaro.org > + > + This program and the accompanying materials are licensed and > +made available under the terms and conditions of the BSD License > +which accompanies this distribution. The full text of the license > +may be found at: http://opensource.org/licenses/bsd-license.php > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > +**/ > + > +#include "UpdateSmbios.h" > + > + > +/*********************************************************************** > + SMBIOS data definition TYPE0 BIOS Information > +************************************************************************/ > + > +SMBIOS_TABLE_TYPE0 mBIOSInfoType0 = { > + { EFI_SMBIOS_TYPE_BIOS_INFORMATION, sizeof (SMBIOS_TABLE_TYPE0), 0 }, > + 1, // Vendor String > + 2, // BiosVersion String > + 0xE000, // BiosSegment > + 3, // BiosReleaseDate String > + 0x7F, // BiosSize > + { // BiosCharacteristics > + 0, // Reserved :2; ///< Bits 0-1. > + 0, // Unknown :1; > + 0, // BiosCharacteristicsNotSupported :1; > + 0, // IsaIsSupported :1; > + 0, // McaIsSupported :1; > + 0, // EisaIsSupported :1; > + 1, // PciIsSupported :1; > + 0, // PcmciaIsSupported :1; > + 0, // PlugAndPlayIsSupported :1; > + 0, // ApmIsSupported :1; > + 1, // BiosIsUpgradable :1; > + 1, // BiosShadowingAllowed :1; > + 0, // VlVesaIsSupported :1; > + 0, // EscdSupportIsAvailable :1; > + 0, // BootFromCdIsSupported :1; > + 1, // SelectableBootIsSupported :1; > + 0, // RomBiosIsSocketed :1; > + 0, // BootFromPcmciaIsSupported :1; > + 0, // EDDSpecificationIsSupported :1; > + 0, // JapaneseNecFloppyIsSupported :1; > + 0, // JapaneseToshibaFloppyIsSupported :1; > + 0, // Floppy525_360IsSupported :1; > + 0, // Floppy525_12IsSupported :1; > + 0, // Floppy35_720IsSupported :1; > + 0, // Floppy35_288IsSupported :1; > + 0, // PrintScreenIsSupported :1; > + 0, // Keyboard8042IsSupported :1; > + 0, // SerialIsSupported :1; > + 0, // PrinterIsSupported :1; > + 0, // CgaMonoIsSupported :1; > + 0, // NecPc98 :1; > + 0 // ReservedForVendor :32; ///< Bits 32-63. > Bits 32-47 reserved for BIOS vendor > + ///< and bits 48-63 > reserved for System Vendor. > + }, > + { // BIOSCharacteristicsExtensionBytes[] > + 0x81, // AcpiIsSupported :1; > + // UsbLegacyIsSupported :1; > + // AgpIsSupported :1; > + // I2OBootIsSupported :1; > + // Ls120BootIsSupported :1; > + // AtapiZipDriveBootIsSupported :1; > + // Boot1394IsSupported :1; > + // SmartBatteryIsSupported :1; > + // BIOSCharacteristicsExtensionBytes[1] > + 0x0a, // BiosBootSpecIsSupported :1; > + // FunctionKeyNetworkBootIsSupported :1; > + // TargetContentDistributionEnabled :1; > + // UefiSpecificationSupported :1; > + // VirtualMachineSupported :1; > + // ExtensionByte2Reserved :3; > + }, > + 0x00, // SystemBiosMajorRelease > + 0x01, // SystemBiosMinorRelease > + 0xFF, // EmbeddedControllerFirmwareMajorRelease > + 0xFF, // EmbeddedControllerFirmwareMinorRelease > +}; > + > + > +CHAR8 *mBIOSInfoType0Strings[] = { > + "edk2.sourceforge.net", // Vendor String > + __TIME__, // BiosVersion String > + __DATE__, // BiosReleaseDate String > + NULL > +}; > + > + > +/*********************************************************************** > + SMBIOS data definition TYPE1 System Information > +************************************************************************/ > +SMBIOS_TABLE_TYPE1 mSysInfoType1 = { > + { EFI_SMBIOS_TYPE_SYSTEM_INFORMATION, sizeof (SMBIOS_TABLE_TYPE1), 0 }, > + 1, // Manufacturer String > + 2, // ProductName String > + 3, // Version String > + 4, // SerialNumber String > + { 0x25EF0280, 0xEC82, 0x42B0, { 0x8F, 0xB6, 0x10, 0xAD, 0xCC, 0xC6, > 0x7C, 0x02 } }, > + SystemWakeupTypePowerSwitch, > + 5, // SKUNumber String > + 6, // Family String > +}; > +CHAR8 *mSysInfoType1Strings[] = { > + "edk2.sourceforge.net", > + "EmulatorPkg", > + "1.0", > + "System Serial#", > + "System SKU#", > + "edk2", > + NULL > +}; > + > +/*********************************************************************** > + SMBIOS data definition TYPE2 Board Information > +************************************************************************/ > + > +SMBIOS_TABLE_TYPE2 mBoardInfoType2 = { > + { EFI_SMBIOS_TYPE_BASEBOARD_INFORMATION, sizeof (SMBIOS_TABLE_TYPE2), 0 > }, > + 1, // Manufacturer String > + 2, // ProductName String > + 3, // Version String > + 4, // SerialNumber String > + 5, // AssetTag String > + { // FeatureFlag > + 1, // Motherboard :1; > + 0, // RequiresDaughterCard :1; > + 0, // Removable :1; > + 0, // Replaceable :1; > + 0, // HotSwappable :1; > + 0, // Reserved :3; > + }, > + 6, // LocationInChassis String > + 0, // ChassisHandle; > + BaseBoardTypeMotherBoard, // BoardType; > + 0, // NumberOfContainedObjectHandles; > + { 0 } // ContainedObjectHandles[1]; > +}; > +CHAR8 *mBoardInfoType2Strings[] = { > + "edk2.sourceforge.net", > + "EmulatorPkg", > + "1.0", > + "Base Board Serial#", > + "Base Board Asset Tag#", > + "Part Component", > + NULL > +}; > + > + > +/*********************************************************************** > + SMBIOS data definition TYPE3 Enclosure Information > +************************************************************************/ > + > +SMBIOS_TABLE_TYPE3 mEnclosureInfoType3 = { > + { EFI_SMBIOS_TYPE_SYSTEM_ENCLOSURE, sizeof (SMBIOS_TABLE_TYPE3), 0 }, > + 1, // Manufacturer String > + MiscChassisTypeLapTop, // Type; > + 2, // Version String > + 3, // SerialNumber String > + 4, // AssetTag String > + ChassisStateSafe, // BootupState; > + ChassisStateSafe, // PowerSupplyState; > + ChassisStateSafe, // ThermalState; > + ChassisSecurityStatusNone,// SecurityStatus; > + { 0, 0, 0, 0 }, // OemDefined[4]; > + 0, // Height; > + 0, // NumberofPowerCords; > + 0, // ContainedElementCount; > + 0, // ContainedElementRecordLength; > + { 0 }, // ContainedElements[1]; > +}; > +CHAR8 *mEnclosureInfoType3Strings[] = { > + "edk2.sourceforge.net", > + "EmulatorPkg", > + "Chassis Board Serial#", > + "Chassis Board Asset Tag#", > + NULL > +}; > + > + > + > +/*********************************************************************** > + SMBIOS data definition TYPE4 Processor Information > +************************************************************************/ > + > +SMBIOS_TABLE_TYPE4 mProcessorInfoType4 = { > + > + { EFI_SMBIOS_TYPE_PROCESSOR_INFORMATION, sizeof (SMBIOS_TABLE_TYPE4), > 0}, > + > + 1, // Socket String > + ProcessorOther, // ProcessorType; ///< The enumeration > value from PROCESSOR_TYPE_DATA. > + ProcessorFamilyOther, // ProcessorFamily; ///< The enumeration > value from PROCESSOR_FAMILY_DATA. > + 2, // ProcessorManufacture String; > + { // ProcessorId; > + { // PROCESSOR_SIGNATURE > + 0, // ProcessorSteppingId:4; > + 0, // ProcessorModel: 4; > + 0, // ProcessorFamily: 4; > + 0, // ProcessorType: 2; > + 0, // ProcessorReserved1: 2; > + 0, // ProcessorXModel: 4; > + 0, // ProcessorXFamily: 8; > + 0, // ProcessorReserved2: 4; > + }, > + > + { // PROCESSOR_FEATURE_FLAGS > + 0, // ProcessorFpu :1; > + 0, // ProcessorVme :1; > + 0, // ProcessorDe :1; > + 0, // ProcessorPse :1; > + 0, // ProcessorTsc :1; > + 0, // ProcessorMsr :1; > + 0, // ProcessorPae :1; > + 0, // ProcessorMce :1; > + 0, // ProcessorCx8 :1; > + 0, // ProcessorApic :1; > + 0, // ProcessorReserved1 :1; > + 0, // ProcessorSep :1; > + 0, // ProcessorMtrr :1; > + 0, // ProcessorPge :1; > + 0, // ProcessorMca :1; > + 0, // ProcessorCmov :1; > + 0, // ProcessorPat :1; > + 0, // ProcessorPse36 :1; > + 0, // ProcessorPsn :1; > + 0, // ProcessorClfsh :1; > + 0, // ProcessorReserved2 :1; > + 0, // ProcessorDs :1; > + 0, // ProcessorAcpi :1; > + 0, // ProcessorMmx :1; > + 0, // ProcessorFxsr :1; > + 0, // ProcessorSse :1; > + 0, // ProcessorSse2 :1; > + 0, // ProcessorSs :1; > + 0, // ProcessorReserved3 :1; > + 0, // ProcessorTm :1; > + 0, // ProcessorReserved4 :2; > + } > + }, > + 3, // ProcessorVersion String; > + { // Voltage; > + 1, // ProcessorVoltageCapability5V :1; > + 1, // ProcessorVoltageCapability3_3V :1; > + 1, // ProcessorVoltageCapability2_9V :1; > + 0, // ProcessorVoltageCapabilityReserved :1; ///< Bit 3, must be > zero. > + 0, // ProcessorVoltageReserved :3; ///< Bits 4-6, must be > zero. > + 0 // ProcessorVoltageIndicateLegacy :1; > + }, > + 0, // ExternalClock; > + 0, // MaxSpeed; > + 0, // CurrentSpeed; > + 0x41, // Status; > + ProcessorUpgradeOther, // ProcessorUpgrade; ///< The enumeration > value from PROCESSOR_UPGRADE. > + 0, // L1CacheHandle; > + 0, // L2CacheHandle; > + 0, // L3CacheHandle; > + 4, // SerialNumber; > + 5, // AssetTag; > + 6, // PartNumber; > + 0, // CoreCount; > + 0, // EnabledCoreCount; > + 0, // ThreadCount; > + 0, // ProcessorCharacteristics; > + 0, // ProcessorFamily2; > +}; > + > + > +CHAR8 *mProcessorInfoType4Strings[] = { > + "Socket", > + "edk2.svn.sourceforge.net", > + "Emulated Processor", > + "1.0", > + "1.0", > + "1.0", > + NULL > +}; > + > + > +/*********************************************************************** > + SMBIOS data definition TYPE7 Cache Information > +************************************************************************/ > + > +SMBIOS_TABLE_TYPE7 mCacheInfoType7 = { > + { EFI_SMBIOS_TYPE_CACHE_INFORMATION, sizeof (SMBIOS_TABLE_TYPE7), 0 }, > + 1, // SocketDesignation String > + 0x018A, // Cache Configuration > + 0x00FF, // Maximum Size 256k > + 0x00FF, // Install Size 256k > + { // Supported SRAM Type > + 0, //Other :1 > + 0, //Unknown :1 > + 0, //NonBurst :1 > + 1, //Burst :1 > + 0, //PiplelineBurst :1 > + 1, //Synchronous :1 > + 0, //Asynchronous :1 > + 0 //Reserved :9 > + }, > + { // Current SRAM Type > + 0, //Other :1 > + 0, //Unknown :1 > + 0, //NonBurst :1 > + 1, //Burst :1 > + 0, //PiplelineBurst :1 > + 1, //Synchronous :1 > + 0, //Asynchronous :1 > + 0 //Reserved :9 > + }, > + 0, // Cache Speed unknown > + CacheErrorMultiBit, // Error Correction Multi > + CacheTypeUnknown, // System Cache Type > + CacheAssociativity2Way // Associativity > +}; > +CHAR8 *mCacheInfoType7Strings[] = { > + "Cache1", > + NULL > +}; > + > + > +/*********************************************************************** > + SMBIOS data definition TYPE9 System Slot Information > +************************************************************************/ > + > +SMBIOS_TABLE_TYPE9 mSysSlotInfoType9 = { > + { EFI_SMBIOS_TYPE_SYSTEM_SLOTS, sizeof (SMBIOS_TABLE_TYPE9), 0 }, > + 1, // SlotDesignation String > + SlotTypeOther, // SlotType; ///< The > enumeration value from MISC_SLOT_TYPE. > + SlotDataBusWidthOther, // SlotDataBusWidth; ///< The > enumeration value from MISC_SLOT_DATA_BUS_WIDTH. > + SlotUsageAvailable, // CurrentUsage; ///< The > enumeration value from MISC_SLOT_USAGE. > + SlotLengthOther, // SlotLength; ///< The enumeration > value from MISC_SLOT_LENGTH. > + 0, // SlotID; > + { // SlotCharacteristics1; > + 1, // CharacteristicsUnknown :1; > + 0, // Provides50Volts :1; > + 0, // Provides33Volts :1; > + 0, // SharedSlot :1; > + 0, // PcCard16Supported :1; > + 0, // CardBusSupported :1; > + 0, // ZoomVideoSupported :1; > + 0, // ModemRingResumeSupported:1; > + }, > + { // SlotCharacteristics2; > + 0, // PmeSignalSupported :1; > + 0, // HotPlugDevicesSupported :1; > + 0, // SmbusSignalSupported :1; > + 0, // Reserved :5; ///< Set to 0. > + }, > + 0, // SegmentGroupNum; > + 0, // BusNum; > + 0, // DevFuncNum; > +}; > +CHAR8 *mSysSlotInfoType9Strings[] = { > + "SD Card", > + NULL > +}; > + > +/*********************************************************************** > + SMBIOS data definition TYPE16 Physical Memory ArrayInformation > +************************************************************************/ > + > +SMBIOS_TABLE_TYPE16 mPhyMemArrayInfoType16 = { > + { EFI_SMBIOS_TYPE_PHYSICAL_MEMORY_ARRAY, sizeof (SMBIOS_TABLE_TYPE16), > 0 }, > + MemoryArrayLocationSystemBoard, // Location; ///< > The enumeration value from MEMORY_ARRAY_LOCATION. > + MemoryArrayUseSystemMemory, // Use; ///< > The enumeration value from MEMORY_ARRAY_USE. > + MemoryErrorCorrectionUnknown, // MemoryErrorCorrection; ///< > The enumeration value from MEMORY_ERROR_CORRECTION. > + 0x80000000, // MaximumCapacity; > + 0xFFFE, // MemoryErrorInformationHandle; > + 1, // NumberOfMemoryDevices; > + 0x3fffffffffffffffULL, // ExtendedMaximumCapacity; > +}; > +CHAR8 *mPhyMemArrayInfoType16Strings[] = { > + NULL > +}; > + > +/*********************************************************************** > + SMBIOS data definition TYPE17 Memory Device Information > +************************************************************************/ > + > +SMBIOS_TABLE_TYPE17 mMemDevInfoType17 = { > + { EFI_SMBIOS_TYPE_MEMORY_DEVICE, sizeof (SMBIOS_TABLE_TYPE17), 0 }, > + 0, // MemoryArrayHandle; > + 0xFFFE, // MemoryErrorInformationHandle; > + 0xFFFF, // TotalWidth; > + 0xFFFF, // DataWidth; > + 0xFFFF, // Size; > + MemoryFormFactorUnknown, // FormFactor; ///< The > enumeration value from MEMORY_FORM_FACTOR. > + 0xff, // DeviceSet; > + 1, // DeviceLocator String > + 2, // BankLocator String > + MemoryTypeDram, // MemoryType; ///< The > enumeration value from MEMORY_DEVICE_TYPE. > + { // TypeDetail; > + 0, // Reserved :1; > + 0, // Other :1; > + 1, // Unknown :1; > + 0, // FastPaged :1; > + 0, // StaticColumn :1; > + 0, // PseudoStatic :1; > + 0, // Rambus :1; > + 0, // Synchronous :1; > + 0, // Cmos :1; > + 0, // Edo :1; > + 0, // WindowDram :1; > + 0, // CacheDram :1; > + 0, // Nonvolatile :1; > + 0, // Registered :1; > + 0, // Unbuffered :1; > + 0, // Reserved1 :1; > + }, > + 0, // Speed; > + 3, // Manufacturer String > + 0, // SerialNumber String > + 0, // AssetTag String > + 0, // PartNumber String > + 0, // Attributes; > + 0, // ExtendedSize; > + 0, // ConfiguredMemoryClockSpeed; > +}; > +CHAR8 *mMemDevInfoType17Strings[] = { > + "OS Virtual Memory", > + "malloc", > + "OSV", > + NULL > +}; > + > +/*********************************************************************** > + SMBIOS data definition TYPE19 Memory Array Mapped Address > Information > +************************************************************************/ > + > +SMBIOS_TABLE_TYPE19 mMemArrMapInfoType19 = { > + { EFI_SMBIOS_TYPE_MEMORY_ARRAY_MAPPED_ADDRESS, sizeof > (SMBIOS_TABLE_TYPE19), 0 }, > + 0x80000000, // StartingAddress; > + 0xbfffffff, // EndingAddress; > + 0, // MemoryArrayHandle; > + 1, // PartitionWidth; > + 0, // ExtendedStartingAddress; > + 0, // ExtendedEndingAddress; > +}; > +CHAR8 *mMemArrMapInfoType19Strings[] = { > + NULL > +}; > + > + > + > + > +/*********************************************************************** > + SMBIOS data definition TYPE32 Boot Information > +************************************************************************/ > + > +SMBIOS_TABLE_TYPE32 mBootInfoType32 = { > + { EFI_SMBIOS_TYPE_SYSTEM_BOOT_INFORMATION, sizeof > (SMBIOS_TABLE_TYPE32), 0 }, > + { 0, 0, 0, 0, 0, 0 }, // Reserved[6]; > + BootInformationStatusNoError // BootStatus > +}; > + > +CHAR8 *mBootInfoType32Strings[] = { > + NULL > +}; > + > + > +/** > + > + Create SMBIOS record. > + > + Converts a fixed SMBIOS structure and an array of pointers to strings > into > + an SMBIOS record where the strings are cat'ed on the end of the fixed > record > + and terminated via a double NULL and add to SMBIOS table. > + > + SMBIOS_TABLE_TYPE32 gSmbiosType12 = { > + { EFI_SMBIOS_TYPE_SYSTEM_CONFIGURATION_OPTIONS, sizeof > (SMBIOS_TABLE_TYPE12), 0 }, > + 1 // StringCount > + }; > + > + CHAR8 *gSmbiosType12Strings[] = { > + "Not Found", > + NULL > + }; > + > + ... > + > + LogSmbiosData ( > + (EFI_SMBIOS_TABLE_HEADER*)&gSmbiosType12, > + gSmbiosType12Strings > + ); > + > + @param Template Fixed SMBIOS structure, required. > + @param StringArray Array of strings to convert to an SMBIOS string > pack. > + NULL is OK. > +**/ > + > + > +EFI_STATUS > +EFIAPI > +LogSmbiosData ( > + IN EFI_SMBIOS_TABLE_HEADER *Template, > + IN CHAR8 **StringPack > + ) > +{ > + > + EFI_STATUS Status; > + EFI_SMBIOS_PROTOCOL *Smbios; > + EFI_SMBIOS_HANDLE SmbiosHandle; > + EFI_SMBIOS_TABLE_HEADER *Record; > + UINTN Index; > + UINTN StringSize; > + UINTN Size; > + CHAR8 *Str; > + > + // > + // Locate Smbios protocol. > + // > + > + Status = gBS->LocateProtocol (&gEfiSmbiosProtocolGuid, NULL, (VOID > **)&Smbios); > + > + if (EFI_ERROR (Status)) { > + > + return Status; > + > + } > + > + > + // Calculate the size of the fixed record and optional string pack > + > + Size = Template->Length; > + > + if (StringPack == NULL) { > + > + // At least a double null is required > + > + Size += 2; > + > + } else { > + > + for (Index = 0; StringPack[Index] != NULL; Index++) { > + > + StringSize = AsciiStrSize (StringPack[Index]); > + > + Size += StringSize; > + > + } > + > + if (StringPack[0] == NULL) { > + > + // At least a double null is required > + > + Size += 1; > + > + } > + > + // Don't forget the terminating double null > + > + Size += 1; > + > + } > + > + > + > + // Copy over Template > + Record = (EFI_SMBIOS_TABLE_HEADER *)AllocateZeroPool (Size); > + > + if (Record == NULL) { > + > + return EFI_OUT_OF_RESOURCES; > + > + } > + > + CopyMem (Record, Template, Template->Length); > + > + > + > + // Append string pack > + > + Str = ((CHAR8 *)Record) + Record->Length; > + > + > + > + for (Index = 0; StringPack[Index] != NULL; Index++) { > + > + StringSize = AsciiStrSize (StringPack[Index]); > + > + CopyMem (Str, StringPack[Index], StringSize); > + > + Str += StringSize; > + > + } > + > + *Str = 0; > + > + SmbiosHandle = SMBIOS_HANDLE_PI_RESERVED; > + > + Status = Smbios->Add ( > + Smbios, > + gImageHandle, > + &SmbiosHandle, > + Record > + ); > + > + ASSERT_EFI_ERROR (Status); > + > + FreePool (Record); > + > + return Status; > + > +} > + > + > + > +/*********************************************************************** > + SMBIOS data update TYPE0 BIOS Information > +************************************************************************/ > + > + > +VOID > +BIOSInfoUpdateSmbiosType0 ( > + VOID > + ) > + > +{ > + > + LogSmbiosData ((EFI_SMBIOS_TABLE_HEADER *)&mBIOSInfoType0, > mBIOSInfoType0Strings); > + > +} > + > + > + > +/*********************************************************************** > + SMBIOS data update TYPE1 System Information > +************************************************************************/ > +VOID > +SysInfoUpdateSmbiosType1 ( > + VOID > + ) > + > +{ > + > + LogSmbiosData ((EFI_SMBIOS_TABLE_HEADER *)&mSysInfoType1, > mSysInfoType1Strings); > + > +} > + > +/*********************************************************************** > + SMBIOS data update TYPE2 Board Information > +************************************************************************/ > +VOID > +BoardInfoUpdateSmbiosType2 ( > + VOID > + ) > + > +{ > + > + LogSmbiosData ((EFI_SMBIOS_TABLE_HEADER *)&mBoardInfoType2, > mBoardInfoType2Strings); > + > +} > + > +/*********************************************************************** > + SMBIOS data update TYPE3 Enclosure Information > +************************************************************************/ > +VOID > +EnclosureInfoUpdateSmbiosType3 ( > + VOID > + ) > + > +{ > + > + LogSmbiosData ((EFI_SMBIOS_TABLE_HEADER *)&mEnclosureInfoType3, > mEnclosureInfoType3Strings); > + > +} > + > + > +/*********************************************************************** > + SMBIOS data update TYPE4 Processor Information > +************************************************************************/ > + > + > +VOID > + > +ProcessorInfoUpdateSmbiosType4 ( > + > + IN UINTN MaxCpus > + > + ) > + > +{ > + > + mProcessorInfoType4.CoreCount = (UINT8) MaxCpus; > + > + mProcessorInfoType4.EnabledCoreCount = (UINT8) MaxCpus; > + > + mProcessorInfoType4.ThreadCount = (UINT8) MaxCpus; > + > + > + > + LogSmbiosData ((EFI_SMBIOS_TABLE_HEADER *)&mProcessorInfoType4, > mProcessorInfoType4Strings); > + > +} > + > + > +/*********************************************************************** > + SMBIOS data update TYPE7 Cache Information > +************************************************************************/ > +VOID > +CacheInfoUpdateSmbiosType7 ( > + VOID > + ) > + > +{ > + > + LogSmbiosData ((EFI_SMBIOS_TABLE_HEADER *)&mCacheInfoType7, > mCacheInfoType7Strings); > + > +} > + > +/*********************************************************************** > + SMBIOS data update TYPE9 System Slot Information > +************************************************************************/ > +VOID > +SysSlotInfoUpdateSmbiosType9 ( > + VOID > + ) > + > +{ > + > + LogSmbiosData ((EFI_SMBIOS_TABLE_HEADER *)&mSysSlotInfoType9, > mSysSlotInfoType9Strings); > + > +} > + > +/*********************************************************************** > + SMBIOS data update TYPE16 Physical Memory Array Information > +************************************************************************/ > +VOID > +PhyMemArrayInfoUpdateSmbiosType16 ( > + VOID > + ) > + > +{ > + > + LogSmbiosData ((EFI_SMBIOS_TABLE_HEADER *)&mPhyMemArrayInfoType16, > mPhyMemArrayInfoType16Strings); > + > +} > + > +/*********************************************************************** > + SMBIOS data update TYPE17 Memory Device Information > +************************************************************************/ > +VOID > +MemDevInfoUpdateSmbiosType17 ( > + VOID > + ) > + > +{ > + > + LogSmbiosData ((EFI_SMBIOS_TABLE_HEADER *)&mMemDevInfoType17, > mMemDevInfoType17Strings); > + > +} > + > +/*********************************************************************** > + SMBIOS data update TYPE19 Memory Array Map Information > +************************************************************************/ > +VOID > +MemArrMapInfoUpdateSmbiosType19 ( > + VOID > + ) > + > +{ > + > + LogSmbiosData ((EFI_SMBIOS_TABLE_HEADER *)&mMemArrMapInfoType19, > mMemArrMapInfoType19Strings); > + > +} > + > + > +/*********************************************************************** > + SMBIOS data update TYPE32 Boot Information > +************************************************************************/ > +VOID > +BootInfoUpdateSmbiosType32 ( > + VOID > + ) > + > +{ > + > + LogSmbiosData ((EFI_SMBIOS_TABLE_HEADER *)&mBootInfoType32, > mBootInfoType32Strings); > + > +} > + > + > +/*********************************************************************** > + Driver Entry > +************************************************************************/ > + > +EFI_STATUS > + > +EFIAPI > + > +UpdateSmbios ( > + > + IN EFI_HANDLE ImageHandle, > + > + IN EFI_SYSTEM_TABLE *SystemTable > + > + ) > + > +{ > + > + BIOSInfoUpdateSmbiosType0(); > + > + SysInfoUpdateSmbiosType1(); > + > + BoardInfoUpdateSmbiosType2(); > + > + EnclosureInfoUpdateSmbiosType3(); > + > + ProcessorInfoUpdateSmbiosType4 (2); > + > + CacheInfoUpdateSmbiosType7(); > + > + SysSlotInfoUpdateSmbiosType9(); > + > + PhyMemArrayInfoUpdateSmbiosType16(); > + > + MemDevInfoUpdateSmbiosType17(); > + > + MemArrMapInfoUpdateSmbiosType19(); > + > + BootInfoUpdateSmbiosType32(); > + > + return EFI_SUCCESS; > + > +} > diff --git a/ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.h > b/ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.h > new file mode 100644 > index 0000000..5757dc7 > --- /dev/null > +++ b/ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.h > @@ -0,0 +1,53 @@ > +/** @file > +Copyright (c) 2009 - 2013, Intel Corporation. All rights reserved.<BR> > +This program and the accompanying materials > +are licensed and made available under the terms and conditions of the BSD > License > +which accompanies this distribution. The full text of the license may be > found at > +http://opensource.org/licenses/bsd-license.php > + > + > +THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > + > +SMBIOS Driver. > + > +yi.li(a)linaro.org > +Copyright (c) 2013 Linaro.org > + > + This program and the accompanying materials are licensed and > +made available under the terms and conditions of the BSD License > +which accompanies this distribution. The full text of the license > +may be found at: http://opensource.org/licenses/bsd-license.php > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > +**/ > + > + > + > +#ifndef _UPDATE_SMBIOS_DRIVER_H_ > +#define _UPDATE_SMBIOS_DRIVER_H_ > + > + > +#include <PiDxe.h> > +#include <Protocol/Smbios.h> > +#include <IndustryStandard/SmBios.h> > +#include <Guid/SmBios.h> > +#include <Library/DebugLib.h> > +#include <Library/UefiDriverEntryPoint.h> > +#include <Library/UefiLib.h> > +#include <Library/BaseLib.h> > +#include <Library/BaseMemoryLib.h> > +#include <Library/MemoryAllocationLib.h> > +#include <Library/UefiBootServicesTableLib.h> > +#include <Library/PcdLib.h> > + > + > +EFI_STATUS > +EFIAPI > +UpdateSmbios ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_SYSTEM_TABLE *SystemTable > + ); > +#endif > + > diff --git a/ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.inf > b/ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.inf > new file mode 100644 > index 0000000..9f8b994 > --- /dev/null > +++ b/ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.inf > @@ -0,0 +1,64 @@ > +## @file > +# > +# Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR> > +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the > BSD License > +# which accompanies this distribution. The full text of the license may > be found at > +# http://opensource.org/licenses/bsd-license.php > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > +# > +## > + > +# SMBIOS Driver. > +# > +# yi.li(a)linaro.org > +# Copyright (c) 2013 Linaro.org > +# > +# This program and the accompanying materials are licensed and > +# made available under the terms and conditions of the BSD License > +# which accompanies this distribution. The full text of the license > +# may be found at: http://opensource.org/licenses/bsd-license.php > + > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > +# BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > +# EXPRESS OR IMPLIED. > + > + > +[Defines] > + INF_VERSION = 0x00010005 > + BASE_NAME = UpdateSmbios > + FILE_GUID = 3847D23F-1D95-4772-B60C-4BBFBC4D532F > + MODULE_TYPE = DXE_DRIVER > + VERSION_STRING = 1.0 > + ENTRY_POINT = UpdateSmbios > + > +[Sources] > + UpdateSmbios.c > + UpdateSmbios.h > + > +[Packages] > + MdePkg/MdePkg.dec > + MdeModulePkg/MdeModulePkg.dec > + ArmPlatformPkg/ArmPlatformPkg.dec > + > +[LibraryClasses] > + UefiBootServicesTableLib > + MemoryAllocationLib > + BaseMemoryLib > + BaseLib > + UefiLib > + UefiDriverEntryPoint > + DebugLib > + PcdLib > + > +[Protocols] > + gEfiSmbiosProtocolGuid # PROTOCOL > SOMETIMES_CONSUMED > + > +[Guids] > + > +[Depex] > + gEfiSmbiosProtocolGuid > + > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc > index 6237e16..aa09ac7 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc > @@ -253,6 +253,12 @@ > EmbeddedPkg/SerialDxe/SerialDxe.inf > > MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > + > + # > + # SMBIOS Support > + # > + MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > + ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.inf > > ArmPkg/Drivers/PL390Gic/PL390GicDxe.inf > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.fdf > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.fdf > index a7cc384..a21afb4 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.fdf > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.fdf > @@ -82,6 +82,12 @@ READ_LOCK_STATUS = TRUE > INF EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf > > INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > + > + # > + # SMBIOS Support > + # > + INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > + INF ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.inf > > # > # Multiple Console IO support > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15x2.dsc > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15x2.dsc > index 37765e9..382fdd6 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15x2.dsc > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15x2.dsc > @@ -276,6 +276,12 @@ > > MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > > + # > + # SMBIOS Support > + # > + MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > + ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.inf > + > ArmPkg/Drivers/PL390Gic/PL390GicDxe.inf > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf > ArmPlatformPkg/Drivers/SP804TimerDxe/SP804TimerDxe.inf > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15x2.fdf > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15x2.fdf > index c3e5a90..1fa1d67 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15x2.fdf > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15x2.fdf > @@ -141,6 +141,12 @@ READ_LOCK_STATUS = TRUE > > INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > > + # > + # SMBIOS Support > + # > + INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > + INF ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.inf > + > INF ArmPkg/Drivers/PL390Gic/PL390GicDxe.inf > INF ArmPlatformPkg/Drivers/SP804TimerDxe/SP804TimerDxe.inf > INF ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA5s.dsc > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA5s.dsc > index b4ce234..fd98a4a 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA5s.dsc > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA5s.dsc > @@ -270,6 +270,12 @@ > > MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > > + # > + # SMBIOS Support > + # > + MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > + ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.inf > + > ArmPkg/Drivers/PL390Gic/PL390GicDxe.inf > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf > ArmPlatformPkg/Drivers/SP804TimerDxe/SP804TimerDxe.inf > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA5s.fdf > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA5s.fdf > index c3e5a90..1fa1d67 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA5s.fdf > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA5s.fdf > @@ -141,6 +141,12 @@ READ_LOCK_STATUS = TRUE > > INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > > + # > + # SMBIOS Support > + # > + INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > + INF ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.inf > + > INF ArmPkg/Drivers/PL390Gic/PL390GicDxe.inf > INF ArmPlatformPkg/Drivers/SP804TimerDxe/SP804TimerDxe.inf > INF ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc > index 10e58b7..d11f87e 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc > @@ -284,6 +284,12 @@ > EmbeddedPkg/SerialDxe/SerialDxe.inf > > MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > + > + # > + # SMBIOS Support > + # > + MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > + ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.inf > > ArmPkg/Drivers/PL390Gic/PL390GicDxe.inf > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.fdf > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.fdf > index d94a721..523c364 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.fdf > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.fdf > @@ -186,6 +186,12 @@ READ_LOCK_STATUS = TRUE > INF EmbeddedPkg/SerialDxe/SerialDxe.inf > > INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > + > + # > + # SMBIOS Support > + # > + INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > + INF ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.inf > > INF ArmPkg/Drivers/PL390Gic/PL390GicDxe.inf > INF ArmPlatformPkg/Drivers/SP804TimerDxe/SP804TimerDxe.inf > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15.dsc > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15.dsc > index 0920313..04aefb0 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15.dsc > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15.dsc > @@ -245,6 +245,12 @@ > EmbeddedPkg/SerialDxe/SerialDxe.inf > > MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > + > + # > + # SMBIOS Support > + # > + MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > + ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.inf > > ArmPkg/Drivers/PL390Gic/PL390GicDxe.inf > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15.fdf > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15.fdf > index 71c66b8..8ec50f9 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15.fdf > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15.fdf > @@ -128,6 +128,12 @@ READ_LOCK_STATUS = TRUE > INF EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf > > INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > + > + # > + # SMBIOS Support > + # > + INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > + INF ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.inf > > # > # Networking stack > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.dsc > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.dsc > index bb74bdc..751508e 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.dsc > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.dsc > @@ -247,7 +247,13 @@ > EmbeddedPkg/SerialDxe/SerialDxe.inf > > MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > - > + > + # > + # SMBIOS Support > + # > + MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > + ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.inf > + > ArmPkg/Drivers/PL390Gic/PL390GicDxe.inf > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf > ArmPkg/Drivers/TimerDxe/TimerDxe.inf > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.fdf > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.fdf > index c1d8f31..91b2f8f 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.fdf > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.fdf > @@ -146,6 +146,12 @@ READ_LOCK_STATUS = TRUE > INF MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf > INF ArmPlatformPkg/Drivers/LAN91xDxe/LAN91xDxe.inf > > + # > + # SMBIOS Support > + # > + INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > + INF ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.inf > + > # > # Multiple Console IO support > # > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A9x4.dsc > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A9x4.dsc > index df17f64..6f2e5f2 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A9x4.dsc > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A9x4.dsc > @@ -257,6 +257,12 @@ > > MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > > + # > + # SMBIOS Support > + # > + MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > + ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.inf > + > ArmPkg/Drivers/PL390Gic/PL390GicDxe.inf > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf > ArmPlatformPkg/Drivers/SP804TimerDxe/SP804TimerDxe.inf > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A9x4.fdf > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A9x4.fdf > index a8e99fd..ba3bf8f 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A9x4.fdf > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A9x4.fdf > @@ -127,6 +127,12 @@ READ_LOCK_STATUS = TRUE > INF EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf > > INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > + > + # > + # SMBIOS Support > + # > + INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > + INF ArmPkg/Drivers/UpdateSmbios/UpdateSmbios.inf > > # > # Networking stack > -- > 1.7.9.5 > >

12 years, 3 months

1
0
0 0

linaro uefi-next 13.09-rc1

by Ryan Harkin

Hi all, The uefi-next.git tree [1] has been updated for the 13.09 cycle. We're at -rc1, but the code freeze is today, so probably not enough time for any changes before the release. Snapshot binaries are available now [2] What's included? Well, not as much as I hoped because I've run out of time. So no ethernet and no SMBIOS patches just yet. Current topic branches: linaro-topic-a5 linaro-topic-a9 linaro-topic-arndale linaro-topic-bds linaro-topic-fvp linaro-topic-misc linaro-topic-origen linaro-topic-panda linaro-topic-tc1 linaro-topic-tc2 As always, you should probably pull and build the "linaro-tracking" branch, not one of the topic branches. The main addition for this release is the (now) upstream aarch64 support. The uefi_rtsm-ve-aemv8.bin snapshot binary will boot on the Aarch64 VE model that is currently available to Linaro internal people from the usual place [4] I've tested A9, TC2, FVP on the snapshot binaries. I tested RTSMs, aarch64 VE model and Arndale on my own build of the code and Dave Long has tested Panda on his own build of the same code. One problem I note for aarch64 is that we don't have a similar fix to this for native building: 4511a19 2012-12-12 BaseTools: allow native building [Leif Lindholm] Probably not a big issue, who would want to compile aarch64 inside a model?? Regards, Ryan. [1] https://git.linaro.org/gitweb?p=arm/uefi/uefi-next.git;a=summary [2] https://snapshots.linaro.org/components/kernel/uefi-next/152 [3] https://snapshots.linaro.org/components/kernel/uefi-next/152/uefi_rtsm-ve-a… [4] https://collaborate.linaro.org/display/ITS/FlexLM+and+Fast+Models

12 years, 3 months

1
1
0 0

[PATCH] Only warn when freeing NULL pointer

by David Long

From: "David A. Long" <dave.long(a)linaro.org> Freeing a NULL pointer does not really have to be considered a fatal error. Signed-off-by: David A. Long <dave.long(a)linaro.org> --- MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c b/MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c index 0ccb524..3333bc7 100644 --- a/MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c +++ b/MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c @@ -811,7 +811,10 @@ FreePool ( { EFI_STATUS Status; - Status = gBS->FreePool (Buffer); - ASSERT_EFI_ERROR (Status); + if (Buffer == NULL) { + DEBUG((EFI_D_WARN, "FreePool: attempt to free NULL pointer\n")); + } else { + Status = gBS->FreePool (Buffer); + ASSERT_EFI_ERROR (Status); + } } - -- 1.8.1.2

12 years, 3 months

2
3
0 0

[PATCH] Add new helper functions for Panda

by David Long

From: "David A. Long" <dave.long(a)linaro.org> Signed-off-by: David A. Long <dave.long(a)linaro.org> --- PandaBoardPkg/Library/PandaBoardLib/PandaBoardHelper.S | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/PandaBoardPkg/Library/PandaBoardLib/PandaBoardHelper.S b/PandaBoardPkg/Library/PandaBoardLib/PandaBoardHelper.S index 6405d16..49fcf53 100644 --- a/PandaBoardPkg/Library/PandaBoardLib/PandaBoardHelper.S +++ b/PandaBoardPkg/Library/PandaBoardLib/PandaBoardHelper.S @@ -23,6 +23,9 @@ GCC_ASM_EXPORT(ArmPlatformPrePiBootAction) GCC_ASM_EXPORT(ArmPlatformGetCorePosition) +GCC_ASM_EXPORT(ArmPlatformIsPrimaryCore) +GCC_ASM_EXPORT(ArmPlatformPeiBootAction) + /** ArmPlatformPrePiBootAction @@ -99,4 +102,18 @@ relocator_end: ASM_PFX(ArmPlatformGetCorePosition): bx lr +ASM_PFX(ArmPlatformIsPrimaryCore): + #Bits 8 through 11 are CPU ID + ldr r1, =0xf00 + and r0, r0, r1 + #id for core0 should be 0 + ldr r1, =0x0 + cmp r0, r1 + moveq r0, #1 + movne r0, #0 + mov pc, lr + +ASM_PFX(ArmPlatformPeiBootAction): + mov pc, lr + ASM_FUNCTION_REMOVE_IF_UNREFERENCED -- 1.8.1.2

12 years, 3 months

2
3
0 0

Having problem with booting panda!!!

by davidson mistral

Hi, I have checked out to the 2012.09.1 branch of the u-boot-linaro-stable source and built the u-boot for panda. It worked fine. Then I enabled the Debug prints and again built the u-boot. But this time the u-boot hanged up in the middle. In my observations, it hanged up at the end of the board_init_f() function in the arch/arm/lib/board.c. At the end it has the relocate_code() function that might cause the problem. Im stuck up with this and any help would be appreciated. Thanks, Davidson. K

12 years, 3 months

1
0
0 0

[PROPOSAL] ARM/FDT: passing multiple binaries to a kernel

by Andre Przywara

Hi, a normal Linux kernel currently supports reading the start and end address of a single binary blob via the FDT's /chosen node. This will be interpreted as the location of an initial RAM disk. The Xen hypervisor itself is a kernel, but needs up to _two_ binaries for proper operation: a Dom0 Linux kernel and it's associated initrd. On x86 this is solved via the multiboot protocol used by the Grub bootloader, which supports to pass an arbitrary number of binary modules to any kernel. Since in the ARM world we have the versatile device tree, we don't need to implement the mulitboot protocol. So I'd like to propose a new binding which denotes binary modules a kernel can use at it's own discretion. The need is triggered by the Xen hypervisor (which already uses a very similar scheme), but the approach is deliberately chosen to be as generic as possible to allow future uses (like passing firmware blobs for devices or the like). Credits for this go to Ian Campbell, who started something very similar [1] for the Xen hypervisor. The intention of this proposal is to make this generic and publicly documented. Looking forward to any comments! Thanks, Andre. [1] http://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/misc/arm/device-tree… ---------------------------- * Multiple boot modules device tree bindings Boot loaders wanting to pass multiple additional binaries to a kernel shall add a node "module" for each binary blob under the /chosen node with the following properties: - compatible: compatible = "boot,module"; A bootloader may add names to more specifically describe the module, e.g. Xen may use "xen,dom0-kernel" or "xen,dom0-ramdisk". If possible a kernel should be able to use modules even without a descriptive naming, by enumerating them in order and using hard-coded meanings for each module (e.g. first is kernel, second is initrd). - reg: specifies the base physical address and size of a region in memory where the bootloader loaded the respective binary data to. - bootargs: An optional property describing arguments to use for this module. Could be a command line or configuration data. Example: /chosen { #size-cells = <0x1>; #address-cells = <0x1>; module@0 { compatible = "xen,linux-zimage", "xen,multiboot-module", "boot,module"; reg = <0x80000000 0x003dcff8>; bootargs = "console=hvc0 earlyprintk ro root=/dev/sda1 nosmp"; }; module@1 { compatible = "xen,linux-initrd", "xen,multiboot-module", "boot,module"; reg = <0x08000000 0x00123456>; }; ...

12 years, 3 months

3
6
0 0

Re: [PROPOSAL] ARM/FDT: passing multiple binaries to a kernel

by Rob Herring

Adding Dennis for a distro perspective. On Wed, Sep 4, 2013 at 3:44 AM, Ian Campbell <Ian.Campbell(a)citrix.com> wrote: > On Tue, 2013-09-03 at 17:00 -0500, Rob Herring wrote: >> On Tue, Sep 3, 2013 at 10:53 AM, Andre Przywara >> <andre.przywara(a)linaro.org> wrote: >> > Hi, >> > >> > a normal Linux kernel currently supports reading the start and end address >> > of a single binary blob via the FDT's /chosen node. >> > This will be interpreted as the location of an initial RAM disk. >> > >> > The Xen hypervisor itself is a kernel, but needs up to _two_ binaries for >> > proper operation: a Dom0 Linux kernel and it's associated initrd. >> > On x86 this is solved via the multiboot protocol used by the Grub >> > bootloader, which supports to pass an arbitrary number of binary modules to >> > any kernel. >> > >> > Since in the ARM world we have the versatile device tree, we don't need to >> > implement the mulitboot protocol. >> >> But surely there would be some advantage of reuse by using the >> multi-boot protocol since Xen, grub, and OS tools already support it >> for x86. > > Multiboot is pretty x86 specific (although MB2 has a MIPS port) and > covers more stuff than we strictly require (e.g. on x86 it has > requirements around which processor mode you enter in, has paging > enabled etc). > >> > So I'd like to propose a new binding which denotes binary modules a kernel >> > can use at it's own discretion. >> > The need is triggered by the Xen hypervisor (which already uses a very >> > similar scheme), but the approach is deliberately chosen to be as generic as >> > possible to allow future uses (like passing firmware blobs for devices or >> > the like). >> > Credits for this go to Ian Campbell, who started something very similar [1] >> > for the Xen hypervisor. The intention of this proposal is to make this >> > generic and publicly documented. >> >> Can you describe how you see the boot flow working starting with OS >> installer writes kernel, initrd, xen and ??? to disk. > > Kernel and initrd are written to /boot in the usual way (probably from > kernel.deb or whatever). Xen would also normally come from a distro > package (also in /boot). > >> How does the bootloader know what to load? > > It's in the bootloader config, e.g. boot.scr or grub.cfg, which are > either hand written or produced by the distros tooling. > > grub on ARM could consume the same stanzas as are used by grub on x86 to > boot Xen (which are produced by update-grub): > echo 'Loading Xen 4.1-amd64 ...' > multiboot /xen-4.1-amd64.gz placeholder > echo 'Loading Linux 3.10-2-amd64 ...' > module /vmlinuz-3.10-2-amd64 placeholder root=/dev/mapper/disks-root ro resume=/dev/mapper/disks-swap quiet > echo 'Loading initial ramdisk ...' > module /initrd.img-3.10-2-amd64 > > Since there is no multiboot on ARM (and never will be) this is safe. > > If multiboot ever does come to ARM it will necessarily be multiboot2 > which uses a different keyword. Right, this is just a text file with a list of binaries. It is not really the multiboot spec. There is no reason for this part to be different for grub on ARM. There is a big advantage to reusing the distro side tooling. If there isn't really much reuse on the bootloader side, then I'm fine with a different bootloader to Xen interface. I would like to hear that from folks working on grub though. > For u-boot Andre has proposed some syntactic sugar over the "fdt" > command to make boot.scr more trivial to use. We would of course need to > implement support for using it in the relevant distro tools (but they > tend to be very distro/machine specific already, e.g. Debian's > flash-kernel) And being machine specific is a PITA. flash-kernel is certainly not something we want to expand on. There is not much love for boot.scr either. There is work to address what are not really machine differences, but largely vendor u-boot differences: http://www.mail-archive.com/u-boot@lists.denx.de/msg119025.html One option for u-boot which already supports syslinux style menu files is to adopt the syslinux multiboot parsing support: http://www.syslinux.org/wiki/index.php/Doc/mboot We need to back-up and consider what this looks like in the end for all the pieces and get input from folks on grub, UEFI, and armv8. The UEFI answer may be this is a grub problem. For armv8, this proposal does match up well as the kernel boot interface for v8 is DT. Despite some claims, ACPI will not completely replace DT because of this. Rob

12 years, 3 months

2
3
0 0

Re: [PROPOSAL] ARM/FDT: passing multiple binaries to a kernel

by Grant Likely

On Fri, 13 Sep 2013 12:22:13 +0100, Ian Campbell <Ian.Campbell(a)citrix.com> wrote: > On Fri, 2013-09-13 at 11:13 +0100, Grant Likely wrote: > > On Wed, Sep 4, 2013 at 5:41 PM, Rob Herring <robherring2(a)gmail.com> wrote: > > >> For u-boot Andre has proposed some syntactic sugar over the "fdt" > > >> command to make boot.scr more trivial to use. We would of course need to > > >> implement support for using it in the relevant distro tools (but they > > >> tend to be very distro/machine specific already, e.g. Debian's > > >> flash-kernel) > > > > > > And being machine specific is a PITA. flash-kernel is certainly not > > > something we want to expand on. There is not much love for boot.scr > > > either. There is work to address what are not really machine > > > differences, but largely vendor u-boot differences: > > > > > > http://www.mail-archive.com/u-boot@lists.denx.de/msg119025.html > > > > > > One option for u-boot which already supports syslinux style menu files > > > is to adopt the syslinux multiboot parsing support: > > > > > > http://www.syslinux.org/wiki/index.php/Doc/mboot > > > > Even building it into U-Boot is problematic because it leaves older > > machines out in the cold. Leif's port of Grub to U-Boot is far more > > interesting since the distro can now be in control of the code that > > loads the images and jumps into the kernel/hypervisor. > > AIUI this is not being developed any further? Last I checked the patches have been posted for merging, but it is stalled on the Grub maintainer. I believe he wanted to fix a bug on the raspberry pi before merging. Leif would know more. LEG isn't actively working on it anymore since UEFI is the priority, but I wouldn't call it abandoned. > > > We need to back-up and consider what this looks like in the end for > > > all the pieces and get input from folks on grub, UEFI, and armv8. The > > > UEFI answer may be this is a grub problem. For armv8, this proposal > > > does match up well as the kernel boot interface for v8 is DT. Despite > > > some claims, ACPI will not completely replace DT because of this. > > > > Yes, for UEFI it is absolutely an OS loader problem. UEFI provides an > > API and runtime environment. Grub is in general moving towards a boot > > menu system and a tool for loading images. Actual booting however > > should be done by a separate OS loader application. For Linux, this > > will be an in-kernel UEFI Stub. > > I'm not sure I follow your distinction between loading the images and > "actual booting". If grub loads the images and Linux stub does the > actual booting how does this stub locate the images which grub loaded? (Note: this isn't implemented yet, but is in progress) The DTB will need to be passed via the UEFI system table. Initrd is passed by modifying the dtb with linux,initrd-* properties in the device tree. In the Xen case, I think the original proposal is conceptually sound. I'll quibble about a couple of the details, but I'll address those with a reply to the original proposal. It makes perfect sense to use the same mechanism as the initrd properties to tell the kernel about additional blobs. > Or are you saying the stub should load the initramfs itself? How does it > know where to find it? Having the kernel in one config file (grub's) and > the initramfs in another (the Linux UEFI stub's) seems likely to result > in things getting out of sync. Having Linux's stub parse the grub CFG is > even less likely to work well IMHO. The stub has the ability to load both the dtb and initrd itself by adding "dtb=" and "initrd=" arguments, but it is currently limited to loading images from the same filesystem that the kernel was loaded from. GRUB (or gummiboot/refind/etc) is potentially more flexible. > > For Xen I would recommend taking the > > Linux EFI stub code and doing the same thing. There really isn't a > > need for a multiboot spec when you can rely on a runtime execution > > environment for setting things up exactly as you want them. > > If this works for Linux on EFI then I see no reason it could work for > Xen on EFI (assuming my questions above are just a result of my > misunderstanding something) > > But... Xen also wants to support non-server and therefore non-EFI > systems i.e. u-boot. We also want to support v7 where EFI is not a given > even for servers AIUI. I was only responding to the UEFI question, but that aside, I don't see a problem with adding properties to the DT for telling Xen where they are. > Given that I think it is a given that Xen will have some sort of > protocol along these lines, for use in these environments even if it > does the EFI stub thing on EFI systems. The question is shall we make it > more general and useful to others or just go our own way? I'd prefer to > do the former. Yes, make it general. GRUB and the EFI stub will use it. g.

12 years, 3 months

1
0
0 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

boot-architecture