On Mon, Jun 21, 2021 at 1:53 PM Grant Likely grant.likely@arm.com wrote:
On 21/06/2021 18:35, Atish Patra wrote:
On Mon, Jun 21, 2021 at 10:19 AM Grant Likely grant.likely@arm.com wrote:
On 10/05/2021 18:37, Atish Patra wrote:
[...]
+UEFI Boot at S mode +^^^^^^^^^^^^^^^^^^^^^^
+Most systems are expected to boot UEFI at S mode as the hypervisor extension [RVHYPSPEC]_ is +still in draft state.
I just noticed this. If the hypervisor spec is still in draft, then why is it being referenced by EBBR? Shouldn't that spec be made final first, or at least commonly deployed?
The hypervisor spec is still in draft but the details of privilege modes will not change. In fact, there has been almost zero change in the last one year. It has been in draft stage for various other reasons but not related to the technical ones ;) It's already been implemented in an FPGA and a working KVM port is available [1]. We are hoping that it will be merged by the end of this year.
[1] https://lwn.net/Articles/856685/
+UEFI Boot at HS mode +^^^^^^^^^^^^^^^^^^^^
+Any platform with hypervisor extension enabled most likely to boot UEFI at HS mode, +to allow for the installation of a hypervisor or a virtualization aware Operating System.
This sounds like it should be more tightly written. How about:
On platforms with the hypervisor extension enabled UEFI code should be executed in HS mode to allow installation of a hypervisor or a virtualization aware operating system.
Looks good.
Still with the hypervisor extension in draft I wonder if it would be better to leave these bits out for now.
As we just talk about the privilege modes here and that is unlikely to change, this section will not change in future.
diff --git a/source/index.rst b/source/index.rst index 48318757f717..acd214d25323 100644 --- a/source/index.rst +++ b/source/index.rst @@ -1,5 +1,6 @@ .. EBBR Source Document Copyright Arm Limited, 2017-2019
- Copyright Western Digital Corporation or its affiliates, 2021
I don't think this is valid for a copyright message. In fact, the Arm line above it is also wrong. It should be specific to the copyright owner without the "or its affiliates". Is it okay by you if Idrop that last bit.
That's the copyright line we got from Western Digital lawyer because Western Digital has many subsidiaries (as a result of acquisitions) In fact, our group was part of HGST until recently. We have the same copyright in other open source projects (Kernel, OpenSBI, U-Boot)
Good enough for me. I'm leaving it as is.
I've pushed my edited copy out to a temporary branch. You can see it here:
https://github.com/ARM-software/ebbr/commit/9d4632a3911fd460cb1adf6a5b1a2b13...
The updated commit Looks good to me.
g.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-- Regards, Atish