Acked-by: Deprez, Olivier o-deprez@ti.com
Texas Instruments France SA, 821 Avenue Jack Kilby, 06270 Villeneuve Loubet. 036 420 040 R.C.S Antibes. Capital de EUR 12.654.784
-----Original Message----- From: Ryan Harkin [mailto:ryan.harkin@linaro.org] Sent: Monday, February 11, 2013 7:16 PM To: Jordan Justen Cc: boot-architecture@lists.linaro.org; Patch Tracking; Deprez, Olivier; Leif Lindholm; Fathi Boudra; edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] panda: build.sh: change RELEASE/DEBUG param handling
On 11 February 2013 16:41, Ryan Harkin ryan.harkin@linaro.org wrote:
On 11 February 2013 16:08, Jordan Justen jljusten@gmail.com wrote:
On Mon, Feb 11, 2013 at 12:22 AM, Ryan Harkin ryan.harkin@linaro.org wrote:
The attached patch changes the PandaBoardPkg/build.sh script RELEASE or DEBUG parameter handling.
Before this patch, build.sh can be called thus: ./build.sh ./build.sh -b DEBUG ./build.sh RELEASE
This patch simplifies the way you pass the debug/release parameter into build.sh so that build scripts can simply pass DEBUG or RELEASE, without having to create a special case to add the "-b".
In similar scripts under edk2 we force the use of -b to keep the script as a wrapper to the edk2-buildtools 'build' command. (EmulatorPkg, OvmfPkg)
Thanks for the input. I've just realised of course that my mods mean that the "target" can only realistically be "DEBUG" or "RELEASE", whereas, forcing the -b would allow the user to pass in any other (theoretical) target.
Leif (CC'd) already commented on this aspect in another discussion I had with him, but it seems I ignored him...
I'll re-work the patch
I've attached a re-worked patch. And it's simpler than the previous version, which is nice.
Now, you can call:
./build.sh ./build.sh -b DEBUG ./build.sh -b RELEASE