Instead of using: #if !defined(MDEPKG_NDEBUG) (...) #endif

It would be better to use: DEBUG_CODE_BEGIN(); (...) DEBUG_CODE_END();

The reason is you can be in debug build and disable debug code (and/or disable other things such as ASSERT). See definition of PcdDebugPropertyMask for the full list of debug properties.

The EDK2 coding convention (http://sourceforge.net/projects/edk2/files/General%20Documentation/EDK%20II %20C%20Coding%20Standards%20Specification.pdf/download) says we should not write this kind of variable declaration: EFI_STATUS Status = EFI_INVALID_PARAMETER;

See page 30: "Initializing a variable as part of its declaration is illegal."

-----Original Message----- From: boot-architecture-bounces@lists.linaro.org [mailto:boot- architecture-bounces@lists.linaro.org] On Behalf Of Ryan Harkin Sent: 13 February 2013 15:06 To: Rony Nandy; Reece Pollack; boot-architecture@lists.linaro.org; Patch Tracking; Linaro Dev; linaro-enterprise mailing list Subject: [PATCH] Samsung/Arndale: fix RELEASE build with ARMLINUXGCC

The attached patch from Reece has already been applied to uefi-next as part of 13.02-rc5. But it's still open for review...