On 18/05/2018 14:18, Tom Rini wrote:

On Fri, May 18, 2018 at 02:06:08PM +0100, Grant Likely wrote:

...

Use reStructuredText citation markup to capture all referenced documents. Sphinx will take care of creating a table of references at the end of the document.

Fixes #6 Signed-off-by: Grant Likely grant.likely@arm.com

[snip]

...

@@ -132,22 +115,11 @@ This document defines the boot and runtime services that are expected by an Operating System or hypervisor, for an ARM embedded device, which follows the UEFI specification. -This document references the following specification and versions:

• UEFI 2.7

•  Published June 2017, includes the AArch64 bindings.
  

Is it clear enough when rendering the final document that here we don't need a link down to the UEFI reference?

Not sure what you mean. Can you elaborate?

I do think the introduction chapter needs to be reworked anyway to talk about standardizing the firmware interface. It too quickly jumps to "when UEFI is chosen", when what I'd rather it present is "here is a standardized platform taylored to embedded systems"... and then get to UEFI is part of that standard.

(it isn't about chosing UEFI; it is about choosing a standard platform)

...

This specification defines the boot and runtime services for a physical system, including services that are required for virtualization. It does not define a standardized abstract virtual machine view for a Guest Operating System. -When present with in a system, this document makes additional references to the -Power State Coordination Interface:

• PSCI 1.1

•  Published April 2017.
  

[snip]

...

@@ -306,9 +278,10 @@ command:

• EfiWarmReset()

-.. note:: When Runtime Services and PSCI co-exist, it is anticipated that

• Operating System calls to reset the system will go via Runtime Services and
• not directly to PSCI.

+.. note:: On platforms implementing the Power State Coordination Interface

• specification[PSCI_], it is still required that EBBR compliant
• Operating Systems calls to reset the system will go via Runtime Services
• and not directly to PSCI.

Set Variable

---

Is all of the above equivalent in terms of talking about PSCI? Thanks!

Ummm, yes? But I'm not sure that I understand what you're asking.

Thanks for the reviews on all the other patches.

g.