-----Original Message----- From: linux-omap-owner@vger.kernel.org [mailto:linux-omap- owner@vger.kernel.org] On Behalf Of Amit Kucheria Sent: Monday, October 04, 2010 2:27 PM To: Sripathy, Vishwanath Cc: Kevin Hilman; linux-omap@vger.kernel.org; linaro-dev@lists.linaro.org Subject: Re: [PATCH 2/2] OMAP3 PM: sleep code clean up
On 10 Oct 04, Sripathy, Vishwanath wrote:
Kevin,
[snip]
But this also makes me wonder, if we're going to clean this up, the
bulk
of it could be re-written in C, with some inline asm helpers as needed.
Probably yes. But as this code is specific to OMAP3, do you think it's worth spending time on rewriting the entire code in C? It might be a significant effort and it will not be reusable for other ARM SOCs.
The C code will be more maintainable and offer more opportunities to refactor across OMAP flavours - perhaps OMAP4 as well.
I'm also interested in code reuse across other SoCs. We've got to be able to shut down the ARM core using common code instead of each SoC copying buggy code from each other. Could you list reasons why you don't think the code is re-usable?
Trust zone implementation and it's varients