linaro-dev November 2014

linaro-dev@lists.linaro.org

21 participants
27 discussions

by pi-cheng.chen

This set adds a script to tune parameters in JSON files and fixes all trailing commas in example JSON files. changes v1 to v2: merge example6.json into example2.json pi-cheng.chen (2): Add a script to tune parameters in json file. Fix all trailing commas in /doc/examples/* doc/examples/browser.json | 36 ++++++------ doc/examples/example1.json | 6 +- doc/examples/example2.json | 7 ++- doc/examples/example3.json | 8 +-- doc/examples/example4.json | 8 +-- doc/examples/mp3.json | 16 +++--- doc/tune_json.py | 138 +++++++++++++++++++++++++++++++++++++++++++++ 7 files changed, 179 insertions(+), 40 deletions(-) create mode 100755 doc/tune_json.py -- 1.9.1

9 years, 1 month

[Activity] LAVA team weekly report, week 48

by lava-team＠linaro.org

**************** Team Work Logged **************** # stylesen Progress # * LAVA-1429 - Dispatcher Refactoring * LAVA-1568 - DF: Change the log structure (100.0%) * Avoid repeating logs everywhere - std logs, yaml logs, top level action logs, etc. * Addressed review comments on stdout log with the latest patch - got merged. * More work on log structure changes for dispatcher refactoring: * Fix unit tests to use a temporary scratch directory * Remove all usage of python logging module directly - instead use YamlLogger * LAVA-1429 - Dispatcher Refactoring * LAVA-1401 - DF: Implement basic use cases for Panda, BBB (25.0%) * Reviewed and merged latest conf for panda and panda-es * Reviewed and merged patchset. * Fix power commands usage from device configs - https://review.linaro.org/3714 * LAVA-1317 - LAVA Dispatcher * LAVA-1551 - Add support for OPKG (assume target image dependencies exist) to lava-test-shell dependencies (7.14%) * Reviewed the patchset and tested it locally. Added review comments regarding 'opkg' support in the patchset review. * Merged patchset after review (for review comments) and test in local environment. # remi.duraffort(a)st.com Progress # * LAVA-1317 - LAVA Dispatcher * LAVA-1318 - Integrate the b2120 (70.0%) * The script is working (uploading on snapshots) but they are public for the moment. I will add the BUILD-info.txt tomorrow. * Finish the script and show it to Cedric for testing. * LAVA-1317 - LAVA Dispatcher * LAVA-1375 - LC: B2120 in LAVA (30.0%) * Fix the boot of the b2120stxh407 that is in the lab. It was not working after the lab move. It's now running correctly. # gesha Progress # * LAVA-1317 - LAVA Dispatcher * LAVA-1551 - Add support for OPKG (assume target image dependencies exist) to lava-test-shell dependencies (100.0%) * Thinking on how to test this feature. # stevan.radakovic Progress # * LAVA-1608 - General Team Items * LAVA-1592 - Stevan's Bugs (38.46%) * Creating clone instance with db dump from production. * Fixed. * Async=false had to be removed since chrome doesn't support it. Moving bunch of code to callback function. * LAVA-1536 - LAVA Server * LAVA-1576 - My subscriptions page (61.54%) * New page, implementing listing all filter subscriptions first. * Implementing image reports subscriptions table. # neil.williams(a)linaro.org Progress # * LAVA-1429 - Dispatcher Refactoring * LAVA-1401 - DF: Implement basic use cases for Panda, BBB (100.0%) # milo Progress # * LAVA-1511 - Upstream Kernel CI * LAVA-1641 - 2. Filtering Distributed Results (100.0%) * Updated data model with new fields and imported new data on staging. * Added new fields to data model and fixed convert script. * Add new field to data model, fix frontend. * Created new view to fix old links landing page. **************** Team In-Progress **************** # georgy.redkozubov(a)linaro.org Plan # * LAVA-1710 - Create tests * LAVA-1692 - Further design discussion meeting with tyler, senthil, alan in preparation for TI meeting # milo.casagrande(a)linaro.org Plan # * LAVA-1683 - Fix API URLs - remove redundant /api/ * LAVA-1651 - Health monitoring for components * LAVA-1726 - Monitor staging instance for multi lab boot reports # neil.williams(a)linaro.org Plan # * LAVA-1614 - Create OpenTAC DeviceTree overlay data * LAVA-1707 - Implement customisable timeout support * LAVA-1401 - DF: Implement basic use cases for Panda, BBB # remi.duraffort(a)linaro.org Plan # * LAVA-1680 - Factorize utils functions in a specific module * LAVA-1580 - Download Helper * LAVA-1625 - Work with ITS/Systems to create private snapshots directory * LAVA-1577 - VCS Helper class # senthil.kumaran(a)linaro.org Plan # * LAVA-1718 - Separate module for logging * LAVA-1733 - Remove logging module imports everywhere * LAVA-1568 - DF: Change the log structure # stevan.radakovic(a)linaro.org Plan # * LAVA-1576 - My subscriptions page * LAVA-1629 - 808 # tyler.baker(a)linaro.org Plan # * LAVA-1713 - 816 * LAVA-1712 - 859 * LAVA-1606 - Tyler's Bugs * LAVA-1524 - ARM KVM boot testing * LAVA-1520 - Create LAVA boot report and submit to kernel ci dashboard

9 years, 4 months

libjpeg-turbo v1.4 porting to android

by Neil Wong

hi, all: Now i had been uploaded libjpeg-turbo code to git.linaro.org, you can download code by git clone https://git.linaro.org/people/neil.wong/libjpeg-turbo.git, it include patch based on libjpeg-turbo SVN:1410, version 1.4 or 1.3.90, and i also uploaded the total package under code directory. This package based on Ragesh' patch, and i fix some bug and rewrite some code based on newest jpeg-turbo code, and this package can pass tjunittest test, and i also added rgba8888 bitmap file support, and new package use CLZ, it will reduce memory usage 64k bytes, and have above 2x speed than old jpeg library with neon support, and now this is a roughly release, you can replace your jpeg library with it and have a try. thanks. Neil

9 years, 4 months

[ACTIVITY] Week47

by Vishal Bhoj

== Progress == * Android Release (60%) * DNS issue on TC2 and (20%) * ARA (20%) == Plans == * ARA stuff Regards, Vishal

9 years, 4 months

[ACTIVITY] Week47

by Wookey

== Progress == * Added i386 cross-toolchain builds for jessie * Moved cross-toolchains to emdebian.org site * Merged plethora of cross-toolchain wiki pages (more to do!) * Lots of cross-toolchian build-design debate * Scheduled multiarch version unskew builds * Rebuilds for all docbook-bug affected arm64 packages * Upgraded desktop to jessie = Plans == get standalone builds working == Issues == Cross-toolchain build-method disagreements Wookey -- Principal hats: Linaro, Wookware, ARM http://wookware.org/

9 years, 4 months

[PATCH] idlestat: Replace asserts with proper error handlings

by pi-cheng.chen

Replace asserts with displaying error messages and/or terminating program in a controlled manner. Also refine some error handling paths. Signed-off-by: Pi-Cheng Chen <pi-cheng.chen(a)linaro.org> --- energy_model.c | 3 --- idlestat.c | 62 +++++++++++++++++++++++++++++++++++++++++++--------------- topology.c | 12 ++++++------ 3 files changed, 52 insertions(+), 25 deletions(-) diff --git a/energy_model.c b/energy_model.c index 87ea3a8..b564ec6 100644 --- a/energy_model.c +++ b/energy_model.c @@ -3,7 +3,6 @@ #include <string.h> #include <stdbool.h> #include <errno.h> -#include <assert.h> #include "energy_model.h" #include "idlestat.h" @@ -92,8 +91,6 @@ int parse_energy_model(struct program_options *options) char *path = options->energy_model_filename; int ret; - assert(path != NULL); - f = fopen(path, "r"); if (!f) { if (errno == ENOENT) { diff --git a/idlestat.c b/idlestat.c index eff04e5..5bd2a14 100644 --- a/idlestat.c +++ b/idlestat.c @@ -40,7 +40,6 @@ #include <sys/types.h> #include <sys/resource.h> #include <sys/wait.h> -#include <assert.h> #include "idlestat.h" #include "utils.h" @@ -647,7 +646,8 @@ static int alloc_pstate(struct cpufreq_pstates *pstates, unsigned int freq) tmp = realloc(pstate, sizeof(*pstate) * (nrfreq + 1)); if (!tmp) { - perror("realloc pstate"); + fprintf(stderr, "%s: Failed ot realloc memory for pstate. " + "Exiting.\n", __func__); return -1; } pstate = tmp; @@ -864,7 +864,8 @@ static void cpu_change_pstate(struct cpuidle_datas *datas, int cpu, next = freq_to_pstate_index(ps, freq); if (next < 0) next = alloc_pstate(ps, freq); - assert(next >= 0); + if (next < 0) + exit(1); switch (cur) { case 1: @@ -1090,15 +1091,24 @@ static int get_wakeup_irq(struct cpuidle_datas *datas, char *buffer, int count) char irqname[NAMELEN+1]; if (strstr(buffer, "irq_handler_entry")) { - assert(sscanf(buffer, TRACE_IRQ_FORMAT, &cpu, &irqid, - irqname) == 3); + if (sscanf(buffer, TRACE_IRQ_FORMAT, &cpu, &irqid, + irqname) != 3) { + fprintf(stderr, "warning: Unrecognized" + "irq_handler_entry record. Skip it.\n"); + return -1; + } store_irq(cpu, irqid, irqname, datas); return 0; } if (strstr(buffer, "ipi_entry")) { - assert(sscanf(buffer, TRACE_IPIIRQ_FORMAT, &cpu, irqname) == 2); + if (sscanf(buffer, TRACE_IPIIRQ_FORMAT, &cpu, irqname) != 2) { + fprintf(stderr, "warning: Unrecognized ipi_entry" + "record. Skip it.\n"); + return -1; + } + irqname[strlen(irqname) - 1] = '\0'; store_irq(cpu, -1, irqname, datas); return 0; @@ -1128,20 +1138,23 @@ struct cpuidle_datas *idlestat_load(struct program_options *options) if (strstr(buffer, "idlestat")) { options->format = IDLESTAT_HEADER; fgets(buffer, BUFSIZE, f); - assert(sscanf(buffer, "cpus=%u", &nrcpus) == 1); + if (sscanf(buffer, "cpus=%u", &nrcpus) != 1) + nrcpus = 0; fgets(buffer, BUFSIZE, f); } else if (strstr(buffer, "# tracer")) { options->format = TRACE_CMD_HEADER; while(!feof(f)) { if (buffer[0] != '#') break; - if (strstr(buffer, "#P:")) - assert(sscanf(buffer, "#%*[^#]#P:%u", &nrcpus) == 1); + if (strstr(buffer, "#P:") && + sscanf(buffer, "#%*[^#]#P:%u", &nrcpus) != 1) + nrcpus = 0; fgets(buffer, BUFSIZE, f); } } else { fprintf(stderr, "%s: unrecognized import format in '%s'\n", __func__, options->filename); + fclose(f); return NULL; } @@ -1185,8 +1198,13 @@ struct cpuidle_datas *idlestat_load(struct program_options *options) do { if (strstr(buffer, "cpu_idle")) { - assert(sscanf(buffer, TRACE_FORMAT, &time, &state, - &cpu) == 3); + if (sscanf(buffer, TRACE_FORMAT, &time, &state, &cpu) + != 3) { + fprintf(stderr, "warning: Unrecognized cpuidle" + "record. The result of analysis might " + "be wrong.\n"); + continue; + } if (start) { begin = time; @@ -1198,8 +1216,13 @@ struct cpuidle_datas *idlestat_load(struct program_options *options) count++; continue; } else if (strstr(buffer, "cpu_frequency")) { - assert(sscanf(buffer, TRACE_FORMAT, &time, &freq, - &cpu) == 3); + if (sscanf(buffer, TRACE_FORMAT, &time, &freq, &cpu) + != 3) { + fprintf(stderr, "warning: Unrecognized cpufreq" + "record. The result of analysis might " + "be wrong.\n"); + continue; + } cpu_change_pstate(datas, cpu, freq, time); count++; continue; @@ -1524,8 +1547,11 @@ static int idlestat_store(const char *path, double start_ts, double end_ts, if (ret < 0) return -1; - if (initp) - assert(ret == initp->nrcpus); + if (initp && ret != initp->nrcpus) { + fprintf(stderr, "%s: The number of CPUs is inconsistency\n", + __func__); + return -1; + } f = fopen(path, "w+"); @@ -1716,7 +1742,11 @@ int main(int argc, char *argv[], char *const envp[]) if ((options.mode == TRACE) || args < argc) { /* Read cpu topology info from sysfs */ - read_sysfs_cpu_topo(); + if (read_sysfs_cpu_topo()) { + fprintf(stderr, "Failed to read CPU topology info from" + " sysfs.\n"); + return 1; + } /* Stop tracing (just in case) */ if (idlestat_trace_enable(false)) { diff --git a/topology.c b/topology.c index 92521e1..eddd479 100644 --- a/topology.c +++ b/topology.c @@ -34,7 +34,6 @@ #include <dirent.h> #include <ctype.h> #include <sys/stat.h> -#include <assert.h> #include "list.h" #include "utils.h" @@ -313,8 +312,11 @@ static int topo_folder_scan(char *path, folder_filter_t filter) closedir(dir_topology); read_topology_cb(newpath, &cpu_info); - assert(sscanf(direntp->d_name, "cpu%d", - &cpu_info.cpu_id) == 1); + if (sscanf(direntp->d_name, "cpu%d", + &cpu_info.cpu_id) != 1) { + ret = -1; + goto out_free_newpath; + } add_topo_info(&g_cpu_topo_list, &cpu_info); } @@ -341,9 +343,7 @@ int init_cpu_topo_info(void) int read_sysfs_cpu_topo(void) { - topo_folder_scan("/sys/devices/system/cpu", cpu_filter_cb); - - return 0; + return topo_folder_scan("/sys/devices/system/cpu", cpu_filter_cb); } int read_cpu_topo_info(FILE *f, char *buf) -- 1.9.1

9 years, 5 months

[ACTIVITY] Week 47

by Riku Voipio

== Progress == * New script to run KVM tests with trusty/utopic guests (DEVPLAT-264 20%) * Moving CI towards utopic and other CI fixes (30%) * Stand-alone Perf recipe for OE (CARD-1653 50%) == Plans == * Switch kvm/xen guest images, DEVPLAT-264 * Find out the needed next steps for ARMv8 slaves (CARD-1729)

9 years, 5 months

[ACTIVITY] Week46

by Vishal Bhoj

== Progress == * SELinux configs merged into linux-linaro. (5%) * L updates and fixes to CI loop (95%) == Plans == * Android releases. Regards, Vishal

9 years, 5 months

[ACTIVITY] Week46

by Wookey

== Progress == * Updated xbuilder to 1.1. Uploaded to Debian (NEW) * Ran cross-build tests on Jessie with new toolchains: https://people.linaro.org/~wookey/buildd/testing/sbuild/latest/status.html * Set up new emdebian server after crack. * Cross-toolchain design work with team - udated wiki * Fixed up cross-gcc 4.9.2-2 dependency strictness * Uploaded cross-binutils 0.16 and cross-gcc 4.9.2-2 * 4 months of expenses done = Plans == Get new toolchains available from emdebian.org get standalone builds working == Issues == Cross-toolchain build-method disagreements Wookey -- Principal hats: Linaro, Debian, Wookware, ARM http://wookware.org/

9 years, 5 months

[ACTIVITY] Week 46

by Bernhard Rosenkränzer

== Progress == * Got AOSP master to build with clang again after the L release merge broke it badly * Upstreamed 89 related patches * Added workarounds for extended cbuild.validation.linaro.org downtime to toolchain build scripts == Plans == * Toolchain and NDK releases * Fix up AOSP master clang build * Upstream remaining patches * Check (and probably fix) AOSP master clang builds for Aarch64 == Issues == * none

9 years, 5 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

linaro-dev November 2014