linaro-dev January 2013

linaro-dev@lists.linaro.org

82 participants
82 discussions

[PATCH V2 Resend 0/4] Create sched_select_cpu() and use it for workqueues and timers

by Viresh Kumar

Hi All, This is V2 Resend of my sched_select_cpu() work. Resend because didn't got much attention on V2. Including more guys now in cc :) In order to save power, it would be useful to schedule work onto non-IDLE cpus instead of waking up an IDLE one. To achieve this, we need scheduler to guide kernel frameworks (like: timers & workqueues) on which is the most preferred CPU that must be used for these tasks. This patchset is about implementing this concept. - The first patch adds sched_select_cpu() routine which returns the preferred cpu which is non-idle. - Second patch removes idle_cpu() calls from timer & hrtimer. - Third patch is about adapting this change in workqueue framework. - Fourth patch add migration capability in running timer Earlier discussions over v1 can be found here: http://www.mail-archive.com/linaro-dev@lists.linaro.org/msg13342.html Earlier discussions over this concept were done at last LPC: http://summit.linuxplumbersconf.org/lpc-2012/meeting/90/lpc2012-sched-timer… Module created for testing this behavior is present here: http://git.linaro.org/gitweb?p=people/vireshk/module.git;a=summary Following are the steps followed in test module: 1. Run single work on each cpu 2. This work will start a timer after x (tested with 10) jiffies of delay 3. Timer routine queues a work... (This may be called from idle or non-idle cpu) and starts the same timer again STEP 3 is done for n number of times (i.e. queuing n works, one after other) 4. All works will call a single routine, which will count following per cpu: - Total works processed by a CPU - Total works processed by a CPU, which are queued from it - Total works processed by a CPU, which aren't queued from it Setup: ----- - ARM Vexpress TC2 - big.LITTLE CPU - Core 0-1: A15, 2-4: A7 - rootfs: linaro-ubuntu-nano Results: ------- Without Workqueue Modification, i.e. PATCH 3/3: [ 2493.022335] Workqueue Analyser: works processsed by CPU0, Total: 1000, Own: 0, migrated: 0 [ 2493.047789] Workqueue Analyser: works processsed by CPU1, Total: 1000, Own: 0, migrated: 0 [ 2493.072918] Workqueue Analyser: works processsed by CPU2, Total: 1000, Own: 0, migrated: 0 [ 2493.098576] Workqueue Analyser: works processsed by CPU3, Total: 1000, Own: 0, migrated: 0 [ 2493.123702] Workqueue Analyser: works processsed by CPU4, Total: 1000, Own: 0, migrated: 0 With Workqueue Modification, i.e. PATCH 3/3: [ 2493.022335] Workqueue Analyser: works processsed by CPU0, Total: 1002, Own: 999, migrated: 3 [ 2493.047789] Workqueue Analyser: works processsed by CPU1, Total: 998, Own: 997, migrated: 1 [ 2493.072918] Workqueue Analyser: works processsed by CPU2, Total: 1013, Own: 996, migrated: 17 [ 2493.098576] Workqueue Analyser: works processsed by CPU3, Total: 998, Own: 993, migrated: 5 [ 2493.123702] Workqueue Analyser: works processsed by CPU4, Total: 989, Own: 987, migrated: 2 V2->V2-Resend ------------- - Included timer migration patch in the same thread. V1->V2 ----- - New SD_* macros removed now and earlier ones used - sched_select_cpu() rewritten and it includes the check on current cpu's idleness. - cpu_idle() calls from timer and hrtimer removed now. - Patch 2/3 from V1, removed as it doesn't apply to latest workqueue branch from tejun. - CONFIG_MIGRATE_WQ removed and so is wq_select_cpu() - sched_select_cpu() called only from __queue_work() - got tejun/for-3.7 branch in my tree, before making workqueue changes. Viresh Kumar (4): sched: Create sched_select_cpu() to give preferred CPU for power saving timer: hrtimer: Don't check idle_cpu() before calling get_nohz_timer_target() workqueue: Schedule work on non-idle cpu instead of current one timer: Migrate running timer include/linux/sched.h | 16 ++++++++++-- include/linux/timer.h | 2 ++ kernel/hrtimer.c | 2 +- kernel/sched/core.c | 69 +++++++++++++++++++++++++++++++-------------------- kernel/timer.c | 50 ++++++++++++++++++++++--------------- kernel/workqueue.c | 4 +-- 6 files changed, 91 insertions(+), 52 deletions(-) -- 1.7.12.rc2.18.g61b472e

10 years, 6 months

[PATCH] genirq: Add default affinity mask command line option

by Punit Agrawal

I am attaching a patch by Thomas Gleixner which adds a kernel command line parameter to set the defauilt IRQ affinity mask. Could you please integrate this in your tree for the next Linaro release? I've been using this patch for sometime now and it doesn't introduce any regressions. There is a possibility that this patch will make it upstream via the RT patches in the near future but in the meanwhile, we'd like to carry this patch as well. Cheers, Punit >From 52a7d44f58a262e166575abc57aa0bd3bfc8cfbb Mon Sep 17 00:00:00 2001 From: Thomas Gleixner <tglx(a)linutronix.de> Date: Fri, 25 May 2012 16:59:47 +0200 Subject: [PATCH] genirq: Add default affinity mask command line option If we isolate CPUs, then we don't want random device interrupts on them. Even w/o the user space irq balancer enabled we can end up with irqs on non boot cpus. Allow to restrict the default irq affinity mask. Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de> --- Documentation/kernel-parameters.txt | 9 +++++++++ kernel/irq/irqdesc.c | 21 +++++++++++++++++++-- 2 files changed, 28 insertions(+), 2 deletions(-) diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 7d82468..00fedab 100644 --- a/Documentation/kernel-parameters.txt +++ b/Documentation/kernel-parameters.txt @@ -1164,6 +1164,15 @@ bytes respectively. Such letter suffixes can also be entirely omitted. See comment before ip2_setup() in drivers/char/ip2/ip2base.c. + irqaffinity= [SMP] Set the default irq affinity mask + Format: + <cpu number>,...,<cpu number> + or + <cpu number>-<cpu number> + (must be a positive range in ascending order) + or a mixture + <cpu number>,...,<cpu number>-<cpu number> + irqfixup [HW] When an interrupt is not handled search all handlers for it. Intended to get systems with badly broken diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c index 192a302..473b2b6 100644 --- a/kernel/irq/irqdesc.c +++ b/kernel/irq/irqdesc.c @@ -23,10 +23,27 @@ static struct lock_class_key irq_desc_lock_class; #if defined(CONFIG_SMP) +static int __init irq_affinity_setup(char *str) +{ + zalloc_cpumask_var(&irq_default_affinity, GFP_NOWAIT); + cpulist_parse(str, irq_default_affinity); + /* + * Set at least the boot cpu. We don't want to end up with + * bugreports caused by random comandline masks + */ + cpumask_set_cpu(smp_processor_id(), irq_default_affinity); + return 1; +} +__setup("irqaffinity=", irq_affinity_setup); + static void __init init_irq_default_affinity(void) { - alloc_cpumask_var(&irq_default_affinity, GFP_NOWAIT); - cpumask_setall(irq_default_affinity); +#ifdef CONFIG_CPUMASK_OFFSTACK + if (!irq_default_affinity) + zalloc_cpumask_var(&irq_default_affinity, GFP_NOWAIT); +#endif + if (cpumask_empty(irq_default_affinity)) + cpumask_setall(irq_default_affinity); } #else static void __init init_irq_default_affinity(void) -- 1.7.9.5

10 years, 11 months

Power aware scheduler - DVFS development question

by Lukasz Majewski

Dear All, I'd like to ask about the power aware scheduler development: https://blueprints.launchpad.net/linaro-power-kernel/+spec/power-aware- scheduler Why I'm interested? I'd like to test and further develop methods to put CPU to IDLE or changing its operating frequency. I'm especially interested in packing as much as possible tasks to a CPU and put the other one to deep idle (RFTS - policy). I'm also curious how aggressive SCHED_POLICY_POWERSAVING is going to be? (are there any special requirements) In the above page at the "Work items 2013.01" section states that there is a work TODO in the "max_power and current_power" for DVFS. Could you share code (if available) and plans for this development? I've looked to the: git://git.linaro.org/arm/big.LITTLE/mp.git tree (branch: power-aware- scheduling-v4), but didn't find the power related code (especially DVFS). Probably I've looked at wrong place, so any guidance would be appreciate. As a side question: On the linaro-dev mailing list there are some patches for tuning cpufreq governor. Is there any roadmap for this effort? -- Best regards, Lukasz Majewski Samsung R&D Poland (SRPOL) | Linux Platform Group

11 years, 2 months

[PATCH v2 0/2] sched: fix nr_busy_cpus

by Vincent Guittot

The nr_busy_cpus field of the sched_group_power is sometime different from 0 whereas the platform is fully idle. This serie fixes 3 use cases: - when some CPUs enter idle state while booting all CPUs - when a CPU is unplug and/or replug Change since V1: - remove the patch for SCHED softirq on an idle core use case as it was a side effect of the other use cases. Vincent Guittot (2): sched: fix init NOHZ_IDLE flag sched: fix update NOHZ_IDLE flag kernel/sched/core.c | 1 + kernel/sched/fair.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) -- 1.7.9.5

11 years, 2 months

[PATCH] cpufreq: exynos: simplify .init() for setting policy->cpus

by Viresh Kumar

With the recent changes in cpufreq core, we just need to set mask of all possible cpus into policy->cpus. Rest would be done by core. Signed-off-by: Viresh Kumar <viresh.kumar(a)linaro.org> --- drivers/cpufreq/exynos-cpufreq.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c index 7012ea8..81eb84a 100644 --- a/drivers/cpufreq/exynos-cpufreq.c +++ b/drivers/cpufreq/exynos-cpufreq.c @@ -227,19 +227,7 @@ static int exynos_cpufreq_cpu_init(struct cpufreq_policy *policy) /* set the transition latency value */ policy->cpuinfo.transition_latency = 100000; - /* - * EXYNOS4 multi-core processors has 2 cores - * that the frequency cannot be set independently. - * Each cpu is bound to the same speed. - * So the affected cpu is all of the cpus. - */ - if (num_online_cpus() == 1) { - cpumask_copy(policy->related_cpus, cpu_possible_mask); - cpumask_copy(policy->cpus, cpu_online_mask); - } else { - policy->shared_type = CPUFREQ_SHARED_TYPE_ANY; - cpumask_setall(policy->cpus); - } + cpumask_setall(policy->cpus); return cpufreq_frequency_table_cpuinfo(policy, exynos_info->freq_table); } -- 1.7.12.rc2.18.g61b472e

11 years, 2 months

[PATCH 1/3] PM / devfreq: set min/max freq limit from freq table

by Rajagopal Venkat

Set devfreq device min and max frequency limits when device is added to devfreq, provided frequency table is supplied. This helps governors to suggest target frequency with in limits. Signed-off-by: Rajagopal Venkat <rajagopal.venkat(a)linaro.org> --- drivers/devfreq/devfreq.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index a8f0173..5782c9b 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -69,6 +69,29 @@ static struct devfreq *find_device_devfreq(struct device *dev) } /** + * devfreq_set_freq_limits() - Set min and max frequency from freq_table + * @devfreq: the devfreq instance + */ +static void devfreq_set_freq_limits(struct devfreq *devfreq) +{ + int idx; + unsigned long min = ~0, max = 0; + + if (!devfreq->profile->freq_table) + return; + + for (idx = 0; idx < devfreq->profile->max_state; idx++) { + if (min > devfreq->profile->freq_table[idx]) + min = devfreq->profile->freq_table[idx]; + if (max < devfreq->profile->freq_table[idx]) + max = devfreq->profile->freq_table[idx]; + } + + devfreq->min_freq = min; + devfreq->max_freq = max; +} + +/** * devfreq_get_freq_level() - Lookup freq_table for the frequency * @devfreq: the devfreq instance * @freq: the target frequency @@ -476,6 +499,7 @@ struct devfreq *devfreq_add_device(struct device *dev, devfreq->profile->max_state, GFP_KERNEL); devfreq->last_stat_updated = jiffies; + devfreq_set_freq_limits(devfreq); dev_set_name(&devfreq->dev, dev_name(dev)); err = device_register(&devfreq->dev); -- 1.7.10.4

11 years, 2 months

What is the commit for ARM VE 5.0 release

by Chao Xie

hi I have seen in the arm website that arm release the VE 5.0. THere is a patch named "CPU Migration Patch for version 5.0" for cpu migration. Now i have downloaded the source code from git.linaro.org/git-ro/landing-teams/working/arm/kernel.git, and use the branch integration-android-vexpress. It is strange that it reports errors when boot up at TC2, and only one core boots up. So what is the branch and commit number for the cpu migration? I attached the boot up logs as well. ARM Versatile Express Boot Monitor Version: V5.1.9 Build Date: Dec 3 2012 Daughterboard Site 1: V2P-CA15_A7 Cortex A15 Daughterboard Site 2: Not Used Running boot script from flash - BOOTSCRIPT Loaded FDT - tc2_dtb Loaded initrd - initrd Loaded kernel - zimage Booting kernel @ 0x80008000 Command line 'console=tty0 console=ttyAMA0,38400n8 rootwait ro init=/init androidboot.console=ttyAMA0 mmci.fmax=12000000' initrd @ 0xa0100000 (194422 bytes) FDT @ 0xa0000000 (14295 bytes) [ 0.000000] Booting Linux on physical CPU 0x0 [ 0.000000] Initializing cgroup subsys cpu [ 0.000000] Linux version 3.8.0-rc4-00621-g95f63d2 (cxie4@cxie4-OptiPlex-780) (gcc version 4.5.2 (Ubuntu/Linaro 4.5.2-8ubuntu3) ) #1 SMP Sun Jan 27 21:07:09 EST 2013 [ 0.000000] CPU: ARMv7 Processor [412fc0f1] revision 1 (ARMv7), cr=10c5387d [ 0.000000] CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing instruction cache [ 0.000000] Machine: ARM-Versatile Express, model: V2P-CA15_CA7 [ 0.000000] Truncating memory at 0x80000000 to fit in 32-bit physical address space [ 0.000000] Memory policy: ECC disabled, Data cache writealloc [ 0.000000] PERCPU: Embedded 9 pages/cpu @c1d59000 s14528 r8192 d14144 u36864 [ 0.000000] Built 1 zonelists in Zone order, mobility grouping on. Total pages: 520191 [ 0.000000] Kernel command line: console=tty0 console=ttyAMA0,38400n8 rootwait ro init=/init androidboot.console=ttyAMA0 mmci.fmax=12000000 [ 0.000000] PID hash table entries: 4096 (order: 2, 16384 bytes) [ 0.000000] Dentry cache hash table entries: 131072 (order: 7, 524288 bytes) [ 0.000000] Inode-cache hash table entries: 65536 (order: 6, 262144 bytes) [ 0.000000] __ex_table already sorted, skipping sort [ 0.000000] Memory: 2032MB = 2032MB total [ 0.000000] Memory: 2049536k/2049536k available, 47612k reserved, 1302528K highmem [ 0.000000] Virtual kernel memory layout: [ 0.000000] vector : 0xffff0000 - 0xffff1000 ( 4 kB) [ 0.000000] fixmap : 0xfff00000 - 0xfffe0000 ( 896 kB) [ 0.000000] vmalloc : 0xf0000000 - 0xff000000 ( 240 MB) [ 0.000000] lowmem : 0xc0000000 - 0xef800000 ( 760 MB) [ 0.000000] pkmap : 0xbfe00000 - 0xc0000000 ( 2 MB) [ 0.000000] modules : 0xbf000000 - 0xbfe00000 ( 14 MB) [ 0.000000] .text : 0xc0008000 - 0xc0748870 (7427 kB) [ 0.000000] .init : 0xc0749000 - 0xc078e8c0 ( 279 kB) [ 0.000000] .data : 0xc0790000 - 0xc07da5f0 ( 298 kB) [ 0.000000] .bss : 0xc07da5f0 - 0xc0d324a0 (5472 kB) [ 0.000000] Hierarchical RCU implementation. [ 0.000000] RCU restricting CPUs from NR_CPUS=8 to nr_cpu_ids=5. [ 0.000000] NR_IRQS:16 nr_irqs:16 16 [ 0.000000] Using SP804 '/smb/motherboard/iofpga@3,00000000/timer@110000' as a clock & events source [ 0.000000] Architected local timer running at 24.00MHz (virt). [ 0.000000] Switching to timer-based delay loop [ 0.000000] sched_clock: 32 bits at 24MHz, resolution 41ns, wraps every 178956ms [ 0.000000] Console: colour dummy device 80x30 [ 0.000000] console [tty0] enabled [ 0.000000] Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar [ 0.000000] ... MAX_LOCKDEP_SUBCLASSES: 8 [ 0.000000] ... MAX_LOCK_DEPTH: 48 [ 0.000000] ... MAX_LOCKDEP_KEYS: 8191 [ 0.000000] ... CLASSHASH_SIZE: 4096 [ 0.000000] ... MAX_LOCKDEP_ENTRIES: 16384 [ 0.000000] ... MAX_LOCKDEP_CHAINS: 32768 [ 0.000000] ... CHAINHASH_SIZE: 16384 [ 0.000000] memory used by lock dependency info: 3695 kB [ 0.000000] per task-struct memory footprint: 1152 bytes [ 0.003045] Calibrating delay loop (skipped), value calculated using timer frequency.. 48.00 BogoMIPS (lpj=240000) [ 0.003100] pid_max: default: 32768 minimum: 301 [ 0.003596] Mount-cache hash table entries: 512 [ 0.006550] CPU: Testing write buffer coherency: ok [ 0.006658] ftrace: allocating 19546 entries in 39 pages [ 0.030427] CPU0: update cpu_power 1441 [ 0.030451] CPU0: thread -1, cpu 0, socket 0, mpidr 80000000 [ 0.030505] Setting up static identity map for 0x80586830 - 0x80586888 [ 0.033403] vexpress_spc loaded at f0008000 [ 0.033424] TC2 power management initialized [ 1.031517] CPU1: failed to come online [ 2.032563] CPU2: failed to come online [ 3.033640] CPU3: failed to come online [ 4.034716] CPU4: failed to come online [ 4.034957] Brought up 1 CPUs [ 4.034974] SMP: Total of 1 processors activated (48.00 BogoMIPS). [ 4.050297] regulator-dummy: no parameters [ 4.051903] NET: Registered protocol family 16 [ 4.052193] DMA: preallocated 256 KiB pool for atomic coherent allocations [ 4.056236] hw perfevents: enabled with CCI PMU driver, 5 counters available [ 4.056391] CCI loaded at f0060000 [ 4.081223] hw-breakpoint: found 5 (+1 reserved) breakpoint and 4 watchpoint registers. [ 4.081252] hw-breakpoint: maximum watchpoint size is 8 bytes. [ 4.081277] Serial: AMBA PL011 UART driver [ 4.081747] 1c090000.uart: ttyAMA0 at MMIO 0x1c090000 (irq = 37) is a PL011 rev2 [ 5.311555] console [ttyAMA0] enabled [ 5.323483] 1c0a0000.uart: ttyAMA1 at MMIO 0x1c0a0000 (irq = 38) is a PL011 rev2 [ 5.346604] 1c0b0000.uart: ttyAMA2 at MMIO 0x1c0b0000 (irq = 39) is a PL011 rev2 [ 5.369330] 1c0c0000.uart: ttyAMA3 at MMIO 0x1c0c0000 (irq = 40) is a PL011 rev2 [ 5.430220] bio: create slab <bio-0> at 0 [ 5.443702] 3V3: 3300 mV [ 5.453380] SCSI subsystem initialized [ 5.465955] usbcore: registered new interface driver usbfs [ 5.482706] usbcore: registered new interface driver hub [ 5.499039] usbcore: registered new device driver usb [ 5.516764] Advanced Linux Sound Architecture Driver Initialized. [ 5.537505] Switching to clocksource arch_sys_counter [ 5.629531] NET: Registered protocol family 2 [ 5.643681] TCP established hash table entries: 8192 (order: 4, 65536 bytes) [ 5.665088] TCP bind hash table entries: 8192 (order: 6, 294912 bytes) [ 5.687156] TCP: Hash tables configured (established 8192 bind 8192) [ 5.706343] TCP: reno registered [ 5.716034] UDP hash table entries: 512 (order: 3, 40960 bytes) [ 5.734118] UDP-Lite hash table entries: 512 (order: 3, 40960 bytes) [ 5.753925] NET: Registered protocol family 1 [ 5.767674] RPC: Registered named UNIX socket transport module. [ 5.785435] RPC: Registered udp transport module. [ 5.799537] RPC: Registered tcp transport module. [ 5.813640] RPC: Registered tcp NFSv4.1 backchannel transport module. [ 5.833462] Trying to unpack rootfs image as initramfs... [ 5.860865] Freeing initrd memory: 188K [ 5.872674] hw perfevents: enabled with ARMv7_Cortex_A15 PMU driver, 7 counters available [ 5.897282] hw perfevents: enabled with ARMv7_Cortex_A7 PMU driver, 7 counters available [ 5.927891] bounce pool size: 64 pages [ 5.939532] VFS: Disk quotas dquot_6.5.2 [ 5.951412] Dquot-cache hash table entries: 1024 (order 0, 4096 bytes) [ 5.973922] NFS: Registering the id_resolver key type [ 5.989306] Key type id_resolver registered [ 6.001853] Key type id_legacy registered [ 6.013945] jffs2: version 2.2. (NAND) (SUMMARY) Ã‚Â© 2001-2006 Red Hat, Inc. [ 6.036089] Btrfs loaded [ 6.043705] msgmni has been set to 1459 [ 6.057314] Block layer SCSI generic (bsg) driver version 0.4 loaded (major 253) [ 6.079538] io scheduler noop registered [ 6.091298] io scheduler deadline registered [ 6.104137] io scheduler cfq registered (default) [ 6.128812] hdlcd 2b000000.hdlcd: HDLCD: found ARM HDLCD version r0p0 [ 6.148141] hdlcd 2b000000.hdlcd: using 1024x768-16@60 mode [ 6.186002] Console: switching to colour frame buffer device 128x48 [ 6.222902] A15 Vcore: 800 <--> 1050 mV at 902 mV [ 6.252893] A7 Vcore: 800 <--> 1050 mV at 905 mV [ 6.282884] VIO: at 1810 mV [ 6.461313] brd: module loaded [ 6.479745] loop: module loaded [ 6.491370] mtdoops: mtd device (mtddev=name/number) must be supplied [ 6.511472] smsc911x: Driver version 2008-10-21 [ 6.529078] libphy: smsc911x-mdio: probed [ 6.541403] smsc911x 1a000000.ethernet eth0: attached PHY driver [Generic PHY] (mii_bus:phy_addr=1a000000.etherne:01, irq=-1) [ 6.575673] smsc911x 1a000000.ethernet eth0: MAC Address: 00:02:f7:00:48:3e [ 6.597680] nxp-isp1760 1b000000.usb: NXP ISP1760 USB Host Controller [ 6.617233] nxp-isp1760 1b000000.usb: new USB bus registered, assigned bus number 1 [ 6.840279] nxp-isp1760 1b000000.usb: bus width: 32, oc: digital [ 6.879588] nxp-isp1760 1b000000.usb: irq 48, io mem 0x1b000000 [ 6.898690] nxp-isp1760 1b000000.usb: USB ISP 1761 HW rev. 1 started [ 6.921425] hub 1-0:1.0: USB hub found [ 6.934175] hub 1-0:1.0: 1 port detected [ 6.948140] Initializing USB Mass Storage driver... [ 6.964390] usbcore: registered new interface driver usb-storage [ 6.983703] USB Mass Storage support registered. [ 7.000663] mousedev: PS/2 mouse device common for all mice [ 7.021765] rtc-pl031 1c170000.rtc: rtc core: registered pl031 as rtc0 [ 7.047669] device-mapper: ioctl: 4.23.1-ioctl (2012-12-18) initialised: dm-devel(a)redhat.com [ 7.074755] arm_big_little: CPU 0 initialized [ 7.090452] arm_big_little: bL_cpufreq_register: Registered platform driver: vexpress-bL [ 7.115989] cpuidle: using governor ladder [ 7.129314] cpuidle: using governor menu [ 7.142871] mmci-pl18x 1c050000.mmci: mmc0: PL180 manf 41 rev0 at 0x1c050000 irq 41,42 (pio) [ 7.208100] usbcore: registered new interface driver usbhid [ 7.225944] usbhid: USB HID core driver [ 7.238570] nxp-isp1760 1b000000.usb: port 1 high speed [ 7.256126] ashmem: initialized [ 7.266944] logger: created 256K log 'log_main' [ 7.281984] logger: created 256K log 'log_events' [ 7.297493] logger: created 256K log 'log_radio' [ 7.312718] logger: created 256K log 'log_system' [ 7.329155] usb 1-1: new high-speed USB device number 2 using nxp-isp1760 [ 7.369801] aaci-pl041 1c040000.aaci: ARM AC'97 Interface PL041 rev0 at 0x1c040000, irq 43 [ 7.395664] aaci-pl041 1c040000.aaci: FIFO 512 entries [ 7.412174] mmc0: new SDHC card at address 1234 [ 7.427205] nxp-isp1760 1b000000.usb: port 1 high speed [ 7.446068] mmcblk0: mmc0:1234 SA04G 3.67 GiB [ 7.460930] oprofile: using timer interrupt. [ 7.475030] TCP: cubic registered [ 7.485974] Initializing XFRM netlink socket [ 7.499963] NET: Registered protocol family 10 [ 7.515539] NET: Registered protocol family 17 [ 7.529915] NET: Registered protocol family 15 [ 7.544503] Key type dns_resolver registered [ 7.558334] VFP support v0.3: implementor 41 architecture 4 part 30 variant f rev 0 [ 7.582361] Registering SWP/SWPB emulation handler [ 7.600441] rtc-pl031 1c170000.rtc: setting system clock to 1970-01-14 00:44:54 UTC (1125894) [ 7.627306] bl_idle_init: No compatible node found [ 7.642860] ALSA device list: [ 7.652758] #0: ARM AC'97 Interface PL041 rev0 at 0x1c040000, irq 43 [ 7.674670] Freeing init memory: 276K [ 7.696502] init (1): /proc/1/oom_adj is deprecated, please use /proc/1/oom_score_adj instead. [ 7.724501] mmcblk0: p1 p2 p3 p4 < p5 p6 > [ 7.740112] hub 1-1:1.0: USB hub found [ 7.752494] hub 1-1:1.0: 3 ports detected [ 8.013108] atkbd serio0: keyboard reset failed on 1c060000.kmi [ 8.538862] [ 8.538864] ====================================================== [ 8.538866] [ INFO: possible circular locking dependency detected ] [ 8.538872] 3.8.0-rc4-00621-g95f63d2 #1 Not tainted [ 8.538874] ------------------------------------------------------- [ 8.538877] init/1 is trying to acquire lock: [ 8.538900] ((fb_notifier_list).rwsem){.+.+.+}, at: [<c004d488>] __blocking_notifier_call_chain+0x34/0x68 [ 8.538902] [ 8.538902] but task is already holding lock: [ 8.538917] (console_lock){+.+.+.}, at: [<c035ab44>] do_fb_ioctl+0x39c/0x5d8 [ 8.538919] [ 8.538919] which lock already depends on the new lock. [ 8.538919] [ 8.538920] [ 8.538920] the existing dependency chain (in reverse order) is: [ 8.538929] [ 8.538929] -> #1 (console_lock){+.+.+.}: [ 8.538939] [<c007e230>] lock_acquire+0xa0/0x104 [ 8.538948] [<c002534c>] console_lock+0x5c/0x6c [ 8.538956] [<c03862d0>] register_con_driver+0x44/0x154 [ 8.538962] [<c038692c>] take_over_console+0x24/0x38c [ 8.538970] [<c035f834>] fbcon_takeover+0x88/0xdc [ 8.538976] [<c004cfb0>] notifier_call_chain+0x4c/0x8c [ 8.538982] [<c004d4a4>] __blocking_notifier_call_chain+0x50/0x68 [ 8.538989] [<c004d4dc>] blocking_notifier_call_chain+0x20/0x28 [ 8.538995] [<c035a380>] register_framebuffer+0x1a4/0x240 [ 8.539000] [<c0369a5c>] hdlcd_probe+0x674/0x774 [ 8.539007] [<c03990f8>] platform_drv_probe+0x20/0x24 [ 8.539014] [<c0397d30>] driver_probe_device+0x88/0x21c [ 8.539020] [<c0397f60>] __driver_attach+0x9c/0xa0 [ 8.539027] [<c03964ac>] bus_for_each_dev+0x58/0x84 [ 8.539033] [<c03973ec>] bus_add_driver+0xb0/0x24c [ 8.539039] [<c03984fc>] driver_register+0x80/0x14c [ 8.539046] [<c00085fc>] do_one_initcall+0x3c/0x180 [ 8.539053] [<c057c808>] kernel_init+0x13c/0x2b0 [ 8.539060] [<c000e3b0>] ret_from_fork+0x14/0x20 [ 8.539069] [ 8.539069] -> #0 ((fb_notifier_list).rwsem){.+.+.+}: [ 8.539075] [<c007d8cc>] __lock_acquire+0x1a98/0x1e54 [ 8.539081] [<c007e230>] lock_acquire+0xa0/0x104 [ 8.539087] [<c058448c>] down_read+0x3c/0x4c [ 8.539093] [<c004d488>] __blocking_notifier_call_chain+0x34/0x68 [ 8.539100] [<c004d4dc>] blocking_notifier_call_chain+0x20/0x28 [ 8.539105] [<c035a710>] fb_set_var+0x2ac/0x344 [ 8.539111] [<c035ab5c>] do_fb_ioctl+0x3b4/0x5d8 [ 8.539118] [<c010f948>] do_vfs_ioctl+0x8c/0x5e4 [ 8.539123] [<c010fee4>] sys_ioctl+0x44/0x68 [ 8.539129] [<c000e300>] ret_fast_syscall+0x0/0x3c [ 8.539131] [ 8.539131] other info that might help us debug this: [ 8.539131] [ 8.539133] Possible unsafe locking scenario: [ 8.539133] [ 8.539135] CPU0 CPU1 [ 8.539137] ---- ---- [ 8.539142] lock(console_lock); [ 8.539147] lock((fb_notifier_list).rwsem); [ 8.539152] lock(console_lock); [ 8.539157] lock((fb_notifier_list).rwsem); [ 8.539159] [ 8.539159] *** DEADLOCK *** [ 8.539159] [ 8.539162] 2 locks held by init/1: [ 8.539175] #0: (&fb_info->lock){+.+.+.}, at: [<c035963c>] lock_fb_info+0x20/0x44 [ 8.539187] #1: (console_lock){+.+.+.}, at: [<c035ab44>] do_fb_ioctl+0x39c/0x5d8 [ 8.539189] [ 8.539189] stack backtrace: [ 8.539200] [<c0015234>] (unwind_backtrace+0x0/0x100) from [<c007a544>] (print_circular_bug+0x21c/0x310) [ 8.539209] [<c007a544>] (print_circular_bug+0x21c/0x310) from [<c007d8cc>] (__lock_acquire+0x1a98/0x1e54) [ 8.539216] [<c007d8cc>] (__lock_acquire+0x1a98/0x1e54) from [<c007e230>] (lock_acquire+0xa0/0x104) [ 8.539224] [<c007e230>] (lock_acquire+0xa0/0x104) from [<c058448c>] (down_read+0x3c/0x4c) [ 8.539231] [<c058448c>] (down_read+0x3c/0x4c) from [<c004d488>] (__blocking_notifier_call_chain+0x34/0x68) [ 8.539239] [<c004d488>] (__blocking_notifier_call_chain+0x34/0x68) from [<c004d4dc>] (blocking_notifier_call_chain+0x20/0x28) [ 8.539246] [<c004d4dc>] (blocking_notifier_call_chain+0x20/0x28) from [<c035a710>] (fb_set_var+0x2ac/0x344) [ 8.539254] [<c035a710>] (fb_set_var+0x2ac/0x344) from [<c035ab5c>] (do_fb_ioctl+0x3b4/0x5d8) [ 8.539261] [<c035ab5c>] (do_fb_ioctl+0x3b4/0x5d8) from [<c010f948>] (do_vfs_ioctl+0x8c/0x5e4) [ 8.539268] [<c010f948>] (do_vfs_ioctl+0x8c/0x5e4) from [<c010fee4>] (sys_ioctl+0x44/0x68) [ 8.539275] [<c010fee4>] (sys_ioctl+0x44/0x68) from [<c000e300>] (ret_fast_syscall+0x0/0x3c) [ 9.781834] atkbd serio1: keyboard reset failed on 1c070000.kmi [ 10.414567] EXT4-fs (mmcblk0p2): mounted filesystem with ordered data mode. Opts: (null) [ 10.567713] EXT4-fs (mmcblk0p3): warning: maximal mount count reached, running e2fsck is recommended [ 10.598900] EXT4-fs (mmcblk0p3): recovery complete [ 10.621476] EXT4-fs (mmcblk0p3): mounted filesystem with ordered data mode. Opts: (null) [ 15.288641] EXT4-fs (mmcblk0p5): warning: maximal mount count reached, running e2fsck is recommended [ 15.320604] EXT4-fs (mmcblk0p5): recovery complete [ 15.339184] EXT4-fs (mmcblk0p5): mounted filesystem with ordered data mode. Opts: (null) [ 15.665576] gator: version magic '3.5.0-rc7-23732-g179e319 SMP mod_unload ARMv7 p2v8 ' should be '3.8.0-rc4-00621-g95f63d2 SMP mod_unload ARMv7 p2v8 ' [ 15.749911] init: cannot find '/system/etc/install-recovery.sh', disabling 'flash_recovery' [ 17.473536] input: Fake Touchscreen as /devices/virtual/input/input0 [ 17.769936] smsc911x 1a000000.ethernet eth0: SMSC911x/921x identified at 0xf00e0000, IRQ: 47

11 years, 2 months

[PATCH] ab8500: btemp: demote initcall sequence

by Rajanikanth H.V

From: "Rajanikanth H.V" <rajanikanth.hv(a)stericsson.com> Power supply subsystem creates thermal zone device for the property 'POWER_SUPPLY_PROP_TEMP' which requires thermal subsystem to be ready before 'ab8500 battery temperature monitor' driver is initialized. ab8500 btemp driver is initialized with subsys_initcall whereas thermal subsystem is initialized with fs_initcall which causes thermal_zone_device_register(...) to crash since the required structure 'thermal_class' is not initialized yet. crash log: =================================================================== Unable to handle kernel NULL pointer dereference at virtual address 000000a4 pgd = c0004000 [000000a4] *pgd=00000000 Internal error: Oops: 5 [#1] PREEMPT SMP ARM Modules linked in: CPU: 0 Tainted: G W (3.8.0-rc4-00001-g632fda8-dirty #1) PC is at _raw_spin_lock+0x18/0x54 LR is at get_device_parent+0x50/0x1b8 pc : [<c02f1dd0>] lr : [<c01cb248>] psr: 60000013 sp : ef04bdc8 ip : 00000000 fp : c0446180 r10: ef216e38 r9 : c03af5d0 r8 : ef275c18 r7 : 00000000 r6 : c0476c14 r5 : ef275c18 r4 : ef095840 r3 : ef04a000 r2 : 00000001 r1 : 00000000 r0 : 000000a4 Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel Control: 10c5787d Table: 0000404a DAC: 00000015 Process swapper/0 (pid: 1, stack limit = 0xef04a238) Stack: (0xef04bdc8 to 0xef04c000) bdc0: ef275c18 00000000 00000000 c01cb8d8 00000000 ef275c18 bde0: ef275c80 00000000 c0446180 c01d3edc ef275c18 ef275c00 00000000 00000000 be00: c03af5d0 ef275c18 c03af5d0 ef216e38 c0446180 c020b91c 00000000 ef275c04 be20: ef04be48 ef1ad000 ef216e38 ef1ad000 ef216e38 00000000 ef1b9010 00000002 be40: c03af5d0 00000000 c0446058 c0202030 c0445400 00000000 00000000 00000000 be60: ef216e10 ef1b9000 c04457f4 c02055ec 00000000 c01d57ac ef216e38 ef037a00 be80: ef181fc0 00000000 ef1b9010 c0476c38 ef1b9010 ef1b9044 c0446008 c041bbb0 bea0: c044d940 ef04a000 c0414b68 c01cf0dc c01cf0c8 c01cde70 00000000 ef1b9010 bec0: c0446008 ef1b9044 00000000 c01ce094 00000000 c0446008 c01ce008 c01cc640 bee0: ef032258 ef180334 ef222f00 c0446008 c0441778 c01cd6b4 c03ab170 c0446008 bf00: c0446008 c041bbd0 00000005 c044d940 c041bbb0 c01ce54c 00000000 c0422988 bf20: c041bbd0 00000005 c044d940 c041bbb0 ef04a000 c00086ac 00000049 c00360cc bf40: ef04bf6c 00000000 c0388c34 c03e1a78 00000004 00000004 c0436998 c0422988 bf60: c041bbd0 00000005 c044d940 c041bbb0 c040027c 00000049 00000000 c02e89c8 bf80: 00000004 00000004 c040027c c0c88340 00000000 c02e88a8 00000000 00000000 bfa0: 00000000 00000000 00000000 c000e358 00000000 00000000 00000000 00000000 bfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 bfe0: 00000000 00000000 00000000 00000000 00000013 00000000 80800004 00304600 [<c02f1dd0>] (_raw_spin_lock+0x18/0x54) from [<c01cb248>] (get_device_parent+0x50/0x1b8) [<c01cb248>] (get_device_parent+0x50/0x1b8) from [<c01cb8d8>] (device_add+0xa4/0x574) [<c01cb8d8>] (device_add+0xa4/0x574) from [<c020b91c>] (thermal_zone_device_register+0x118/0x938) [<c020b91c>] (thermal_zone_device_register+0x118/0x938) from [<c0202030>] (power_supply_register+0x170/0x1f8) [<c0202030>] (power_supply_register+0x170/0x1f8) from [<c02055ec>] (ab8500_btemp_probe+0x208/0x47c) [<c02055ec>] (ab8500_btemp_probe+0x208/0x47c) from [<c01cf0dc>] (platform_drv_probe+0x14/0x18) [<c01cf0dc>] (platform_drv_probe+0x14/0x18) from [<c01cde70>] (driver_probe_device+0x74/0x20c) [<c01cde70>] (driver_probe_device+0x74/0x20c) from [<c01ce094>] (__driver_attach+0x8c/0x90) [<c01ce094>] (__driver_attach+0x8c/0x90) from [<c01cc640>] (bus_for_each_dev+0x4c/0x80) [<c01cc640>] (bus_for_each_dev+0x4c/0x80) from [<c01cd6b4>] (bus_add_driver+0x16c/0x23c) [<c01cd6b4>] (bus_add_driver+0x16c/0x23c) from [<c01ce54c>] (driver_register+0x78/0x14c) [<c01ce54c>] (driver_register+0x78/0x14c) from [<c00086ac>] (do_one_initcall+0xfc/0x164) [<c00086ac>] (do_one_initcall+0xfc/0x164) from [<c02e89c8>] (kernel_init+0x120/0x2b8) [<c02e89c8>] (kernel_init+0x120/0x2b8) from [<c000e358>] (ret_from_fork+0x14/0x3c) Code: e3c3303f e5932004 e2822001 e5832004 (e1903f9f) ---[ end trace ed9df72941b5bada ]--- =================================================================== Signed-off-by: Rajanikanth H.V <rajanikanth.hv(a)stericsson.com> --- drivers/power/ab8500_btemp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/ab8500_btemp.c b/drivers/power/ab8500_btemp.c index 20e2a7d..056222e 100644 --- a/drivers/power/ab8500_btemp.c +++ b/drivers/power/ab8500_btemp.c @@ -1123,7 +1123,7 @@ static void __exit ab8500_btemp_exit(void) platform_driver_unregister(&ab8500_btemp_driver); } -subsys_initcall_sync(ab8500_btemp_init); +device_initcall(ab8500_btemp_init); module_exit(ab8500_btemp_exit); MODULE_LICENSE("GPL v2"); -- 1.7.10.4

11 years, 2 months

[PATCH 1/2] cpufreq: governors: Get rid of dbs_data->enable field

by Viresh Kumar

CPUFREQ_GOV_START/STOP are called only once for all policy->cpus and hence we don't need to adapt cpufreq_governor_dbs() routine for multiple calls. So, this patch removes dbs_data->enable field entirely. And rearrange code a bit. Signed-off-by: Viresh Kumar <viresh.kumar(a)linaro.org> --- Hi Fabio, I have fixed all the pending issues, but haven't checked these patches. Can you please add your tested-by (obviously after testing them) ? Compile tested only. drivers/cpufreq/cpufreq_governor.c | 58 +++++++++++++------------------------- drivers/cpufreq/cpufreq_governor.h | 1 - 2 files changed, 20 insertions(+), 39 deletions(-) diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c index 46f1c78..29d6a59 100644 --- a/drivers/cpufreq/cpufreq_governor.c +++ b/drivers/cpufreq/cpufreq_governor.c @@ -182,6 +182,8 @@ int cpufreq_governor_dbs(struct dbs_data *dbs_data, { struct od_cpu_dbs_info_s *od_dbs_info = NULL; struct cs_cpu_dbs_info_s *cs_dbs_info = NULL; + struct cs_ops *cs_ops = NULL; + struct od_ops *od_ops = NULL; struct od_dbs_tuners *od_tuners = dbs_data->tuners; struct cs_dbs_tuners *cs_tuners = dbs_data->tuners; struct cpu_dbs_common_info *cpu_cdbs; @@ -194,10 +196,12 @@ int cpufreq_governor_dbs(struct dbs_data *dbs_data, cs_dbs_info = dbs_data->get_cpu_dbs_info_s(cpu); sampling_rate = &cs_tuners->sampling_rate; ignore_nice = cs_tuners->ignore_nice; + cs_ops = dbs_data->gov_ops; } else { od_dbs_info = dbs_data->get_cpu_dbs_info_s(cpu); sampling_rate = &od_tuners->sampling_rate; ignore_nice = od_tuners->ignore_nice; + od_ops = dbs_data->gov_ops; } switch (event) { @@ -207,10 +211,9 @@ int cpufreq_governor_dbs(struct dbs_data *dbs_data, mutex_lock(&dbs_data->mutex); - dbs_data->enable++; for_each_cpu(j, policy->cpus) { - struct cpu_dbs_common_info *j_cdbs; - j_cdbs = dbs_data->get_cpu_cdbs(j); + struct cpu_dbs_common_info *j_cdbs = + dbs_data->get_cpu_cdbs(j); j_cdbs->cpu = j; j_cdbs->cur_policy = policy; @@ -225,13 +228,6 @@ int cpufreq_governor_dbs(struct dbs_data *dbs_data, dbs_data->gov_dbs_timer); } - /* - * Start the timerschedule work, when this governor is used for - * first time - */ - if (dbs_data->enable != 1) - goto second_time; - rc = sysfs_create_group(cpufreq_global_kobject, dbs_data->attr_group); if (rc) { @@ -249,17 +245,19 @@ int cpufreq_governor_dbs(struct dbs_data *dbs_data, * governor, thus we are bound to jiffes/HZ */ if (dbs_data->governor == GOV_CONSERVATIVE) { - struct cs_ops *ops = dbs_data->gov_ops; - - cpufreq_register_notifier(ops->notifier_block, + cs_dbs_info->down_skip = 0; + cs_dbs_info->enable = 1; + cs_dbs_info->requested_freq = policy->cur; + cpufreq_register_notifier(cs_ops->notifier_block, CPUFREQ_TRANSITION_NOTIFIER); dbs_data->min_sampling_rate = MIN_SAMPLING_RATE_RATIO * jiffies_to_usecs(10); } else { - struct od_ops *ops = dbs_data->gov_ops; - - od_tuners->io_is_busy = ops->io_busy(); + od_dbs_info->rate_mult = 1; + od_dbs_info->sample_type = OD_NORMAL_SAMPLE; + od_ops->powersave_bias_init_cpu(cpu); + od_tuners->io_is_busy = od_ops->io_busy(); } /* Bring kernel and HW constraints together */ @@ -267,18 +265,6 @@ int cpufreq_governor_dbs(struct dbs_data *dbs_data, MIN_LATENCY_MULTIPLIER * latency); *sampling_rate = max(dbs_data->min_sampling_rate, latency * LATENCY_MULTIPLIER); - -second_time: - if (dbs_data->governor == GOV_CONSERVATIVE) { - cs_dbs_info->down_skip = 0; - cs_dbs_info->enable = 1; - cs_dbs_info->requested_freq = policy->cur; - } else { - struct od_ops *ops = dbs_data->gov_ops; - od_dbs_info->rate_mult = 1; - od_dbs_info->sample_type = OD_NORMAL_SAMPLE; - ops->powersave_bias_init_cpu(cpu); - } mutex_unlock(&dbs_data->mutex); /* Initiate timer time stamp */ @@ -297,16 +283,12 @@ second_time: mutex_lock(&dbs_data->mutex); mutex_destroy(&cpu_cdbs->timer_mutex); - dbs_data->enable--; - if (!dbs_data->enable) { - struct cs_ops *ops = dbs_data->gov_ops; - - sysfs_remove_group(cpufreq_global_kobject, - dbs_data->attr_group); - if (dbs_data->governor == GOV_CONSERVATIVE) - cpufreq_unregister_notifier(ops->notifier_block, - CPUFREQ_TRANSITION_NOTIFIER); - } + + sysfs_remove_group(cpufreq_global_kobject, + dbs_data->attr_group); + if (dbs_data->governor == GOV_CONSERVATIVE) + cpufreq_unregister_notifier(cs_ops->notifier_block, + CPUFREQ_TRANSITION_NOTIFIER); mutex_unlock(&dbs_data->mutex); break; diff --git a/drivers/cpufreq/cpufreq_governor.h b/drivers/cpufreq/cpufreq_governor.h index b72e628..c19a16c 100644 --- a/drivers/cpufreq/cpufreq_governor.h +++ b/drivers/cpufreq/cpufreq_governor.h @@ -130,7 +130,6 @@ struct dbs_data { #define GOV_CONSERVATIVE 1 int governor; unsigned int min_sampling_rate; - unsigned int enable; /* number of CPUs using this policy */ struct attribute_group *attr_group; void *tuners; -- 1.7.12.rc2.18.g61b472e

11 years, 2 months

[PATCH 0/2] Add ST-Ericsson AB8500 HWMON driver

by Hongbo Zhang

These patches are against the v3.8-rc4. Guenter Roeck, Jean Delvare, Please help to have a look at this. Samuel Ortiz, Please review 1/2 and leave your Acked-by: if no problem, I think these patches should be merged into HWMON tree. Thanks for all. Hongbo Zhang (2): ARM: ux500: rename ab8500 to abx500 for hwmon driver hwmon: add ST-Ericsson ABX500 hwmon driver drivers/hwmon/Kconfig | 13 + drivers/hwmon/Makefile | 1 + drivers/hwmon/ab8500.c | 160 +++++++++++ drivers/hwmon/abx500.c | 681 ++++++++++++++++++++++++++++++++++++++++++++++ drivers/hwmon/abx500.h | 88 ++++++ drivers/mfd/ab8500-core.c | 6 +- 6 files changed, 946 insertions(+), 3 deletions(-) create mode 100644 drivers/hwmon/ab8500.c create mode 100644 drivers/hwmon/abx500.c create mode 100644 drivers/hwmon/abx500.h -- 1.8.0

11 years, 2 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

linaro-dev January 2013