linaro-dev April 2019

linaro-dev@lists.linaro.org

2 participants
1 discussions

Re: [PATCH PM-QA v1] Android.mk: fix compiling errors caused by unused parameters

by 阮正旺

Hi Luis, Can you help me review this patch? Kind Regards, Zhengwang -------- Original Message -------- From: 阮正旺 Sent: Mon, 15 Apr 2019 15:10:40 +0800 To: Linaro-dev Cc: Zhengwang Ruan Subject: Re: [PATCH PM-QA v1] Android.mk: fix compiling errors caused by unused parameters > > Hi all, > > > I found several compiling errors while building pm-qa with Android, > the error logs as below. > > ======= > > external/pm-qa/cpuidle/cpuidle_killer.c:34:21: error: unused parameter > 'sig' [-Werror,-Wunused-parameter] > void sighandler(int sig) > ^ > external/pm-qa/cpuidle/cpuidle_killer.c:39:18: error: unused parameter > 'sig' [-Werror,-Wunused-parameter] > void timeout(int sig) > ^ > external/pm-qa/cpuidle/cpuidle_killer.c:108:14: error: unused > parameter 'argc' [-Werror,-Wunused-parameter] > int main(int argc, char *argv[]) > ^ > external/pm-qa/cpuidle/cpuidle_killer.c:108:26: error: unused > parameter 'argv' [-Werror,-Wunused-parameter] > int main(int argc, char *argv[]) > > ======= > > This is caused because Android enabled '-Wall -Werror' compiling > parameters by default, so we need to disable it in pm-qa project. > > > Kind Regards, > > Zhengwang > > > -------- Original Message -------- > From: Zhengwang Ruan > Sent: Mon, 15 Apr 2019 15:02:54 +0800 > To: Linaro-dev > Cc: Zhengwang Ruan > Subject: [PATCH PM-QA v1] Android.mk: fix compiling errors caused by > unused parameters >> Android enables '-Wall -Werror' compiling parameters by default, as a result >> compiling errors are caused in cpuidle and utils, so add '-Wno-error' to disable >> this check. >> >> Signed-off-by: Zhengwang Ruan<ruanzw(a)xiaopeng.com> >> --- >> cpuidle/Android.mk | 1 + >> utils/Android.mk | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/cpuidle/Android.mk b/cpuidle/Android.mk >> index f0dc52d..041b7f6 100644 >> --- a/cpuidle/Android.mk >> +++ b/cpuidle/Android.mk >> @@ -23,6 +23,7 @@ LOCAL_MODULE := cpuidle_killer >> systemtarball: cpuidle_killer >> systemimage: cpuidle_killer >> LOCAL_SRC_FILES:= cpuidle_killer.c >> +LOCAL_CFLAGS += -Wno-error >> LOCAL_SHARED_LIBRARIES := libcutils libc >> LOCAL_MODULE_TAGS := tests >> LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) >> diff --git a/utils/Android.mk b/utils/Android.mk >> index 0fee7bf..6484bfc 100644 >> --- a/utils/Android.mk >> +++ b/utils/Android.mk >> @@ -11,6 +11,7 @@ define $(module_name)_etc_add_executable >> systemtarball: $1 >> systemimage: $1 >> LOCAL_SRC_FILES := $1.c >> + LOCAL_CFLAGS += -Wno-error >> LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) >> include $(BUILD_EXECUTABLE) >> endef

4 years, 11 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

linaro-dev April 2019