Thanks for the comments!
On Wed, 23 Mar 2011 13:25:02 -0300, Guilherme Salgado guilherme.salgado@linaro.org wrote:
Hi Michael,
That wiki page[1] gave me a good overview of the build service; I have only a couple questions.
Excellent!
Also, even though I didn't actually read most of the code, I saw some shell script to configure the build slave and I'm wondering if you think it'd be worth using something like puppet for that instead. The scripts seem small enough at this point, so it may not worth the effort at this point, but I'm sure they'll grow over time and we don't want to end up with a mess similar to the old l-m-c.
... and then ...
After reading this I realize what I meant may not be clear...
What I meant is to use puppet manifests to describe the resources we need to build android and then run 'puppet apply <manifest>' on the newly instantiated slave to have it configured.
We could also use that for the build master, just in case it ever dies or we want to migrate it to our own cloud infrastructure.
Well, the simple point is that I don't know anything about puppet :-) I think for now, the slave initialization is so simple (90% just installing packages) that we might as well leave it for now. It would probably make sense for the master though!
SCRIPT_NAME: Defines the name of the[...]
At first I thought it'd be nice to have a short description of the existing scripts here, but it looks like we only have the regular one and an extra for building with a custom toolchain, so maybe it's not neeeded?
Hm, probably a good idea. I've added a few words.
To get your script into the branch used by the build system, submit a merge proposal to [...]
I guess that means the jenkins job created under the hoods will always use the tip of the build-tools branch, avoiding the need for a manual update?
Yes. I've made that explicit.
Cheers, mwh