On Wed, 16 Jan 2013, Mark Hambleton wrote:
+obj-$(CONFIG_BIG_LITTLE) += arm_big_little.o
There is nothing big.LITTLE specific in all of this, so arm_idle.c would be better.
I figured that because the current version calls into the big.little platform power framework (bL_entry.c) and makes calls into that framework that this wasn't totally generic and is dependant upon that code. The version of the cpuidle driver won't build unless that code is built in, so I still think this is more appropriate naming, I could call it bL_* but I suspect someone will object to that > > upstream because of the mixed case.
Well, calling it big.LITTLE, bL or whatever else describing a big and a LITTLE is wrong IMHO because it makes people think this a driver for big.LITTLE ARM platforms. And it is not, if we ever manage to make it generic.
You are missing the point, this driver is dependent on the big.little framework that is being upstreamed by Nicolas / Dave, so it is big.little specific (specific to the big.little framework). When a truly generic version is available this one could be removed.
The b.L framework is not really b.L specific. As such I'll try to rename it before it gets merged. Somehow, finding a good name isn't trivial.
I fail to understand why we want to make this code generic NOW, ARM kernel is not ready for that and to be honest I do not see why it has to be done now.
Because we are about to take a copy of this code and make some tiny modifications to it to make it run on our platform, and this seemed a better solution (I suspect a few others are about to do the same, like they used to do with platsmp and all that other good stuff that Nicolas / Dave have been cleaning up).
Basically, if you guys really aren't interested in a step towards less code lurking in mach-vexpress we can carry patches to make things work, just seemed like an easy enough win...
To be honest, your patch is a good thing. The driver definitely has to move out of mach-vexpress. It is just not the fish we are (I am) frying at the moment. But I think Tixy could just pick it up into the ARM »LT tree for now.
Obviously, the driver will evolve over time. That may as well happen in its proper location.
Nicolas