On 09/10/12 11:33, Amit Kucheria wrote:
On Tue, Oct 9, 2012 at 2:13 PM, Jon Medhurst (Tixy) tixy@linaro.org wrote:
On Tue, 2012-10-09 at 09:27 +0100, Sudeep KarkadaNagesha wrote:
On 09/10/12 08:10, Viresh Kumar wrote:
Following is the declaration of name field in struct cpufreq_driver: char name[CPUFREQ_NAME_LEN];
where CPUFREQ_NAME_LEN is 16.
So, length of drivers name must be <=15 (one position for '\0'). Current name is crossing this limit and so name doesn't get printed properly when we do:
$ cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_driver
This patch renames driver-name to fix this issue.
Signed-off-by: Viresh Kumar viresh.kumar@linaro.org
Acked-by: Sudeep KarkadaNagesha sudeep.karkadanagesha@arm.com
Shall I apply this to the ARM Landing Team vexpress tree then?
I'd say yes, the driver lives in your tree. I'm not sure how you coordinate the code drops with ARM since it should be in their tree as well for the future.
Robin raised a valid point that this driver is TC2 specific and bL is not appropriate name for it including the file name(my bad choice at first).
drivers/cpufreq/vexpress_bL_cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/vexpress_bL_cpufreq.c b/drivers/cpufreq/vexpress_bL_cpufreq.c index 8b7ec18..541fc40 100644 --- a/drivers/cpufreq/vexpress_bL_cpufreq.c +++ b/drivers/cpufreq/vexpress_bL_cpufreq.c @@ -244,7 +244,7 @@ static struct cpufreq_driver vexpress_cpufreq_driver = { .target = vexpress_cpufreq_set_target, .get = vexpress_cpufreq_get, .init = vexpress_cpufreq_init,
.name = "cpufreq_vexpress",
.name = "vexpress-bL", .attr = vexpress_cpufreq_attr,
-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.