Re: [PATCH] ARM: EXYNOS: PD: Fix duplicate variable

On Wed, May 09, 2012 at 01:50:28PM +0100, Sangwook Lee wrote:

struct generic_pm_domain already has a field for name. Use that field instead of creating another field in struct exynos_pm_domain

Argh. No.

@@ -99,7 +98,7 @@ static __init int exynos_pm_dt_parse_domains(void) if (of_get_property(np, "samsung,exynos4210-pd-off", NULL)) pd->is_off = true;

• pd->name = np->name;
  

• pd->pd.name = (char *)np->name;
  

Why this cast? Why can't pd->pd.name be correctly typed in the first place?

I assume this is because np->name is const. Never EVER cast away const. It's wrong to do so.