Re: [PATCH 3/6] acpi : remove pointless cpuidle device state_count init

On Friday, September 07, 2012, Daniel Lezcano wrote:

The cpuidle core takes care of filling this field from drv->state_count.

I'm not quite sure this is always valid. If dev has already been initialized and dev->state_count is different from 0, cpuidle_enable_device() doesn't actually change it.

Have you considered all of the possible scenarios?

Rafael

Signed-off-by: Daniel Lezcano daniel.lezcano@linaro.org

drivers/acpi/processor_idle.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c index 084b1d2..fc4757e 100644 --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c @@ -1035,8 +1035,6 @@ static int acpi_processor_setup_cpuidle_cx(struct acpi_processor *pr) break; }

• dev->state_count = count;
• if (!count) return -EINVAL;