On 3 November 2014 14:13, Ivan T. Ivanov iivanov@mm-sol.com wrote:
Hi,
On Mon, 2014-11-03 at 13:37 +0100, Vincent Guittot wrote:
Hi Ivan,
I have intentionally not put the string of "suspend" key in the example because the workgen script will do the check
So is it supposed to emit error, or what?
It will not emit an error with workgen but the script will add the missing name to the "suspend" key if no present. So both formats are accepted if you use workgen whereas the thread name is mandatory if you directly call rt-app The goal is to keep the example files simple. In the case of "suspend", the primary goal is to suspend the thread that contains the "suspend" so we can easily add it at runtime with a script.
and others (like unique key id) before calling rt-app. Adding a detailed documentation of how to use rt-app and workgen is my top priority action of my todo list
Ok. probably I have not understood purpose of the workgen script. Is is supposed to be executed on the target machine? This will be really to bad, it will be pain to compile/install python on my little target :-)
Yes the goal is to use workgen on the target. I also admit that some people (like you) don't want to install a lot of things on their little target. I can add the name in the examples file so it can be use directly with rt-app
But you will have another potential issue: having a unique key id at each json object level. workgen also takes care of that and i'm not sure that all the example comply with this constraint.
Nevertheless, we can add an option into workgen to only check use case file and output a corrected file instead of calling rt-app. So, you use workgen on your host to check/update the use case files and call rt-app with the checked file on the target
Vincent
Regards, Ivan