On 04/02/2012 11:58 AM, Jon Medhurst (Tixy) wrote:
On Mon, 2012-04-02 at 11:18 -0700, John Stultz wrote:
On 04/02/2012 10:29 AM, Jon Medhurst (Tixy) wrote:
On Mon, 2012-04-02 at 08:37 -0700, John Stultz wrote:
On 03/31/2012 02:17 AM, Jon Medhurst (Tixy) wrote:
We almost certainly need board specific android and ubuntu fragments as well, so I'll add vexpress-android.conf and vexpress-ubuntu.conf as well. (Unless there is some magic to have conditional config options in a fragment?)
No, the config fragments are pretty simple, so there's no conditional logic in them. Your idea for a board-type.conf style split sounds like a fair idea. Although, I'm curious what would be an example of this?
There's often let's-just-get-it-working hacks produced, and sometimes you don't want to risk breaking other boards by putting things into a common config.
My example of this is http://android.git.linaro.org/gitweb?p=kernel/vexpress-a9.git%3Ba=commit%3Bh...
Of course, this could be an argument for not enabling such things. ;-)
Ok. Interesting. I can see how this sort of flexibility is useful. So I'm fine if folks want to add board-distro specific tweaks. Trying to find some more unified way of building might be necessary, so folks aren't having to customize things too drastically. Your directory method seems like would solve this, but I need to spend some more time understanding Andy's suggestion and understanding how it works with Andrey's centralized tree.
Possibly if we just had a symlink
configs/omap_5430evm/base/main.conf --> arch/arm/configs/omap_5430evm_defconfig
That could be possible. Although the file location isn't critical for the merge_config.sh tool, so the sym link is only necessary if we are trying to come with with a more generic config generation script in the builder.
In other words, if each build script has to have a custom merge_config line (much as it currently has a custom make X_defconfig line), we can just add any extra tweaks or hacks there.
but then that defconfig has some non board specific stuff, like EXT file-systems configured. And Andrey's Android branch would have TI's Android topics, so that 'base' defconfig file would also gain TI's Android flavourings. (Neither of these issues might be a problem in practice.)
Indeed. The non-board specific items in the defconfigs would likely be an issue, but I guess we could push the LT's to cleanup where those issues were noticed.
thanks -john