27 Oct
2012
27 Oct
'12
4:18 p.m.
On 10/27/2012 06:00 PM, Rajanikanth HV wrote:
On 27 October 2012 20:37, Francesco Lavra francescolavra.fl@gmail.com wrote:
On 10/25/2012 08:30 AM, Rajanikanth H.V wrote:
From: "Rajanikanth H.V" rajanikanth.hv@stericsson.com
bat_tech = of_get_property(np_bat_supply,"stericsson,battery-type", NULL);if (!bat_tech)dev_warn(dev, "missing property battery-name/type\n");if (strncmp(bat_tech, "LION", 4) == 0) {What if bat_tech is NULL?
It will be UNKNOWN
I wanted to draw your attention to the fact that if bat_tech is NULL you are passing a NULL pointer to strncmp(), which is not good. So you should assign a default value to bat_tech in case the battery type property is not found in the DT, as below:
if (!bat_tech) { dev_warn(dev, "missing property battery-name/type\n"); bat_tech = "UNKNOWN"; }
-- Francesco