On Thu, May 17, 2012 at 09:34:26AM -0500, Rob Lee wrote:
On Wed, May 16, 2012 at 12:38 PM, Sascha Hauer s.hauer@pengutronix.de wrote:
Hi Robert,
Overall this looks ok now, some comments inline.
- return ret;
- if (cpu_is_mx51())
- suspend_set_ops(&mx5_suspend_ops);
Now this is called only in i.MX51 context, so you can skip the cpu_is
After this patch series this is also called in i.MX53 context. I'm not confident about the i.MX53 suspend/resume and would prefer to perform further testing and address issues with it in a separate patch series.
In this case there is also the possibility that you add a imx51_pm_init in which you set the suspend_ops and call imx5_pm_init afterwards. The cpu_is_macros a kind of deprecated. Instead we settled on calling functions with the exact SoC name from the (dt-) board files and call the more generic function from the SoC specific ones.
Sascha