Re: [RFC PATCH 04/10] sched: Introduce priority-based task migration filter

On 22 September 2012 00:02, morten.rasmussen@arm.com wrote:

Hi Morten,

I would try to review your patches in coming days. For now, Just reporting a problem which i encountered during routine build.

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 490f1f0..8f0f3b9 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3129,9 +3129,12 @@ static int __init hmp_cpu_mask_setup(void)

• hmp_down_threshold: max. load allowed for tasks migrating to a slower cpu
• The default values (512, 256) offer good responsiveness, but may need
• tweaking suit particular needs.

• • hmp_up_prio: Only up migrate task with high priority (<hmp_up_prio)
  */

unsigned int hmp_up_threshold = 512; unsigned int hmp_down_threshold = 256;

#ifdef CONFIG_SCHED_HMP_PRIO_FILTER

+unsigned int hmp_up_prio = NICE_TO_PRIO(CONFIG_SCHED_HMP_PRIO_FILTER_VAL);

#endif

is required here for successful build without CONFIG_SCHED_HMP_PRIO_FILTER_VAL.

-- viresh