Hello Shawn,
On Sun, 24 Jul 2011 12:23:44 -0700 Shawn Pearce sop@google.com wrote:
- Submitted a change for branch X to Gerrit.
- In the meantime, I also created a personal branch Y in the same
repository for integration testing. 3. Once that branch Y is pushed into Gerrit, the original change (still designated for branch X) is closed as "Merged", with comment added "Change has been successfully pushed into branch Y."
[]
I thought we fixed this. Maybe its only fixed in "master" and hasn't been released yet?
The old logic matched on Change-Id alone, and allowed a change to be closed if that Change-Id was pushed into any branch. IIRC current master matches on Change-Id *AND* branch pair, so pushing a commit with the same Change-Id into a different branch won't close the open change.
Thanks for confirming the intended behavior. Those commits didn't even use Change-Id, is the logic for pure git revid's is different?