On Mon, Oct 01, 2012 at 06:03:54PM +0100, Jon Medhurst (Tixy) wrote:
On Mon, 2012-10-01 at 17:33 +0100, Dave Martin wrote:
On Thu, Sep 27, 2012 at 07:06:20PM +0100, Jon Medhurst (Tixy) wrote:
- if (offset >= 0) {
p = fdt_getprop(fdt, offset, "reg", &len);if(len != (addrcells + sizecells) * 4)info("Failed parsing device-tree node for CCI\n");elseinit_cci(fdt32_to_cpu(p[addrcells - 1]));I think this is worth a comment. I presume you're trying to get the low 32 bits of the address here (and assuming that the high 32 bits are zero).
That's correct. I've been assuming this bootwrapper is only good for 32-bit systems anyway, or am I mistake?
Yes sure. Unless we turn the MMU on, we can't access any peripherals beyond 4GB, so this limit is currently inherent all over the place.
My comment was just due to the fact that I ended up scratching my head for a bit figuring out what the [addrcells - 1] was actually doing.
I'll add an appropriate comment either way.
Thanks -- I don't think is needs more than a 1-liner.
Cheers ---Dave