On 11/15/2012 04:04 AM, Preeti Murthy wrote:
Hi all,
The code looks correct and inviting to me as it has led to good cleanups. I dont think passing 0 as the argument to the function sched_clock_idle_wakeup_event() should lead to problems,as it does not do anything useful with the passed arguments.
My only curiosity is what was the purpose of passing idle residency time to sched_clock_idle_wakeup_event() when this data could always be retrieved from dev->last_residency for each cpu,which gets almost immediately updated.
sched_clock_idle_wakeup_event() is part of the scheduler. The scheduler doesn't know what a cpuidle_device is, and probably should not grow such a dependency.
cheers, -Len Brown, Intel Open Source Technology Center
But this does not seem to come in way of this patch for now.Anyway I have added Peter to the list so that he can opine about this issue if possible and needed.
Reviewed-by: Preeti U Murthy preeti@linux.vnet.ibm.com
Regards Preeti U Murthy