Re: [PATCH v4 5/7] ARM: imx: Add common imx cpuidle init functionality.

On Tue, May 15, 2012 at 09:33:34PM -0500, Robert Lee wrote:

Add common cpuidle init functionality that can be used by various imx platforms.

Signed-off-by: Robert Lee rob.lee@linaro.org

+#ifdef CONFIG_CPU_IDLE +extern int imx_cpuidle_init(struct cpuidle_driver *drv); +#else +static inline int imx_cpuidle_init(struct cpuidle_driver *drv) +{

• return -ENODEV;

+} +#endif

You should return succesfully here. Think about it, if imx_cpuidle_init fails you basically do nothing except maybe printing an error message which will be irritating when it appears on a kernel with cpuidle disabled.

Sascha