Hi John,
On 12 April 2013 00:31, John Stultz john.stultz@linaro.org wrote:
On 04/11/2013 11:28 AM, Naresh Kamboju wrote:
Hi All,
Greetings from Linaro QA services. We have setup the process of validating Linux on ARM Kernel builds. One of those ARM targets is Snowball. Snowball build broken log can be found here
Build Error:
04:48:08 CC drivers/mfd/ab8500-debugfs.o 04:48:09
/mnt/ci_build/workspace/linux-next/hwpack/snowball/label/precise_hwpack_cloud/drivers/mfd/ab8500-debugfs.c:95:23: fatal error: mach/irqs.h: No such file or directory 04:48:09 compilation terminated. 04:48:09 make[3]: *** [drivers/mfd/ab8500-debugfs.o] Error 1 04:48:09 make[2]: *** [drivers/mfd] Error 2 04:48:09 make[1]: *** [drivers] Error 2
Code snippet:
drivers/mfd/ab8500-debugfs.c
89 #ifdef CONFIG_DEBUG_FS 90 #include <linux/string.h> 91 #include <linux/ctype.h> 92 #endif 93 94 /* TODO: this file should not reference IRQ_DB8500_AB8500! */ 95 #include <mach/irqs.h> 96 97 static u32 debug_bank; 98 static u32 debug_address; 99
First of all, this is very cool output to see! A few thoughts..
It might also be good to get the maintainers of the affected file on cc.
This can be done automatically via: $ ./scripts/get_maintainer.pl -f drivers/mfd/ab8500-debugfs.c Srinidhi Kasagar srinidhi.kasagar@stericsson.com (maintainer:ARM/Ux500 ARM AR) Linus Walleij linus.walleij@linaro.org (maintainer:ARM/Ux500 ARM ARC...) Samuel Ortiz sameo@linux.intel.com (supporter:MULTIFUNCTION DEV...) linux-arm-kernel@lists.infradead.org (moderated list:ARM/Ux500 ARM ARC...) linux-kernel@vger.kernel.org (open list)
Interesting ! Thanks for the tips and tricks.
You might also be able to pull recent patch authors into the cc as well with something like:
$ git log --pretty=%aE drivers/mfda/ab8500-debugfs.c | head -n 3 linus.walleij@linaro.org philippe.langlais@linaro.org ashok.g@stericsson.com
Good idea indeed !
I am a little curious how these automated messages will be received on lkml (I don't think I've seen the kbuild test robot output directly on lkml).
This Email sent manually. we need to investigate kbuild test robot (which something i need to learn)
Would cc'ing the linux-next mailing list be better when testing linux-next?
Sure. your comments will be addressed in next e-mail
Also, I'm sure you see this error caused two almost identical messages. Not sure why the messages were slightly different? Regardless, we'll want to avoid sending dups to mailing lists.
The reason for sending duplicate messages without having html link is, first one is bounsed back saying that "Content-Policy reject msg: The message contains HTML subpart, therefore we consider it SPAM or Outlook Virus. "
Overall, great to see this work moving forward!
thanks -john
Best regards Naresh Kamboju