Re: [PATCH v9 2/3] mmc: core: add random fault injection

2011/8/19 Per Forlin per.forlin@stericsson.com:

+#ifdef KERNEL +/*

• • Internal function. Pass the boot param fail_mmc_request to
• • the setup fault injection attributes routine.
• */

+static int __init setup_fail_mmc_request(char *str) +{

• return setup_fault_attr(&fail_mmc_request, str);

+} +__setup("fail_mmc_request=", setup_fail_mmc_request); +#endif /* KERNEL */

You attempt to enable __setup() only when mmc_core is built into the kernel. Does it really work? I cannot find any drivers using "KERNEL" macro.

You can use module_param_cb() instead of __setup() without #ifdef KERNEL. When mmc_core is built into the kernel, you can specify the parameter with "mmc_core.fail_mmc_request=..."

Sorry for pointing that out too late.