21 Jul
2011
21 Jul
'11
8:40 p.m.
On Thursday 21 July 2011 16:47:48 Mark Brown wrote:
On Thu, Jul 21, 2011 at 11:46:32PM +0800, Shawn Guo wrote:
On Tue, Jul 05, 2011 at 08:07:00PM +0530, ashishj3 wrote:
- mutex_lock_interruptible(&da9052->io_lock);
Compile warning as below.
"warning: ignoring return value of ‘mutex_lock_interruptible’, declared with attribute warn_unused_result"
Although the bigger problem is why are these interruptible? That's very unusual.
Well, the default should really be to use _interruptible or at least _killable with the appropriate error handling, and only use noninterruptible locks in cases where that's not possible.
In the funtions that Shawn pointed out, there is an error return, so it would be possible to do that, but the callers would need to be audited carefully.
Arnd