On 12 August 2011 17:49, Alan Stern stern@rowland.harvard.edu wrote:
On Fri, 12 Aug 2011, Felipe Balbi wrote:
On Mon, Aug 08, 2011 at 11:43:35PM +0200, Per Forlin wrote:
FSG_NUM_BUFFERS is set to 2 as default. Usually 2 buffers are enough to establish a good buffering pipeline. The number may be increased in order to compensate a for bursty VFS behaviour.
would it make sense to have this as a module parameter so we don't need to recompile the driver everytime we want to test the driver with a different number of buffers ??
Alan ?
People generally object to new module parameters unless there's a very good reason for them.
Since people won't want to experiment with changing this value unless they're debugging anyway, we might make it a conditional module parameter -- don't define the parameter unless CONFIG_USB_DEBUG is enabled.
I like this proposal. I'll send out a new version of this patch using module_param instead of kconfig.
Thanks, Per