Re: [PATCH] pinctrl: Iterate over u300_pmx_mask's in u300_pmx_endisable

On Tue, Nov 15, 2011 at 7:40 AM, Rajendra Nayak rnayak@ti.com wrote:

Fix u300_pmx_endisable() to iterate over the list of 'bits' and 'mask' populated as part of u300_pmx_functions.mask[]

Signed-off-by: Rajendra Nayak rnayak@ti.com

Linus W, I am not sure if this is a right fix. I just stumbled upon this while looking at the u300 pinmux driver while I was writing one for OMAP. Maybe I am reading the code completely wrong, and I don't even have a way to test this, so its just compile tested with u300_defconfig.

Looks correct and works, I've just been saved by the fact that most mux settings are in a good default mode when powering on the system.

Thanks, applied! Linus Walleij