Re: [PATCH 10/17][V2] ARM: OMAP3: cpuidle - remove the 'valid' field

On 04/10/2012 01:13 AM, Kevin Hilman wrote:

Daniel Lezcanodaniel.lezcano@linaro.org writes:

...

With the previous changes all the states are valid, except the last state which can be handled by decreasing the number of states.

Signed-off-by: Daniel Lezcanodaniel.lezcano@linaro.org Reviewed-by: Jean Pihetj-pihet@ti.com

---

[ ... ]

...

if (IS_PM34XX_ERRATUM(PM_SDRC_WAKEUP_ERRATUM_i583)) {

• cx->valid = 0;
  

• drv->state_count = OMAP3_NUM_STATES - 1;
  

  pr_warn("%s: core off state C7 disabled due to i583\n", __func__);

I'm not too particular about this one, but it might be cleaner to just remove this check all together. This errata already has a check in next_valid_state() so strictly speaking, it's not needed here.

Yes, right. Thanks for pointing this.