On Thu, Jan 12, 2012 at 04:04:23PM -0800, Saravana Kannan wrote:
While the original clk_hw suggestion was well intentioned, it just forces too many unnecessary dereferences and indirection. It also prevents static init of some fields as others have mentioned. Overall, it made the MSM clock code a mess when I tried to convert it to the common clock framework during Linaro Connect Q4 2011.
The current off-tree MSM clock code uses a very similar approach to what the original patches that Jeremy sent out did. When Mike sent out the patches that removed clk_hw, the MSM code was much clearer and easier to convert to the common clock framework.
I share the same feeling with migrating imx6 clock support to v2 and v3 of this series. (v2 uses clk_hw, and v3 removes clk_hw.)