The patch 'arm/dt: Add dtb make rule' adds support to create a .dtb file. But this is never removed afterwards. Remove the generated .dtb file if 'distclean' is called.
Signed-off-by: Dirk Behme dirk.behme@de.bosch.com CC: Rob Herring rob.herring@calxeda.com CC: Shawn Guo shawn.guo@freescale.com CC: Jason Liu jason.hui@linaro.org CC: Grant Likely grant.likely@secretlab.ca --- arch/arm/boot/Makefile | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile index 1cd9b0a..08f0d35 100644 --- a/arch/arm/boot/Makefile +++ b/arch/arm/boot/Makefile @@ -71,6 +71,8 @@ $(obj)/%.dtb: $(src)/dts/%.dts
$(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y))
+clean-files := *.dtb + quiet_cmd_uimage = UIMAGE $@ cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \ -C none -a $(LOADADDR) -e $(STARTADDR) \
On Sat, Nov 05, 2011 at 07:19:15AM +0100, Dirk Behme wrote:
The patch 'arm/dt: Add dtb make rule' adds support to create a .dtb file. But this is never removed afterwards. Remove the generated .dtb file if 'distclean' is called.
Signed-off-by: Dirk Behme dirk.behme@de.bosch.com CC: Rob Herring rob.herring@calxeda.com CC: Shawn Guo shawn.guo@freescale.com CC: Jason Liu jason.hui@linaro.org CC: Grant Likely grant.likely@secretlab.ca
Acked-by: Grant Likely grant.likely@secretlab.ca
arch/arm/boot/Makefile | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile index 1cd9b0a..08f0d35 100644 --- a/arch/arm/boot/Makefile +++ b/arch/arm/boot/Makefile @@ -71,6 +71,8 @@ $(obj)/%.dtb: $(src)/dts/%.dts $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y)) +clean-files := *.dtb
quiet_cmd_uimage = UIMAGE $@ cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \ -C none -a $(LOADADDR) -e $(STARTADDR) \ -- 1.7.0.4
On Sun, Nov 6, 2011 at 11:38 AM, Grant Likely grant.likely@secretlab.ca wrote:
On Sat, Nov 05, 2011 at 07:19:15AM +0100, Dirk Behme wrote:
The patch 'arm/dt: Add dtb make rule' adds support to create a .dtb file. But this is never removed afterwards. Remove the generated .dtb file if 'distclean' is called.
Signed-off-by: Dirk Behme dirk.behme@de.bosch.com CC: Rob Herring rob.herring@calxeda.com CC: Shawn Guo shawn.guo@freescale.com CC: Jason Liu jason.hui@linaro.org CC: Grant Likely grant.likely@secretlab.ca
Acked-by: Grant Likely grant.likely@secretlab.ca
... although why are only the .dtb files needed in the clean list? How are the other built files cleaned? 'make clean' does remove the other images, but I don't know what the mechanism is.
g.
arch/arm/boot/Makefile | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile index 1cd9b0a..08f0d35 100644 --- a/arch/arm/boot/Makefile +++ b/arch/arm/boot/Makefile @@ -71,6 +71,8 @@ $(obj)/%.dtb: $(src)/dts/%.dts
$(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y))
+clean-files := *.dtb
quiet_cmd_uimage = UIMAGE $@ cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \ -C none -a $(LOADADDR) -e $(STARTADDR) \ -- 1.7.0.4
On 06.11.2011 19:42, Grant Likely wrote:
On Sun, Nov 6, 2011 at 11:38 AM, Grant Likelygrant.likely@secretlab.ca wrote:
On Sat, Nov 05, 2011 at 07:19:15AM +0100, Dirk Behme wrote:
The patch 'arm/dt: Add dtb make rule' adds support to create a .dtb file. But this is never removed afterwards. Remove the generated .dtb file if 'distclean' is called.
Signed-off-by: Dirk Behmedirk.behme@de.bosch.com CC: Rob Herringrob.herring@calxeda.com CC: Shawn Guoshawn.guo@freescale.com CC: Jason Liujason.hui@linaro.org CC: Grant Likelygrant.likely@secretlab.ca
Acked-by: Grant Likelygrant.likely@secretlab.ca
... although why are only the .dtb files needed in the clean list? How are the other built files cleaned? 'make clean' does remove the other images, but I don't know what the mechanism is.
A lot of stuff is removed by the top level Makefile [1]. But as the patch "arm/dt: Add dtb make rule" adds the .dtb generation to arch/arm/boot/Makefile, we thought it would be a good place to add the removal of that file there, too.
Hmm, not sure if this answers your question, though ;)
Best regards
Dirk
[1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git%3Ba=blob%3Bf=Ma...
arch/arm/boot/Makefile | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile index 1cd9b0a..08f0d35 100644 --- a/arch/arm/boot/Makefile +++ b/arch/arm/boot/Makefile @@ -71,6 +71,8 @@ $(obj)/%.dtb: $(src)/dts/%.dts
$(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y))
+clean-files := *.dtb
- quiet_cmd_uimage = UIMAGE $@ cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \ -C none -a $(LOADADDR) -e $(STARTADDR) \
-- 1.7.0.4
On Nov 6, 2011 11:25 PM, "Dirk Behme" dirk.behme@googlemail.com wrote:
On 06.11.2011 19:42, Grant Likely wrote:
On Sun, Nov 6, 2011 at 11:38 AM, Grant Likelygrant.likely@secretlab.ca
wrote:
On Sat, Nov 05, 2011 at 07:19:15AM +0100, Dirk Behme wrote:
The patch 'arm/dt: Add dtb make rule' adds support to create a .dtb file. But this is never removed afterwards. Remove the generated .dtb file if 'distclean' is called.
Signed-off-by: Dirk Behmedirk.behme@de.bosch.com CC: Rob Herringrob.herring@calxeda.com CC: Shawn Guoshawn.guo@freescale.com CC: Jason Liujason.hui@linaro.org CC: Grant Likelygrant.likely@secretlab.ca
Acked-by: Grant Likelygrant.likely@secretlab.ca
... although why are only the .dtb files needed in the clean list? How are the other built files cleaned? 'make clean' does remove the other images, but I don't know what the mechanism is.
A lot of stuff is removed by the top level Makefile [1]. But as the patch
"arm/dt: Add dtb make rule" adds the .dtb generation to arch/arm/boot/Makefile, we thought it would be a good place to add the removal of that file there, too.
Hmm, not sure if this answers your question, though ;)
Okay. Good enough for me.
g.
On 11/05/2011 01:19 AM, Dirk Behme wrote:
The patch 'arm/dt: Add dtb make rule' adds support to create a .dtb file. But this is never removed afterwards. Remove the generated .dtb file if 'distclean' is called.
Signed-off-by: Dirk Behme dirk.behme@de.bosch.com CC: Rob Herring rob.herring@calxeda.com CC: Shawn Guo shawn.guo@freescale.com CC: Jason Liu jason.hui@linaro.org CC: Grant Likely grant.likely@secretlab.ca
Acked-by: Rob Herring rob.herring@calxeda.com
arch/arm/boot/Makefile | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile index 1cd9b0a..08f0d35 100644 --- a/arch/arm/boot/Makefile +++ b/arch/arm/boot/Makefile @@ -71,6 +71,8 @@ $(obj)/%.dtb: $(src)/dts/%.dts $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y)) +clean-files := *.dtb
quiet_cmd_uimage = UIMAGE $@ cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \ -C none -a $(LOADADDR) -e $(STARTADDR) \
On 07.11.2011 14:51, Rob Herring wrote:
On 11/05/2011 01:19 AM, Dirk Behme wrote:
The patch 'arm/dt: Add dtb make rule' adds support to create a .dtb file. But this is never removed afterwards. Remove the generated .dtb file if 'distclean' is called.
Signed-off-by: Dirk Behmedirk.behme@de.bosch.com CC: Rob Herringrob.herring@calxeda.com CC: Shawn Guoshawn.guo@freescale.com CC: Jason Liujason.hui@linaro.org CC: Grant Likelygrant.likely@secretlab.ca
Acked-by: Rob Herringrob.herring@calxeda.com
...
Acked-by: Grant Likely grant.likely@secretlab.ca
Submitted to Russell King's Patch Tracking System:
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7152/1
Thanks
Dirk
arch/arm/boot/Makefile | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile index 1cd9b0a..08f0d35 100644 --- a/arch/arm/boot/Makefile +++ b/arch/arm/boot/Makefile @@ -71,6 +71,8 @@ $(obj)/%.dtb: $(src)/dts/%.dts
$(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y))
+clean-files := *.dtb
- quiet_cmd_uimage = UIMAGE $@ cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \ -C none -a $(LOADADDR) -e $(STARTADDR) \
-
Dirk Behme -
Grant Likely -
Rob Herring