From: Linus Walleij linus.walleij@linaro.org
Machines that have embedded pin controllers need to select them explicitly, so why broadcast their config options to menuconfig. We provide a helpful submenu for those machines that do select it, making it possible to enable debugging for example.
Reported-by: Linus Torvalds torvalds@linux-foundation.org Signed-off-by: Linus Walleij linus.walleij@linaro.org --- drivers/pinctrl/Kconfig | 15 +++++++-------- 1 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index ef56644..e816f60 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -2,18 +2,15 @@ # PINCTRL infrastructure and drivers #
-menuconfig PINCTRL - bool "PINCTRL Support" +config PINCTRL + bool depends on EXPERIMENTAL - help - This enables the PINCTRL subsystem for controlling pins - on chip packages, for example multiplexing pins on primarily - PGA and BGA packages for systems on chip. - - If unsure, say N.
if PINCTRL
+menu "Pin controllers" + depends on PINCTRL + config PINMUX bool "Support pinmux controllers" help @@ -40,4 +37,6 @@ config PINMUX_U300 help Say Y here to enable the U300 pinmux driver
+endmenu + endif
Linus Walleij wrote at Monday, November 07, 2011 7:15 AM:
From: Linus Walleij linus.walleij@linaro.org
Machines that have embedded pin controllers need to select them explicitly, so why broadcast their config options to menuconfig. We provide a helpful submenu for those machines that do select it, making it possible to enable debugging for example.
...
-menuconfig PINCTRL
- bool "PINCTRL Support"
+config PINCTRL
- bool depends on EXPERIMENTAL
- help
This enables the PINCTRL subsystem for controlling pinson chip packages, for example multiplexing pins on primarilyPGA and BGA packages for systems on chip.If unsure, say N.
This seems OK.
if PINCTRL
+menu "Pin controllers"
- depends on PINCTRL
config PINMUX bool "Support pinmux controllers" help
But shouldn't PINMUX and PINMUX_${soc} also have their help text removed; it seems like if a SoC selects PINCTRL, it would also select PINMUX if appropriate, and the relevant PINMUX_${soc} too?
I assume there are also patches for arch/arm/mach-${foo}/Kconfig somewhere to select PINCTRL when appropriate; they didn't show up in my inbox, but I haven't checked my sub-folders yet, so perhaps they're already there.
On Mon, Nov 7, 2011 at 5:23 PM, Stephen Warren swarren@nvidia.com wrote:
Linus Walleij wrote at Monday, November 07, 2011 7:15 AM:
if PINCTRL
+menu "Pin controllers"
- depends on PINCTRL
config PINMUX bool "Support pinmux controllers" help
But shouldn't PINMUX and PINMUX_${soc} also have their help text removed; it seems like if a SoC selects PINCTRL, it would also select PINMUX if appropriate, and the relevant PINMUX_${soc} too?
Yep, you're absolutely right, let's cut the crap.
I assume there are also patches for arch/arm/mach-${foo}/Kconfig somewhere to select PINCTRL when appropriate; they didn't show up in my inbox, but I haven't checked my sub-folders yet, so perhaps they're already there.
The U300 one is already in arch/arm/mach-u300/Kconfig
The SirfPrimaII will be part of that platform (still out-of-tree). They have to start somewhere ... those guys need pinmux to even get the UART working.
Thanks, Linus Walleij
-
Linus Walleij -
Linus Walleij -
Stephen Warren