From: Venkatraman S venkat@linaro.org
Signed-off-by: Venkatraman S venkat@linaro.org --- drivers/gpio/gpio-exynos4.c | 2 +- drivers/gpio/gpio-nomadik.c | 2 +- drivers/gpio/gpio-s5pv210.c | 1 + drivers/gpio/pl061.c | 1 + 4 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-exynos4.c b/drivers/gpio/gpio-exynos4.c index 9029835..e62ae64 100644 --- a/drivers/gpio/gpio-exynos4.c +++ b/drivers/gpio/gpio-exynos4.c @@ -16,7 +16,7 @@ #include <linux/gpio.h>
#include <mach/map.h> - +#include <mach/irqs.h> #include <plat/gpio-core.h> #include <plat/gpio-cfg.h> #include <plat/gpio-cfg-helpers.h> diff --git a/drivers/gpio/gpio-nomadik.c b/drivers/gpio/gpio-nomadik.c index 2c212c7..b5bd94b 100644 --- a/drivers/gpio/gpio-nomadik.c +++ b/drivers/gpio/gpio-nomadik.c @@ -29,7 +29,7 @@ #include <plat/pincfg.h> #include <mach/hardware.h> #include <mach/gpio.h> - +#include <mach/irqs.h> /* * The GPIO module in the Nomadik family of Systems-on-Chip is an * AMBA device, managing 32 pins and alternate functions. The logic block diff --git a/drivers/gpio/gpio-s5pv210.c b/drivers/gpio/gpio-s5pv210.c index 1ba20a7..6931e43 100644 --- a/drivers/gpio/gpio-s5pv210.c +++ b/drivers/gpio/gpio-s5pv210.c @@ -18,6 +18,7 @@ #include <plat/gpio-cfg.h> #include <plat/gpio-cfg-helpers.h> #include <mach/map.h> +#include <mach/irqs.h>
static struct s3c_gpio_cfg gpio_cfg = { .set_config = s3c_gpio_setcfg_s3c64xx_4bit, diff --git a/drivers/gpio/pl061.c b/drivers/gpio/pl061.c index 6fcb28c..1dd082d 100644 --- a/drivers/gpio/pl061.c +++ b/drivers/gpio/pl061.c @@ -25,6 +25,7 @@ #include <linux/amba/bus.h> #include <linux/amba/pl061.h> #include <linux/slab.h> +#include <mach/irqs.h>
#define GPIODIR 0x400 #define GPIOIS 0x404
On Tue, 23 Aug 2011, Venkatraman S wrote:
From: Venkatraman S venkat@linaro.org
Signed-off-by: Venkatraman S venkat@linaro.org
drivers/gpio/gpio-exynos4.c | 2 +- drivers/gpio/gpio-nomadik.c | 2 +- drivers/gpio/gpio-s5pv210.c | 1 + drivers/gpio/pl061.c | 1 +
Same issue as for patch #14/24. One of the big issue with the GPIO code is its reliance on <mach/gpio.h> which has to be solved already, since in a multi SOC kernel we just don't know which of the many <mach/irqs.h> we want to include.
I think that one of the solution for this would involve making <mach/*.h> into <mach/$soc_name/*.h> up front... meaning that we recurse again another level down with all its implications.
Nicolas
On 23 August 2011 23:56, Nicolas Pitre nicolas.pitre@linaro.org wrote:
On Tue, 23 Aug 2011, Venkatraman S wrote:
From: Venkatraman S venkat@linaro.org
Signed-off-by: Venkatraman S venkat@linaro.org
drivers/gpio/gpio-exynos4.c | 2 +- drivers/gpio/gpio-nomadik.c | 2 +- drivers/gpio/gpio-s5pv210.c | 1 + drivers/gpio/pl061.c | 1 +
Same issue as for patch #14/24. One of the big issue with the GPIO code is its reliance on <mach/gpio.h> which has to be solved already, since in a multi SOC kernel we just don't know which of the many <mach/irqs.h> we want to include.
I think that one of the solution for this would involve making <mach/*.h> into <mach/$soc_name/*.h> up front... meaning that we recurse again another level down with all its implications.
Thanks for the review. Can't we just rename the files then ? gpio-exynos.h gpio-nomadik.h and so on, and move all, or part of the contents to drivers ?
On Wed, 24 Aug 2011, Venkatraman S wrote:
On 23 August 2011 23:56, Nicolas Pitre nicolas.pitre@linaro.org wrote:
On Tue, 23 Aug 2011, Venkatraman S wrote:
From: Venkatraman S venkat@linaro.org
Signed-off-by: Venkatraman S venkat@linaro.org
drivers/gpio/gpio-exynos4.c | 2 +- drivers/gpio/gpio-nomadik.c | 2 +- drivers/gpio/gpio-s5pv210.c | 1 + drivers/gpio/pl061.c | 1 +
Same issue as for patch #14/24. One of the big issue with the GPIO code is its reliance on <mach/gpio.h> which has to be solved already, since in a multi SOC kernel we just don't know which of the many <mach/irqs.h> we want to include.
I think that one of the solution for this would involve making <mach/*.h> into <mach/$soc_name/*.h> up front... meaning that we recurse again another level down with all its implications.
Thanks for the review. Can't we just rename the files then ? gpio-exynos.h gpio-nomadik.h and so on, and move all, or part of the contents to drivers ?
Something along those lines was being looked at by Linus Walleij and Ben Dooks.
Nicolas
On Wed, Aug 24, 2011 at 7:38 PM, Venkatraman S svenkatr@ti.com wrote:
Thanks for the review. Can't we just rename the files then ? gpio-exynos.h gpio-nomadik.h and so on, and move all, or part of the contents to drivers ?
I thought so too! So I have already done it, for nomadik.
Russell has merge that into his gpio branch and you can see the result in linux-next.
<plat/gpio-nomadik.h> is already done <mach-[nomadik|ux500]/gpio.h> only contain gpiolib defines
Can you do the split for exynos? Else I can take a stab at it.
Yours, Linus Walleij