The same clock is used for all cpus so we must notify the frequency change for each one in order to update the configuration of all twd clockevents.
Signed-off-by: Vincent Guittot vincent.guittot@linaro.org --- drivers/cpufreq/db8500-cpufreq.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/cpufreq/db8500-cpufreq.c b/drivers/cpufreq/db8500-cpufreq.c index 0d8dd1c..4cb5785 100644 --- a/drivers/cpufreq/db8500-cpufreq.c +++ b/drivers/cpufreq/db8500-cpufreq.c @@ -76,13 +76,13 @@ static int db8500_cpufreq_target(struct cpufreq_policy *policy,
freqs.old = policy->cur; freqs.new = freq_table[idx].frequency; - freqs.cpu = policy->cpu;
if (freqs.old == freqs.new) return 0;
/* pre-change notification */ - cpufreq_notify_transition(&freqs, CPUFREQ_PRECHANGE); + for_each_online_cpu(freqs.cpu) + cpufreq_notify_transition(&freqs, CPUFREQ_PRECHANGE);
/* request the PRCM unit for opp change */ if (prcmu_set_arm_opp(idx2opp[idx])) { @@ -91,7 +91,8 @@ static int db8500_cpufreq_target(struct cpufreq_policy *policy, }
/* post change notification */ - cpufreq_notify_transition(&freqs, CPUFREQ_POSTCHANGE); + for_each_online_cpu(freqs.cpu) + cpufreq_notify_transition(&freqs, CPUFREQ_POSTCHANGE);
return 0; }
On Wed, Aug 24, 2011 at 8:44 AM, Vincent Guittot vincent.guittot@linaro.org wrote:
Acked-by: Linus Walleij linus.walleij@linaro.org
Yours, Linus Walleij
On Wed, Aug 24, 2011 at 4:42 PM, Linus Walleij linus.walleij@linaro.org wrote:
BTW, does it same as other ARM cpus?. e.g., exynos4 has same codes as this.
How to you think it? Need to modify the same way?
Thank you, Kyungmin Park
On 24 August 2011 09:56, Kyungmin Park kmpark@infradead.org wrote:
yes, each ARM platform which uses twd timer should check that the notification is sent for each cpu.
On 24 August 2011 10:26, Santosh santosh.shilimkar@ti.com wrote:
You're right, I'm going to use policy->cpus instead
Regards Santosh
-
Kyungmin Park -
Linus Walleij -
Santosh -
Vincent Guittot