From: Venkatraman S venkat@linaro.org
Do not depend on the generic irq header file to include the platform specific header file.
Signed-off-by: Venkatraman S venkat@linaro.org --- drivers/video/omap/lcdc.c | 1 + drivers/video/omap/sossi.c | 1 + 2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/video/omap/lcdc.c b/drivers/video/omap/lcdc.c index 7767338..0c1b3b4 100644 --- a/drivers/video/omap/lcdc.c +++ b/drivers/video/omap/lcdc.c @@ -31,6 +31,7 @@ #include <linux/gfp.h>
#include <mach/lcdc.h> +#include <mach/irqs.h> #include <plat/dma.h>
#include <asm/mach-types.h> diff --git a/drivers/video/omap/sossi.c b/drivers/video/omap/sossi.c index 8fb7c70..a6bcaad 100644 --- a/drivers/video/omap/sossi.c +++ b/drivers/video/omap/sossi.c @@ -26,6 +26,7 @@ #include <linux/interrupt.h>
#include <plat/dma.h> +#include <mach/irqs.h>
#include "omapfb.h" #include "lcdc.h"
On Tue, 23 Aug 2011, Venkatraman S wrote:
From: Venkatraman S venkat@linaro.org
Do not depend on the generic irq header file to include the platform specific header file.
Signed-off-by: Venkatraman S venkat@linaro.org
This is wrong.
Obviously we don't want the generic <asm/irq.h> to include <mach/irqs.h> anymore, however we also want to get rid of any references to <mach/*.h> _outside_ of the machine specific directory too.
drivers/video/omap/lcdc.c | 1 + drivers/video/omap/sossi.c | 1 +
In this case the needed definitions are presumably only useful to those drivers, in which case they probably should be moved into those drivers directly, or better yet passed into struct resource instances.
Nicolas
-
Nicolas Pitre -
Venkatraman S