On Thursday 24 May 2012, John Stultz wrote:

On 05/23/2012 05:05 PM, John Stultz wrote:

...

Hey Arnd, So it looks like something has gone awry in the 3.5 pull with Panda's mmc functionality. Trying to boot the current 3.5-rc tree, the boot fails after not finding the root device. Looking at the boot log I'm seeing:

omap_hsmmc: probe of omap_hsmmc.0 failed with error -22

With the same config on 3.4 it boots up fine. I also tried w/ the omap2plus_defconfig and see the same behavior.

Before I start bisecting down, I just wanted to raise the issue here in case there's a known fix.

I went ahead and tried to bisect this down, and it was pretty painful as there's a omap-usb-host build bug somewhere near the issue that keeps me from being able to totally isolate it.

Anyway, the bisection finally pointed to this merge:

commit 8dca6010d44cc722a94dc6da96560f9083dac782 Merge: 9bc747b 74c4375 Author: Linus Torvalds torvalds@linux-foundation.org Date: Tue May 22 09:27:39 2012 -0700

Hmm, so the fixes branch by itself is fine and so is the commit before merging it.

The only commit that I see that can actually imact this seems to be 1ee47b0. Can you try reverting that?

The full list of changes in the fixes branch is this:

$ git log --oneline --stat v3.4..74c4375 74c4375 ARM: spear6xx: remove board selection options arch/arm/mach-spear6xx/Kconfig | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) 1b6c352 Merge tag 'omap-fixes-non-critical-for-v3.5' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux b6d3597 Merge tag 'v3.5-fixes-and-cleanups' of git://gitorious.org/linux-davinci/linux-davinci into next/fixes bdbaaf1 Merge branch 'for-3.5/fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-tegra into nex b2f44dc ARM: OMAP: igep0020: Specify the VPLL2 regulator unconditionally arch/arm/mach-omap2/board-igep0020.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) 0d09a95 ARM: OMAP2+: INTC: fix Kconfig option for TI81XX arch/arm/mach-omap2/irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d723c17 ARM: OMAP2+: remove incorrect irq_chip ack field arch/arm/mach-omap2/irq.c | 1 - 1 file changed, 1 deletion(-) 33ee0db ARM: OMAP4: Adding ID for OMAP4460 ES1.1 arch/arm/mach-omap2/id.c | 5 ++++- arch/arm/plat-omap/include/plat/cpu.h | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) def1dbb ARM: OMAP4: panda: add statics to remove warnings arch/arm/mach-omap2/board-omap4panda.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) 256a4bd ARM: OMAP2+: Incorrect Register Offsets in OMAP Mailbox arch/arm/mach-omap2/mailbox.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) 28ee793 ARM: OMAP: fix trivial warnings for dspbridge arch/arm/mach-omap2/dsp.c | 5 +++-- arch/arm/plat-omap/devices.c | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) 98e3b33 arm: davinci: use for_each_set_bit_from arch/arm/mach-davinci/dma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) 1ee47b0 ARM: OMAP4: hsmmc: check for null pointer arch/arm/mach-omap2/board-4430sdp.c | 44 -------------------------------------------- arch/arm/mach-omap2/board-omap4panda.c | 49 ------------------------------------------------- arch/arm/mach-omap2/common.h | 3 +++ arch/arm/mach-omap2/omap4-common.c | 58 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 61 insertions(+), 93 deletions(-) e54bdc1 ARM: OMAP1: fix compilation issue in board-sx1.c arch/arm/mach-omap1/Kconfig | 1 + 1 file changed, 1 insertion(+) 3d5e8af ARM: disable SUSPEND/ARCH_SUSPEND_POSSIBLE for ARCH_TEGRA arch/arm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) 59858b7 ARM: davinci: da850-evm: fix section mismatch arch/arm/mach-davinci/board-da850-evm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) aea812e ARM: tegra: add pll_x freq table entry for 750MHz arch/arm/mach-tegra/tegra2_clocks.c | 6 ++++++ 1 file changed, 6 insertions(+) d65566e ARM: davinci: mark spi_board_info arguments as const arch/arm/mach-davinci/davinci.h | 4 ++-- arch/arm/mach-davinci/devices-da8xx.c | 2 +- arch/arm/mach-davinci/dm355.c | 2 +- arch/arm/mach-davinci/dm365.c | 2 +- arch/arm/mach-davinci/include/mach/da8xx.h | 3 ++- 5 files changed, 7 insertions(+), 6 deletions(-) 4a6e6a5 ARM: davinci: fix incorrect pdctl next bit position arch/arm/mach-davinci/include/mach/psc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

 Merge tag 'fixes' of 

git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-s

 Pull non-critical arm-soc bug fixes from Olof Johansson:
  "These bug fixes were not important enough to have them included 

in the v3.4 release, mostly because they cover harmless warnings or unrealistic configurations. Instead we queue them up to be picked up in the next merge window."

 Fixed up trivial conflict in arch/arm/mach-omap2/board-omap4panda.c

 * tag 'fixes' of 

git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc: ARM: spear6xx: remove board selection options ARM: OMAP: igep0020: Specify the VPLL2 regulator unconditionally ARM: OMAP2+: INTC: fix Kconfig option for TI81XX ARM: OMAP2+: remove incorrect irq_chip ack field ARM: OMAP4: Adding ID for OMAP4460 ES1.1 ARM: OMAP4: panda: add statics to remove warnings ARM: OMAP2+: Incorrect Register Offsets in OMAP Mailbox ARM: OMAP: fix trivial warnings for dspbridge arm: davinci: use for_each_set_bit_from ARM: OMAP4: hsmmc: check for null pointer ARM: OMAP1: fix compilation issue in board-sx1.c ARM: disable SUSPEND/ARCH_SUSPEND_POSSIBLE for ARCH_TEGRA ARM: davinci: da850-evm: fix section mismatch ARM: tegra: add pll_x freq table entry for 750MHz ARM: davinci: mark spi_board_info arguments as const ARM: davinci: fix incorrect pdctl next bit position

But I'm a little skeptical due to the huge number of "git bisect skip"s required.

Full bisect log below, in case it helps thanks -john

git bisect start

# bad: [1259f6ee15c1603dcae41eb6af5a5f9cf932d4d6] Merge tag 'hwmon-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging

git bisect bad 1259f6ee15c1603dcae41eb6af5a5f9cf932d4d6

# good: [76e10d158efb6d4516018846f60c2ab5501900bc] Linux 3.4

git bisect good 76e10d158efb6d4516018846f60c2ab5501900bc

# good: [9bc747bea5fad819e0c0ad96e6a67ea0640dfe2b] Merge tag 'cleanup' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc

git bisect good 9bc747bea5fad819e0c0ad96e6a67ea0640dfe2b

# bad: [94b5aff4c6f72fee6b0f49d49e4fa8b204e8ded9] Merge tag 'tty-3.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty

git bisect bad 94b5aff4c6f72fee6b0f49d49e4fa8b204e8ded9

# good: [cda4db53e9c28061c100400e1a4d273ea61dfba9] Merge tag 'for-usb-next-2012-05-21' of git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci into usb-next

git bisect good cda4db53e9c28061c100400e1a4d273ea61dfba9

# bad: [cdd3a354a05b0c33fe33ab11a0fb0838396cad19] Merge tag 'pm' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc

git bisect bad cdd3a354a05b0c33fe33ab11a0fb0838396cad19

# bad: [9f639269ed1522c7d69c54cc8b80ab8ee53fcb10] Merge tag 'soc' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc

git bisect bad 9f639269ed1522c7d69c54cc8b80ab8ee53fcb10

# skip: [47fad7c6f8d9f64780793cc67d8280259538c31c] Merge tag 'at91-for-next-dt' of git://github.com/at91linux/linux-at91 into next/dt

git bisect skip 47fad7c6f8d9f64780793cc67d8280259538c31c

# skip: [70888a4b412abd55c1710e2d36a9a00f4d23f474] Merge branch 'ux500-devicetree-for-arm-soc' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-stericsson into next/dt

git bisect skip 70888a4b412abd55c1710e2d36a9a00f4d23f474

# good: [15787753d08107f2066b8ed8c9f8046ef3b766bb] ARM: at91: DT: add Calao TNY A9263 board support

git bisect good 15787753d08107f2066b8ed8c9f8046ef3b766bb

# good: [73d68d91aa1b9e9cb6c1635143799c0fec484c08] ARM: at91: Add ADC driver to at91sam9260/at91sam9g20 dtsi files

git bisect good 73d68d91aa1b9e9cb6c1635143799c0fec484c08

# good: [74c437532b8b5db53509963ec38e8424c56ff6f4] ARM: spear6xx: remove board selection options

git bisect good 74c437532b8b5db53509963ec38e8424c56ff6f4

# skip: [e86bde3caea693b2e615e7b3664e6273160bf864] Merge branch 'ux500-devicetree-for-arm-soc' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-stericsson into next/dt

git bisect skip e86bde3caea693b2e615e7b3664e6273160bf864

# skip: [6875dc6521be57f695845d13469109a388029e43] Merge branch 'spear/dt' into next/dt

git bisect skip 6875dc6521be57f695845d13469109a388029e43

# good: [e7c64db9f50d6523e20bc5b8f042645612e37b74] arm/dts: omap4-sdp: Add ks8851 ethernet SPI device

git bisect good e7c64db9f50d6523e20bc5b8f042645612e37b74

# good: [cce783c608fee0716cff65926d1835a5fd097b69] ARM: at91: Add DT description files for AT91SAM9N12-EK

git bisect good cce783c608fee0716cff65926d1835a5fd097b69

# good: [7f627f0380cb5ba3e05bcaac31ecf40c1f508ec1] mach-shmobile: Emma Mobile EV2 SoC base support V3

git bisect good 7f627f0380cb5ba3e05bcaac31ecf40c1f508ec1

# good: [450cca47d65b7500ba05d56770adbf8c758dc87d] mach-shmobile: Use DT_MACHINE for KZM9D V3

git bisect good 450cca47d65b7500ba05d56770adbf8c758dc87d

# good: [f3215b427bec2add8b5c776e8f50c3ba35b0e8f1] SPEAr: Update defconfigs

git bisect good f3215b427bec2add8b5c776e8f50c3ba35b0e8f1

# skip: [ace1297f7222ec5d6a33f41e792a21e999551924] Documentation: update docs for mmp dt

git bisect skip ace1297f7222ec5d6a33f41e792a21e999551924

# skip: [3f4dd3224df9664a44bf05df56c7c12622f7a1c7] ARM: mmp: append CONFIG_MACH_MMP2_DT

git bisect skip 3f4dd3224df9664a44bf05df56c7c12622f7a1c7

# skip: [3de3d74956e26af0a5647e98f73eaf8efd0d07bd] ARM: ux500: Configure the PRCMU Timer for db8500 based devices in DT

git bisect skip 3de3d74956e26af0a5647e98f73eaf8efd0d07bd

# skip: [be460385af1c40905dd6858a475bc949a3072b08] i2c-pnx.c: Remove duplicated i2c.h

git bisect skip be460385af1c40905dd6858a475bc949a3072b08

# skip: [4809f90aadb299743b8f8021ff386f0ef0392c86] ARM: ux500: Do not attempt to register non-existent i2c devices on Snowball

git bisect skip 4809f90aadb299743b8f8021ff386f0ef0392c86

# skip: [2cfaa62de5f1fa5ded043ffeb00548082ed30712] ARM: ux500: Enable the external bus with Device Tree

git bisect skip 2cfaa62de5f1fa5ded043ffeb00548082ed30712

# skip: [396d81cd0fe12ce5d1f6d159f093f9315d2837bc] Merge branch 'at91/dt' into next/dt

git bisect skip 396d81cd0fe12ce5d1f6d159f093f9315d2837bc

# skip: [b41a216dafe4dd23c95cb4203de288f773a097a6] i2c: Add device tree support to i2c-pnx.c

git bisect skip b41a216dafe4dd23c95cb4203de288f773a097a6

# skip: [08d050263190174914951a158ddf759177a58039] ARM: ux500: Fork cpu-db8500 platform_devs for sequential DT enablement

git bisect skip 08d050263190174914951a158ddf759177a58039

# good: [259bd6ce0200c4b9692fcbfa9cbc29d818aa2116] OMAP4: devices: Do not create dmic device if the dtb has been provided

git bisect good 259bd6ce0200c4b9692fcbfa9cbc29d818aa2116

# good: [40364b9f5a4d167d97bb6a76cd239ca8cfff056a] arm/dts: omap4-panda: Add LEDs support

git bisect good 40364b9f5a4d167d97bb6a76cd239ca8cfff056a

# good: [417f381c4568212275f0244500d7d5e1cdb5f99f] Merge branch 'soc-core' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/renesas into next/soc

git bisect good 417f381c4568212275f0244500d7d5e1cdb5f99f

# skip: [22251a9b72c46758254caf3250e6d80ea2b088c8] Merge branch 'lpc32xx/dt' of git://git.antcom.de/linux-2.6 into next/dt

git bisect skip 22251a9b72c46758254caf3250e6d80ea2b088c8

# skip: [5dfdb0a0639751781c440a00ea97630d3eafe7ca] ARM: LPC32xx: clock.c cleanup

git bisect skip 5dfdb0a0639751781c440a00ea97630d3eafe7ca

# skip: [6ec4ed82e9cf2ee5c83fd529af69b2c63b004809] Merge tag 'omap-dt-for-v3.5' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap into next/dt

git bisect skip 6ec4ed82e9cf2ee5c83fd529af69b2c63b004809

# skip: [3f3ed40060ddef0c9fb6aef021a7937f8528f32c] ARM: ux500: Rename gpio_keys in the Device Tree file

git bisect skip 3f3ed40060ddef0c9fb6aef021a7937f8528f32c

# skip: [c51423fc067b00d8c8bd0e4e7bc861bf9050511d] ARM: ux500: Enable PRCMU Timer 4 (clocksource) for Device Tree

git bisect skip c51423fc067b00d8c8bd0e4e7bc861bf9050511d

# skip: [7919fb18cfcc9bc8c4751af4b26dada052483e98] drivers/gpio: represent gpio-nomadik as an IRQ controller in DT documentation

git bisect skip 7919fb18cfcc9bc8c4751af4b26dada052483e98

# skip: [fd9a80b238ffd5fb4c82e3752327968bd7b01ad1] ARM: ux500: Rename the DT compatible entry for i2c devices on Snowball

git bisect skip fd9a80b238ffd5fb4c82e3752327968bd7b01ad1

# skip: [641f4d562cf69e1839c84c9415169644025ec247] ARM: mmp: support pxa910 with device tree

git bisect skip 641f4d562cf69e1839c84c9415169644025ec247

# bad: [8dca6010d44cc722a94dc6da96560f9083dac782] Merge tag 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc

git bisect bad 8dca6010d44cc722a94dc6da96560f9083dac782

On Thursday 24 May 2012, John Stultz wrote:

Yep. Good call, that's the one! Reverting it works for me. Thanks for catching that. After a few hours of bisecting I had gone a bit braindead. :)

Playing around with the patch, it looks like its the irq assignment thats causing problems (twl6030_mmc_card_detect_config() is returning 368). I can work around it with the hack below.

Balaji: Any thoughts on a proper fix here?

It sounds like the probe function of that driver should be changed to return -EPROBEDEFER instead of -EINVAL for this case, so we can retry the probe when the interrupt number becomes available.

Arnd