-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

On 06/27/2011 09:36 AM, Milo (Woogyom) Kim wrote:

Hi, Daniel

I found some segmentation fault in the powerdebug. If there is no clock information, then windata[win].rowdata is null. (If clock_display() returns -1, then display_set_row_data() is not called) In this case the seg fault error occurs when display_get_row_data() is called.

Thanks Milo for reporting the problem.

I opened a bug in launchpad for this:

https://bugs.launchpad.net/linaro-powerdebug/+bug/802387

Your patches are fixing the problem but I think that does not fix the root problem which is we are setting the display ops on the clocks.

At the first glance, I think we should not call display_register in the clock_init function if we are not able to access debugfs.

The same should apply to all init function for the different subsystems.

(cc'ed linaro-dev)