Remove the pass and fail count variables from the check() function as all the pass/fail/skip counts are done inside the log_end() function.
Signed-off-by: Lisa Nguyen lisa.nguyen@linaro.org --- Note: This was supposed to be part of the refactored pass/skip/fail code, but it got overlooked.
include/functions.sh | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/include/functions.sh b/include/functions.sh index 82d8139..e0f08fb 100644 --- a/include/functions.sh +++ b/include/functions.sh @@ -265,13 +265,11 @@ check() {
$func $@ if [ $? -ne 0 ]; then - log_end "Err" - fail_count=$(($fail_count + 1)) - return 1 + log_end "Err" + return 1 fi
log_end "Ok" - pass_count=$(($pass_count + 1))
return 0 }
On Friday 08 August 2014 07:04 AM, Lisa Nguyen wrote:
Remove the pass and fail count variables from the check() function as all the pass/fail/skip counts are done inside the log_end() function.
Signed-off-by: Lisa Nguyen lisa.nguyen@linaro.org
Note: This was supposed to be part of the refactored pass/skip/fail code, but it got overlooked.
include/functions.sh | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/include/functions.sh b/include/functions.sh index 82d8139..e0f08fb 100644 --- a/include/functions.sh +++ b/include/functions.sh @@ -265,13 +265,11 @@ check() { $func $@ if [ $? -ne 0 ]; then
- log_end "Err"
- fail_count=$(($fail_count + 1))
- return 1
log_end "Err"
return 1 fi
log_end "Ok"
- pass_count=$(($pass_count + 1))
return 0 }
Applied, thanks.