Re: [PATCH 2/9] ArmPlatformPkg/ArmVExpressPkg: CTA15-A7: Allow EDK2_SKIP_PEICORE to be specified at build time
On 21 June 2013 10:51, Olivier Martin olivier.martin@arm.com wrote:
If you want to use PEI Core (EDK2_SKIP_PEICORE=0) in CTA15-A7, you would need to add support ... Which is not the case today! Have a look at the macro EDK2_SKIP_PEICORE usage in RTSM-A9x4 DSC and FDF file.
Oh, I don't want to add support ;-) but I was using this patch a long time ago when I was attempting to do such crazy things due to various bugs we found interacting with Boot Monitor, etc...
So I ended up keeping this patch, even though it is never used.
But as you say, the skip support isn't there, so perhaps I should just drop this one?
-----Original Message----- From: Ryan Harkin [mailto:ryan.harkin@linaro.org] Sent: 21 June 2013 09:05 To: ryan.harkin@linaro.org; edk2-devel@lists.sourceforge.net; patches@linaro.org; boot-architecture@lists.linaro.org; Olivier Martin Subject: [PATCH 2/9] ArmPlatformPkg/ArmVExpressPkg: CTA15-A7: Allow EDK2_SKIP_PEICORE to be specified at build time
The original BSP for TC2 hard codes EDK2_SKIP_PEICORE=1, but this change allows the user to over-ride the value at build time.
Signed-off-by: Ryan Harkin ryan.harkin@linaro.org
.../ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc index c8b637a..58e1689 100644 --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc @@ -30,7 +30,9 @@ BUILD_TARGETS = DEBUG|RELEASE SKUID_IDENTIFIER = DEFAULT FLASH_DEFINITION = ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.fdf +!ifndef $(EDK2_SKIP_PEICORE) DEFINE EDK2_SKIP_PEICORE=1 +!endif
!include ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc
-- 1.7.9.5
boot-architecture mailing list boot-architecture@lists.linaro.org http://lists.linaro.org/mailman/listinfo/boot-architecture
Yes, I thinking dropping this patch is the right thing to do.
-----Original Message----- From: Ryan Harkin [mailto:ryan.harkin@linaro.org] Sent: 21 June 2013 11:04 To: Olivier Martin Cc: edk2-devel@lists.sourceforge.net; patches@linaro.org; boot- architecture@lists.linaro.org Subject: Re: [PATCH 2/9] ArmPlatformPkg/ArmVExpressPkg: CTA15-A7: Allow EDK2_SKIP_PEICORE to be specified at build time
On 21 June 2013 10:51, Olivier Martin olivier.martin@arm.com wrote:
If you want to use PEI Core (EDK2_SKIP_PEICORE=0) in CTA15-A7, you
would
need to add support ... Which is not the case today! Have a look at the macro EDK2_SKIP_PEICORE usage in RTSM-A9x4 DSC and
FDF
file.
Oh, I don't want to add support ;-) but I was using this patch a long time ago when I was attempting to do such crazy things due to various bugs we found interacting with Boot Monitor, etc...
So I ended up keeping this patch, even though it is never used.
But as you say, the skip support isn't there, so perhaps I should just drop this one?
-----Original Message----- From: Ryan Harkin [mailto:ryan.harkin@linaro.org] Sent: 21 June 2013 09:05 To: ryan.harkin@linaro.org; edk2-devel@lists.sourceforge.net; patches@linaro.org; boot-architecture@lists.linaro.org; Olivier
Martin
Subject: [PATCH 2/9] ArmPlatformPkg/ArmVExpressPkg: CTA15-A7: Allow EDK2_SKIP_PEICORE to be specified at build time
The original BSP for TC2 hard codes EDK2_SKIP_PEICORE=1, but this change allows the user to over-ride the value at build time.
Signed-off-by: Ryan Harkin ryan.harkin@linaro.org
.../ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc index c8b637a..58e1689 100644 --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc @@ -30,7 +30,9 @@ BUILD_TARGETS = DEBUG|RELEASE SKUID_IDENTIFIER = DEFAULT FLASH_DEFINITION = ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.fdf +!ifndef $(EDK2_SKIP_PEICORE) DEFINE EDK2_SKIP_PEICORE=1 +!endif
!include ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc
-- 1.7.9.5
boot-architecture mailing list boot-architecture@lists.linaro.org http://lists.linaro.org/mailman/listinfo/boot-architecture
boot-architecture@lists.linaro.org
-
Olivier Martin -
Ryan Harkin