linaro-dev March 2012

linaro-dev@lists.linaro.org

152 participants
126 discussions

by adnan ali

Hi, I started working on snowball v8 development board to investigate usb otg. My initial effort didn't gave me any result. I started investigating otg driver it seems that it starts in idle mode and then update its status to peripheral mode based on line status. Which in this case should go into host mode as per cable Mini-A. I manually put the driver into host mode and using debug messages in driver. It started to detect memory stick being plugged in and plugged out but it wasn't appearing as block device. As AB8500 interface chip documentation for usb is not in public domain makes it nearly impossible to debug the driver further. As usb otg is bus power so only low power device can be used. Thanks Adnan

12 years, 2 months

Upcoming Dates for Android 12.03 Release

by Zach Pfeffer

Its that time of the month again. From, https://wiki.linaro.org/Cycles. Here's the plan: March 15th, Toolchain WG Release 2012.03 (Done) March 22nd, Kernel WG Freeze, WGs/LTs Release March 26th, Cut Android releases (Abhishek will select the last tip that boots to a UI) March 27th, QA Android releases March 29th, Release Linaro Android 12.03 If there is something you need to get in, please get it in now. If tips aren't booting please take a look now so we can stabilize things. We've had 2 RC this month. Take a look at the QA test sheets for the bootloader testing we've done. Origen: QA sheets: https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AkxwyUNxNaAadDRDV… Snowball: QA Sheet: https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AkxwyUNxNaAadEF1N… iMX53/iMX6: QA Sheet: https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AkxwyUNxNaAadDE1M… Panda: (4430/4460) QA Sheet : https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AkxwyUNxNaAadGVWd… Vexpress: QA Sheet: https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AkxwyUNxNaAadExQd… -- Zach Pfeffer Android Platform Team Lead, Linaro Platform Teams Linaro.org | Open source software for ARM SoCs Follow Linaro: http://www.facebook.com/pages/Linaro http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog

12 years, 2 months

Plan for changing the binary toolchain to 4.7 and hardfloat

by Michael Hope

Hi there. Over the next three months both GCC 4.7 and Ubuntu 12.04 'Precise' are coming out. We'll switch over to these pretty quickly which will affect our internal testing and anyone using the binary toolchain. The changeover plan including dates, details of what's happening, and backwards compatibility is at: https://wiki.linaro.org/MichaelHope/Sandbox/BinariesMigration Comments and concerns are welcome, -- Michael

12 years, 2 months

ux500 : ethernet not working ?

by Daniel Lezcano

Hi, I am not succeeding to make ethernet to work on a 3.3-rc6 for the snowball. I noticed the same problem occured a few versions ago and was fixed [1]. But it seems some modification around the fix location was made for the 3.3 and perhaps resulted on a new regression. Was this problem already spotted for this version ? Is there a patch in this case ? Thanks -- Daniel [1] https://bugs.launchpad.net/linaro-landing-team-ste/+bug/804209 -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro:<http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog

12 years, 2 months

[PATCH v5 0/4] common clk framework

by Mike Turquette

From: Mike Turquette <mturquette(a)ti.com> The common clock framework defines a common struct clk as well as an implementation of the clk api that unifies clock operations on various platforms and devices. The net result is consolidation of many different struct clk definitions and platform-specific clock framework implementations. I consider this version merge-worthy pending ACKs from the relevant maintainers; namely Russell, Thomas and the platform folks interested in porting to this framework. I would like to thank everyone who participated in the common clk sessions at Linaro Connect and ELC; the feedback was invaluable. Also I would like to thank Shawn Guo, Richard Zhao, Saravana Kannan and Magnus Damm for tirelessly updating their platforms for the last few revisions of this patch series and providng excellent feedback each time. Major changes since v4: * rolled in TGLX's comments on overall design. We now have, * proper handling of root clocks and orphan clocks * multi-parent clocks are handled in the core * struct clk is shielded from struct clk_foo and vice versa * this is a return to the previous struct clk_hw design * split basic clock types out into separate files * split headers up by purpose * clk.h remains the driver-level interface * declarations for rate change notifiers are the only additions * clk-provider.h is primary header for implementing clock operations * clk-private.h allows for static initialization of clock data * validation and bug fixes * rebased onto Linus' v3.3-rc5 tag Patches can be pulled from: git://git.linaro.org/people/mturquette/linux.git v3.3-rc5-clkv5 v4 can be found at, http://article.gmane.org/gmane.linux.linaro.devel/8896/ v3 can be found at, http://article.gmane.org/gmane.linux.kernel/1218622 Mike Turquette (4): Documentation: common clk API clk: Kconfig: add entry for HAVE_CLK_PREPARE clk: introduce the common clock framework clk: basic clock hardware types Documentation/clk.txt | 201 +++++++ drivers/clk/Kconfig | 31 + drivers/clk/Makefile | 2 + drivers/clk/clk-divider.c | 199 +++++++ drivers/clk/clk-fixed-rate.c | 81 +++ drivers/clk/clk-gate.c | 121 ++++ drivers/clk/clk-mux.c | 114 ++++ drivers/clk/clk.c | 1323 ++++++++++++++++++++++++++++++++++++++++++ include/linux/clk-private.h | 192 ++++++ include/linux/clk-provider.h | 294 ++++++++++ include/linux/clk.h | 68 ++- 11 files changed, 2621 insertions(+), 5 deletions(-) create mode 100644 Documentation/clk.txt create mode 100644 drivers/clk/clk-divider.c create mode 100644 drivers/clk/clk-fixed-rate.c create mode 100644 drivers/clk/clk-gate.c create mode 100644 drivers/clk/clk-mux.c create mode 100644 drivers/clk/clk.c create mode 100644 include/linux/clk-private.h create mode 100644 include/linux/clk-provider.h Cc: Jeremy Kerr <jeremy.kerr(a)canonical.com> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: Arnd Bergman <arnd.bergmann(a)linaro.org> Cc: Paul Walmsley <paul(a)pwsan.com> Cc: Shawn Guo <shawn.guo(a)freescale.com> Cc: Richard Zhao <richard.zhao(a)linaro.org> Cc: Saravana Kannan <skannan(a)codeaurora.org> Cc: Magnus Damm <magnus.damm(a)gmail.com> Cc: Rob Herring <rob.herring(a)calxeda.com> Cc: Mark Brown <broonie(a)opensource.wolfsonmicro.com> Cc: Linus Walleij <linus.walleij(a)stericsson.com> Cc: Stephen Boyd <sboyd(a)codeaurora.org> Cc: Amit Kucheria <amit.kucheria(a)linaro.org> Cc: Deepak Saxena <dsaxena(a)linaro.org> Cc: Grant Likely <grant.likely(a)secretlab.ca> Cc: Andrew Lunn <andrew(a)lunn.ch> -- 1.7.5.4

12 years, 2 months

Re: Linux kernel with rpmsg and possibility for compiling powervr drivers

by Martin Ertsas (mertsas)

Sent from Samsung MobileAndy Green <andy.green(a)linaro.org> wrote:On 03/16/2012 10:46 PM, Somebody in the thread at some point said: > If you look at tilt-android-tracking, there is a complete 1.8 SGX > (usable on ICS) on fairly recent basis which includes its own rpmsg > stack as part of the SGX port. The matching userlands are available via > google AOSP. > > http://git.linaro.org/gitweb?p=landing-teams/working/ti/kernel.git;a=shortl… > > We also have what's currently only working on > > > I was a bit unclear. Sorry. First, we are thinking of using Linux for > this task instead of Android. We want rpmsg support to get access to the > m3 devices for h264 encoding and decoding. with pvr I basically meant a > dss which can be used to compile rsalvetis pvr omap 4 kernel module. Bit unclear is an understatement in this case ^^ rpmsg is a complete red herring then. 1.7 SGX as currently used in Ubuntu does not use rpmsg. All the currently available mm decode solutions for Ubuntu don't use it yet either, they use its predecessor "syslink". If you check out tilt-3.1 branch from our repo that has working syslink + tiler pieces needed by the mm decode pieces in Ubuntu and will build against SGX dkms. -Andy -- Andy Green | TI Landing Team Leader Linaro.org │ Open source software for ARM SoCs | Follow Linaro http://facebook.com/pages/Linaro/155974581091106 - http://twitter.com/#!/linaroorg - http://linaro.org/linaro-blog So what you are basically saying is forget rpmsg for the time being? Do you know if gst-ducati works with syslink then? thank you so much for your help so far.

12 years, 2 months

Slow/broken USB and Ethernet on Snowballs/Origen boards?

by Jannis Pohlmann

Hi, I am currently playing with a couple of the development boards for which there are Linaro hwpacks and LEBs. Since what I am trying to do requires a lot of disk and network I/O, I've been paying special attention to the data transfer rates I can get out of these boards. Below is a brief summary of my findings. 1) i.MX 53 * disk I/O using an external SSD drive is very good; good enough to not require further measurements * network I/O is approximately 9-10 MByte/s (perhaps more) which seems ok given the 100 MBit/s Ethernet interface 2) Snowball (PDK, version 8) * it seems to be impossible to get the USB OTG host mode to work, therefore I could not test disk I/O with a USB drive; it appears the OTG port on the version 8 board does not even have enough power for a powered USB to actually go online (I am unaware of the details of how this works unfortunately) * performing network I/O with netcat casues netcat, ksoftirqd and kworker to use ~33% of the CPU each, resulting in 100% CPU usage only to handle the network data transfer * the resulting network transfer rate is about 5.5 MByte/s, which is significantly less than what the 100 MBit/s Ethernet interface should be able to produce 3) Origen * the internal USB hub runs at Full Speed (12 MBit/s), resulting in a maximum USB disk I/O of 1.5 MByte/s * since the board does not feature Ethernet itself, I tried to attach a USB Ethernet controller to it, but of course the transfer rate through that is by the I/O upper limit of the USB hub * I did not test wireless but it is not feasible for what I am trying to do anyway I guess not all of this is surprising. The i.MX performs quite well but unfortunately the CPU is quite slow compared to the others. However, I wonder whether the USB OTG host mode issue on the Snowball is a known problem? Also, network I/O occupying all of the CPU seems to be a bug or at least a dodgy driver. About the Origen: I assume there is nothing that can be done to have High Speed USB on it? Thanks in advance! If anyone needs me to provide more information, I'll gladly try to do that. Regards, Jannis

12 years, 2 months

Flame graphs - cool perf visualisation

by Amit Kucheria

For those who don't follow LWN regularly: http://dtrace.org/blogs/brendan/2012/03/17/linux-kernel-performance-flame-g… This could be useful for tracking performance bottlenecks.

12 years, 2 months

Linaro GCC 4.6 entering maintenance; 4.5 end of life

by Michael Hope

This is the first announcement on upcoming changes to the supported Linaro GCC versions. GCC 4.7 is expected out in the next two weeks. We plan to switch to 4.7 for the Linaro GCC 2012.04 release and, as part of that, will put Linaro GCC 4.6 into maintenance and retire Linaro GCC 4.5. While in maintenance we will continue to update, fix bugs, and do releases on 4.6. No further changes or releases will be made to 4.5. All historical releases and branches will stay available. For more informatio, please see the flyer at: https://wiki.linaro.org/WorkingGroups/ToolChain/Flyer especially the section on Lifecycle: https://wiki.linaro.org/WorkingGroups/ToolChain/Flyer#Lifecycle The formal change notes will be sent after the 2012.04 release. -- Michael

12 years, 2 months

[Patch 07/07] Touch: DA9052/53 touch screen driver v1

by Ashish Jangam

This driver adds support for DA9052/53 4-wire resistive ADC interfaced touchscreen controller. DA9052/53 is a MFD therefore this driver depends on DA9052/53 core driver for core functionalities. This patch is functionally tested on Samsung SMDKV6410. Signed-off-by: David Dajun Chen <dchen(a)diasemi.com> Signed-off-by: Ashish Jangam <ashish.jangam(a)kpitcummins.com> --- drivers/input/touchscreen/Kconfig | 7 + drivers/input/touchscreen/Makefile | 1 + drivers/input/touchscreen/da9052_tsi.c | 353 ++++++++++++++++++++++++++++++++ 3 files changed, 361 insertions(+), 0 deletions(-) create mode 100644 drivers/input/touchscreen/da9052_tsi.c diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig index 2b21a70..32a3e26 100644 --- a/drivers/input/touchscreen/Kconfig +++ b/drivers/input/touchscreen/Kconfig @@ -187,6 +187,13 @@ config TOUCHSCREEN_DA9034 Say Y here to enable the support for the touchscreen found on Dialog Semiconductor DA9034 PMIC. +config TOUCHSCREEN_DA9052 + tristate "Dialog DA9052/DA9053 TSI" + depends on PMIC_DA9052 + help + Say y here to support the touchscreen found on Dialog Semiconductor + DA9052-BC and DA9053-AA/Bx PMICs. + config TOUCHSCREEN_DYNAPRO tristate "Dynapro serial touchscreen" select SERIO diff --git a/drivers/input/touchscreen/Makefile b/drivers/input/touchscreen/Makefile index d9acbdc..c76b21c 100644 --- a/drivers/input/touchscreen/Makefile +++ b/drivers/input/touchscreen/Makefile @@ -22,6 +22,7 @@ obj-$(CONFIG_TOUCHSCREEN_CYTTSP_CORE) += cyttsp_core.o obj-$(CONFIG_TOUCHSCREEN_CYTTSP_I2C) += cyttsp_i2c.o obj-$(CONFIG_TOUCHSCREEN_CYTTSP_SPI) += cyttsp_spi.o obj-$(CONFIG_TOUCHSCREEN_DA9034) += da9034-ts.o +obj-$(CONFIG_TOUCHSCREEN_DA9052) += da9052_tsi.o obj-$(CONFIG_TOUCHSCREEN_DYNAPRO) += dynapro.o obj-$(CONFIG_TOUCHSCREEN_HAMPSHIRE) += hampshire.o obj-$(CONFIG_TOUCHSCREEN_GUNZE) += gunze.o diff --git a/drivers/input/touchscreen/da9052_tsi.c b/drivers/input/touchscreen/da9052_tsi.c new file mode 100644 index 0000000..8c672ee --- /dev/null +++ b/drivers/input/touchscreen/da9052_tsi.c @@ -0,0 +1,353 @@ +/* + * TSI driver for Dialog DA9052 + * + * Copyright(c) 2012 Dialog Semiconductor Ltd. + * + * Author: David Dajun Chen <dchen(a)diasemi.com> + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the + * Free Software Foundation; either version 2 of the License, or (at your + * option) any later version. + * + */ +#include <linux/module.h> +#include <linux/input.h> +#include <linux/delay.h> +#include <linux/platform_device.h> +#include <linux/interrupt.h> + +#include <linux/mfd/da9052/reg.h> +#include <linux/mfd/da9052/da9052.h> + +#define TSI_PEN_DOWN_STATUS 0x40 + +struct da9052_tsi { + struct da9052 *da9052; + struct input_dev *dev; + struct delayed_work ts_pen_work; + int irq_pendwn; + int irq_datardy; +}; + +static int da9052_ts_start(struct da9052_tsi *tsi) +{ + return da9052_reg_update(tsi->da9052, DA9052_TSI_CONT_A_REG, + 1 << 0, 1 << 0); +} + +static int da9052_ts_stop(struct da9052_tsi *tsi) +{ + return da9052_reg_update(tsi->da9052, DA9052_TSI_CONT_A_REG, 1 << 0, 0); +} + +static irqreturn_t da9052_ts_pendwn_irq(int irq, void *data) +{ + struct da9052_tsi *tsi = data; + + /* Mask PEN_DOWN event and unmask TSI_READY event */ + disable_irq_nosync(tsi->irq_pendwn); + enable_irq(tsi->irq_datardy); + + da9052_ts_start(tsi); + + input_report_key(tsi->dev, BTN_TOUCH, 1); + input_sync(tsi->dev); + + schedule_delayed_work(&tsi->ts_pen_work, HZ/50); + + return IRQ_HANDLED; +} + +static int da9052_ts_read(struct da9052_tsi *tsi) +{ + int ret = 0; + u16 x, y, z; + u8 v; + + ret = da9052_reg_read(tsi->da9052, DA9052_TSI_X_MSB_REG); + if (ret < 0) + goto exit; + + x = (u16) ret; + + ret = da9052_reg_read(tsi->da9052, DA9052_TSI_Y_MSB_REG); + if (ret < 0) + goto exit; + + y = (u16) ret; + + ret = da9052_reg_read(tsi->da9052, DA9052_TSI_Z_MSB_REG); + if (ret < 0) + goto exit; + + z = (u16) ret; + + ret = da9052_reg_read(tsi->da9052, DA9052_TSI_LSB_REG); + if (ret < 0) + goto exit; + + v = (u8) ret; + + x = ((x << 2) & 0x3fc) | (v & 0x3); + y = ((y << 2) & 0x3fc) | ((v & 0xc) >> 2); + z = ((z << 2) & 0x3fc) | ((v & 0x30) >> 4); + + input_report_abs(tsi->dev, ABS_X, x); + input_report_abs(tsi->dev, ABS_Y, y); + input_report_abs(tsi->dev, ABS_PRESSURE, z); + input_report_key(tsi->dev, BTN_TOUCH, 1); + input_sync(tsi->dev); + +exit: + return ret; +} + +static irqreturn_t da9052_ts_datardy_irq(int irq, void *data) +{ + struct da9052_tsi *tsi = data; + + da9052_ts_read(tsi); + return IRQ_HANDLED; +} + +static void da9052_ts_pen_work(struct work_struct *work) +{ + struct da9052_tsi *tsi = container_of(work, struct da9052_tsi, + ts_pen_work.work); + struct input_dev *ip_dev = tsi->dev; + int ret; + + ret = da9052_reg_read(tsi->da9052, DA9052_TSI_LSB_REG); + if (ret < 0) + return; + + if (ret & TSI_PEN_DOWN_STATUS) /* Pen Down */ + schedule_delayed_work(&tsi->ts_pen_work, HZ/50); + else { + /* Pen UP */ + da9052_ts_stop(tsi); + + /* Mask TSI_READY event and unmask PEN_DOWN event */ + disable_irq(tsi->irq_datardy); + enable_irq(tsi->irq_pendwn); + + /* Report Pen UP */ + input_report_abs(ip_dev, ABS_PRESSURE, 0); + input_report_key(ip_dev, BTN_TOUCH, 0); + input_sync(ip_dev); + } +} + +static int __devinit da9052_ts_configure_gpio(struct da9052 *da9052) +{ + int ret; + + ret = da9052_reg_update(da9052, DA9052_GPIO_2_3_REG, 0x30, 0); + if (ret < 0) + return ret; + + ret = da9052_reg_update(da9052, DA9052_GPIO_4_5_REG, 0x33, 0); + if (ret < 0) + return ret; + + ret = da9052_reg_update(da9052, DA9052_GPIO_6_7_REG, 0x33, 0); + + return ret; +} + +static int __devinit da9052_configure_tsi(struct da9052_tsi *tsi) +{ + ssize_t ret; + + ret = da9052_ts_configure_gpio(tsi->da9052); + if (ret < 0) + return ret; + + /* Measure TSI sample every 1ms */ + ret = da9052_reg_update(tsi->da9052, DA9052_ADC_CONT_REG, + 1 << 6, 1 << 6); + if (ret < 0) + return ret; + + /* TSI_DELAY: 3 slots, TSI_SKIP: 0 slots, TSI_MODE: XYZP */ + ret = da9052_reg_update(tsi->da9052, DA9052_TSI_CONT_A_REG, 0xFC, 0xC0); + if (ret < 0) + return ret; + + /* Mask PEN_DOWN and TSI_READY events */ + disable_irq(tsi->irq_pendwn); + disable_irq(tsi->irq_datardy); + + /*Supply TSIRef through LD09 */ + ret = da9052_reg_write(tsi->da9052, DA9052_LDO9_REG, 0x59); + + return ret; +} + +static int da9052_ts_input_open(struct input_dev *input_dev) +{ + struct da9052_tsi *tsi = input_get_drvdata(input_dev); + + /* Unmask PEN_DOWN event */ + enable_irq(tsi->irq_pendwn); + + /* Enable Pen Detect Circuit */ + return da9052_reg_update(tsi->da9052, DA9052_TSI_CONT_A_REG, + 1 << 1, 1 << 1); +} + +static void da9052_ts_input_close(struct input_dev *input_dev) +{ + struct da9052_tsi *tsi = input_get_drvdata(input_dev); + int ret; + + ret = da9052_reg_read(tsi->da9052, DA9052_TSI_LSB_REG); + + if (ret & TSI_PEN_DOWN_STATUS) /* Pen Down */ + disable_irq(tsi->irq_datardy); + else + disable_irq(tsi->irq_pendwn); + + cancel_delayed_work_sync(&tsi->ts_pen_work); + + da9052_ts_stop(tsi); + + /* Disable Pen Detect Circuit */ + da9052_reg_update(tsi->da9052, DA9052_TSI_CONT_A_REG, 1 << 1, 0); +} + +static int __devinit da9052_ts_probe(struct platform_device *pdev) +{ + struct da9052_tsi *tsi; + struct input_dev *input_dev; + struct da9052 *da9052; + int ret; + + da9052 = dev_get_drvdata(pdev->dev.parent); + if (da9052 == NULL) + return -EINVAL; + + tsi = devm_kzalloc(&pdev->dev, sizeof(struct da9052_tsi), GFP_KERNEL); + if (!tsi) + return -ENOMEM; + + input_dev = input_allocate_device(); + if (!input_dev) { + dev_err(tsi->da9052->dev, "Failed to allocate input device\n"); + ret = -ENOMEM; + goto err_mem; + } + + INIT_DELAYED_WORK(&tsi->ts_pen_work, da9052_ts_pen_work); + + tsi->da9052 = da9052; + + input_dev->id.version = 0x0101; + input_dev->id.vendor = 0x15B6; + input_dev->id.product = 0x9052; + input_dev->name = "Dialog DA9052 TouchScreen Driver"; + input_dev->dev.parent = &pdev->dev; + input_dev->open = da9052_ts_input_open; + input_dev->close = da9052_ts_input_close; + __set_bit(EV_ABS, input_dev->evbit); + __set_bit(EV_KEY, input_dev->evbit); + __set_bit(BTN_TOUCH, input_dev->keybit); + + input_set_abs_params(input_dev, ABS_X, 0, 1023, 0, 0); + input_set_abs_params(input_dev, ABS_Y, 0, 1023, 0, 0); + input_set_abs_params(input_dev, ABS_PRESSURE, 0, 1023, 0, 0); + + tsi->dev = input_dev; + input_set_drvdata(input_dev, tsi); + + tsi->irq_pendwn = platform_get_irq_byname(pdev, "PENDWN"); + if (tsi->irq_pendwn < 0) { + ret = tsi->irq_pendwn; + goto err_input; + } + + ret = request_threaded_irq(tsi->irq_pendwn, NULL, da9052_ts_pendwn_irq, + IRQF_TRIGGER_LOW | IRQF_ONESHOT, + "PENDWN", tsi); + if (ret < 0) { + dev_err(tsi->da9052->dev, + "Failed to register %s IRQ %d, error = %d\n", "PENDWN", + tsi->irq_pendwn, ret); + goto err_input; + } + + tsi->irq_datardy = platform_get_irq_byname(pdev, "TSIRDY"); + if (tsi->irq_datardy < 0) { + ret = tsi->irq_datardy; + goto err_pendwn_irq; + } + + ret = request_threaded_irq(tsi->irq_datardy, NULL, + da9052_ts_datardy_irq, + IRQF_TRIGGER_LOW | IRQF_ONESHOT, + "TSIRDY", tsi); + if (ret < 0) { + dev_err(tsi->da9052->dev, + "Failed to register %s IRQ %d, error = %d\n", "TSIRDY", + tsi->irq_datardy, ret); + goto err_pendwn_irq; + } + + ret = da9052_configure_tsi(tsi); + if (ret < 0) + goto err_datardy_irq; + + ret = input_register_device(tsi->dev); + if (ret < 0) + goto err_datardy_irq; + + platform_set_drvdata(pdev, tsi); + + return 0; + +err_datardy_irq: + free_irq(tsi->irq_datardy, tsi); +err_pendwn_irq: + free_irq(tsi->irq_pendwn, tsi); +err_input: + input_free_device(input_dev); +err_mem: + devm_kfree(&pdev->dev, tsi); + return ret; +} + +static int __devexit da9052_ts_remove(struct platform_device *pdev) +{ + struct da9052_tsi *tsi = platform_get_drvdata(pdev); + + da9052_reg_write(tsi->da9052, DA9052_LDO9_REG, 0x19); + + free_irq(tsi->irq_pendwn, tsi); + free_irq(tsi->irq_datardy, tsi); + + input_unregister_device(tsi->dev); + + platform_set_drvdata(pdev, NULL); + + devm_kfree(&pdev->dev, tsi); + + return 0; +} + +static struct platform_driver da9052_tsi_driver = { + + .probe = da9052_ts_probe, + .remove = __devexit_p(da9052_ts_remove), + .driver = { + .name = "da9052-tsi", + .owner = THIS_MODULE, + }, +}; + +module_platform_driver(da9052_tsi_driver); + +MODULE_DESCRIPTION("Touchscreen driver for Dialog Semiconductor DA9052"); +MODULE_AUTHOR("David Dajun Chen <dchen(a)diasemi.com>"); +MODULE_LICENSE("GPL"); +MODULE_ALIAS("platform:da9052-tsi");

12 years, 2 months

← Newer
1
...
4
5
6
7
8
9
10
...
13
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

linaro-dev March 2012